Hi Holger,
Holger Freyther: Looks good to me, approved
In http://git.osmocom.org/osmo-pcu, one of the 5 patches submitted for Gerrit review(MCS5-MCS9 support in EGPRS UL)has been merged to master. As this patch is part of series of 5 patches it should be merged in below order.
1) Remove GMSK only check in EGPRS UL(Change-Id:I567acc012d8ad49681715f0104ba7e91625e1e7a) 2) Add Header Type2 support in EGPRS UL(Change-Id:Iac2422c8acbdcefe20aafbba6a4eb87c9893e3ba) 3) Add header type 1 support for EGPRS uplink(Change-Id:I13c250e2e07377982ac3f29745f3cffd4088552a) 4) Add test cases for Header Type 2 in EGPRS UL(Change-Id:I1dd46010065a6d6da21e8e45af71e6d5f649b0b0) 5) Add test cases for Header type1 in EGPRS UL(Change-Id:I21811bb126dbe151b0708a964d3143bc2fd52389)
Currently osmo-pcu build is failing since only patch 4 of the list above has been merged. Can you please let me know how to proceed over this? Going forward it will be helpful for us if you can suggest how to number the patches of a series in Gerrit review.
Thanks, Aravind Sirsikar
Curious: "make" works fine but "make check" fails for me too. I'm puzzled how it have made it through jenkins.
On 06/16/2016 01:23 PM, Aravind Sirsikar wrote:
Hi Holger,
Holger Freyther: Looks good to me, approved
In http://git.osmocom.org/osmo-pcu, one of the 5 patches submitted for Gerrit review(MCS5-MCS9 support in EGPRS UL)has been merged to master. As this patch is part of series of 5 patches it should be merged in below order.
- Remove GMSK only check in EGPRS UL(Change-Id:I567acc012d8ad49681715f0104ba7e91625e1e7a)
- Add Header Type2 support in EGPRS UL(Change-Id:Iac2422c8acbdcefe20aafbba6a4eb87c9893e3ba)
- Add header type 1 support for EGPRS uplink(Change-Id:I13c250e2e07377982ac3f29745f3cffd4088552a)
- Add test cases for Header Type 2 in EGPRS UL(Change-Id:I1dd46010065a6d6da21e8e45af71e6d5f649b0b0)
- Add test cases for Header type1 in EGPRS UL(Change-Id:I21811bb126dbe151b0708a964d3143bc2fd52389)
Currently osmo-pcu build is failing since only patch 4 of the list above has been merged. Can you please let me know how to proceed over this? Going forward it will be helpful for us if you can suggest how to number the patches of a series in Gerrit review.
Thanks, Aravind Sirsikar
On 16 Jun 2016, at 16:03, Max msuraev@sysmocom.de wrote:
Curious: "make" works fine but "make check" fails for me too. I'm puzzled how it have made it through jenkins.
Jenkins makes "git checkout SHA1" so it picks the right parent. It looked like the first patch o the series. :)
Hi Aravind,
to resolve the current issue, I have merged the remaining patches from those listed in your mail.
Going forward it will be helpful for us if you can suggest how to number the patches of a series in Gerrit review.
For this more generic question on how to submit certain batches of patches relating to one topic, I would like to defer the question to Neels who has gained most experience in this context.
Can you please also explain how you solved the WAIT_ASSIGN problem as indicated in https://gerrit.osmocom.org/#/c/218/ ? Do you have a specific fix against the bug introduced by the introduction of the WAIT_ASSIGN state?
Hi Harald,
to resolve the current issue, I have merged the remaining patches from those listed in your mail.
I see you have missed last patch related to "MCS5-MCS9 support for EGPRS UL" with change Id I21811bb126dbe151b0708a964d3143bc2fd52389. Can you please merge it also so that I can start submitting patches related to next feature.
Thanks, Aravind Sirsikar
Hi Harald,
Can you please also explain how you solved the WAIT_ASSIGN problem as indicated in https://gerrit.osmocom.org/#/c/218/ ? Do you have a specific fix against the bug introduced by the introduction of the WAIT_ASSIGN state?
We have earlier informed in mailing list as well that GPRS issue is likely in one phase access. Hence to avoid this we made a work around by enabling two-phase-access in osmo-pcu.cfg. This work around helps in establishing GPRS call successfully. Due to our current work priorities we have not further investigated root cause of the GPRS one phase access failure.
Thanks, Aravind Sirsikar
On Thu, Jun 16, 2016 at 04:41:17PM +0200, Harald Welte wrote:
Hi Aravind,
to resolve the current issue, I have merged the remaining patches from those listed in your mail.
Going forward it will be helpful for us if you can suggest how to number the patches of a series in Gerrit review.
osmo-pcu's gerrit was still in the "cherry pick" strategy until today. Now that it is changed to "rebase if necessary", you will be able to submit patches in sequence by simply pushing a branch HEAD to submit all branch commits for review. Gerrit should keep the right sequence now. Do take note of this quirk: http://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Re-submit-a-...
~Neels
osmocom-net-gprs@lists.osmocom.org
-
Aravind Sirsikar -
Harald Welte -
Holger Freyther -
Max -
Neels Hofmeyr