[EGPRS] Gerrit guidance to address Jenkins Build failure and resubmission of patch.
Hi, Can you guide us to address issues we are currently facing about Gerrit process as listed below 1) Jenkins Build reports failure. Can you suggest the reason for this. Because in our local branch the Unit test and build is successful. 2) Is there any specific process to resubmit patch after addressing the review comments. Thanks, Aravind Sirsikar
Not sure if it's related but in jenkins logs for one of the latest builds [1] I've noticed following: Documentation error (missing docs): <command id='show asciidoc counters'> <param name='asciidoc' doc='(null)' /> <param name='counters' doc='(null)' /> Documentation error (missing docs): <command id='show asciidoc counters'> <param name='asciidoc' doc='(null)' /> <param name='counters' doc='(null)' /> In general, gerrit have link to jenkins for particular build failure. As for 2nd question - the patch is identified by "Change-Id" in the commit message so all you've got to do is to re-send the patch with the same id. Personally I use gerrit extension for magit in emacs to obtain the patch and git-review for submission. In general - please refer to http://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit. On 06/15/2016 11:02 AM, Aravind Sirsikar wrote:
Hi, Can you guide us to address issues we are currently facing about Gerrit process as listed below 1) Jenkins Build reports failure. Can you suggest the reason for this. Because in our local branch the Unit test and build is successful. 2) Is there any specific process to resubmit patch after addressing the review comments.
Thanks, Aravind Sirsikar
[1] http://jenkins.osmocom.org/jenkins/job/osmo-pcu-gerrit/label=linux_amd64_ubu... -- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
Hi Max,
Documentation error (missing docs): <command id='show asciidoc counters'> <param name='asciidoc' doc='(null)' /> <param name='counters' doc='(null)' />
This thing we have also noticed. But we don't know the reason for this error reported by Jenkins. Can you please help us to address this issue for patch resubmission. Thanks, Aravind Sirsikar
On Wed, Jun 15, 2016 at 09:28:16AM +0000, Aravind Sirsikar wrote:
This thing we have also noticed. But we don't know the reason for this error reported by Jenkins. Can you please help us to address this issue for patch resubmission.
the issue is that a patch adding the 'show asciidoc counters' vty command was added to libosmocore (written by Lynxis, approved by me) - but that patch didn't contain well-formed help syntax for the VTY command: https://gerrit.osmocom.org/#/c/70/ Unfortunately I believe this is not tested in libosmocore (as it jus builds a library), but the error only shows up once you build and test an application linking the library, such as the PCU. I pushed a fix and submitted it, see https://gerrit.osmocom.org/#/c/276/ This jenkins failure should thus be resolved now. -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Hi Harald,
the issue is that a patch adding the 'show asciidoc counters' vty command was added to libosmocore (written by Lynxis, approved by me) - but that patch didn't
As Jenkins has failed the build for all the 5 patches, do I need to resend all the patches again? Thanks, Aravind Sirsikar
If you have access to jenkins you can manually retrigger corresponding build but since re-sending the patch series is just single command (git review) which takes less than 1 minute to execute I think it would be quicker that way. On 06/15/2016 12:29 PM, Aravind Sirsikar wrote:
Hi Harald,
the issue is that a patch adding the 'show asciidoc counters' vty command was added to libosmocore (written by Lynxis, approved by me) - but that patch didn't As Jenkins has failed the build for all the 5 patches, do I need to resend all the patches again?
Thanks, Aravind Sirsikar
-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
On Wed, Jun 15, 2016 at 01:24:02PM +0200, Max wrote:
If you have access to jenkins you can manually retrigger corresponding build but since re-sending the patch series is just single command (git review) which takes less than 1 minute to execute I think it would be quicker that way.
Gerrit will refuse resending identical patches. We can click 'rebase' on the gerrit website to retrigger a build, once some other patch (i.e. max's fix) has been pushed to master. Alternatively radisys can rebase locally onto the updated master and then re-submit to gerrit. ~Neels -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
On 15 Jun 2016, at 15:53, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Wed, Jun 15, 2016 at 01:24:02PM +0200, Max wrote:
If you have access to jenkins you can manually retrigger corresponding build but since re-sending the patch series is just single command (git review) which takes less than 1 minute to execute I think it would be quicker that way.
Gerrit will refuse resending identical patches.
We can click 'rebase' on the gerrit website to retrigger a build, once some other patch (i.e. max's fix) has been pushed to master.
Alternatively radisys can rebase locally onto the updated master and then re-submit to gerrit.
you can just re-trigger the failed job. I did retrigger for two of them. Which others failed? holger
On Wed, Jun 15, 2016 at 04:01:10PM +0200, Holger Freyther wrote:
you can just re-trigger the failed job. I did retrigger for two of them. Which others failed?
Can I also retrigger? How?? Not by the "Rebase" button, then? I'm not sure if a plain retrigger would be sufficient if some other change is needed first. ~Neels -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
When jenkins build fails there's a link to particular build - if you follow it you can click "retrigger" in the left menu for particular build in jenkins (provided you have account). On 06/16/2016 01:32 PM, Neels Hofmeyr wrote:
On Wed, Jun 15, 2016 at 04:01:10PM +0200, Holger Freyther wrote:
you can just re-trigger the failed job. I did retrigger for two of them. Which others failed? Can I also retrigger? How?? Not by the "Rebase" button, then?
I'm not sure if a plain retrigger would be sufficient if some other change is needed first.
~Neels
-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
Hi Max,
When jenkins build fails there's a link to particular build - if you follow it you can click "retrigger" in the left menu for particular build in jenkins (provided you have account).
I followed the link mentioned in Gerrit for the failed build http://jenkins.osmocom.org/jenkins/job/osmo-pcu-gerrit/81/ but I am not able to locate the "retrigger" button. Can you please help? Thanks, Aravind Sirsikar
On Fri, Jun 17, 2016 at 09:29:58AM +0000, Aravind Sirsikar wrote:
Hi Max,
When jenkins build fails there's a link to particular build - if you follow it you can click "retrigger" in the left menu for particular build in jenkins (provided you have account).
I followed the link mentioned in Gerrit for the failed build http://jenkins.osmocom.org/jenkins/job/osmo-pcu-gerrit/81/ but I am not able to locate the "retrigger" button. Can you please help?
I also overlooked this minor detail: you need to be logged in on jenkins to see the retrigger button (i.e. "Sign in" on the top right). You may have to create an account first, not sure if it will have permissions to retrigger though. The "rebase" button remains a workaround, which works as soon as another patch was merged to master (which usually should be the case if you were waiting for someone else's fix). ~Neels -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
Hi Holger,
I followed the link mentioned in Gerrit for the failed build http://jenkins.osmocom.org/jenkins/job/osmo-pcu-gerrit/81/ but I am not able to locate the "retrigger" button. Can you please help?
I am able to resolve the Jenkins failure after attempting rebase. Jenkins Build has now succeeded. Can you please merge the same to master. Thanks, Aravind Sirsikar
participants (5)
-
Aravind Sirsikar -
Harald Welte -
Holger Freyther -
Max -
Neels Hofmeyr