Re: [PATCH 1/4] Add data structure for MCS change in Retx

On 11 Apr 2016, at 06:45, Aravind Sirsikar Arvind.Sirsikar@radisys.com wrote:

Dear Aravind,

• /*

• * cs2 is variable to hold the cs value for
  

• * current transmission. cs2 is same as cs during
  

• * transmission case. During retransmission cs2 is
  

• * fetched from egprs_mcs_retx_tbl table based on
  

• * cs and demanded cs. Once the data has been sent successfully,
  

• * cs2 will be copied to cs. Reference is 44.060 Table
  

• * 8.1.1.1 and Table 8.1.1.2
  

• */
  

• GprsCodingScheme cs2; GprsCodingScheme cs;

the comment is good and much appreciated. In general putting a suffix like '1' and '2' to variables is something I would like to avoid. E.g. when somebody needs to decide on 1 vs. 2. Can you think of more expressive names?

cs_initial cs_retrans

cheers holger