29 Oct
2016
29 Oct
'16
9:38 p.m.
On 13 Jul 2016, at 13:51, Holger Freyther holger@freyther.de wrote:
Hey!
After looking at the code, I don't think reusing table implementation would be easy - the approaches are too different as well as underlying data structures.
okay. then we will need to use the tree based version and from my point of view we should do it the following way:
- Remove osmo_t4_decode (and related routines) from libosmocore (last step)
- Make the tree based decoder ready in terms of the surrounding style
- Adopt/Clone the osmo_t4_decode tests and move them to the PCU (as part of the commit that adds the decoder to the PCU)
@Me: After the infrastructure is in the PCU I will remove osmo_t4_decode (and tests) from libosmocore
thanks to the review and patience of Neels and Harald the tree based t4 decoding is now in osmo-pcu and I have pushed https://gerrit.osmocom.org/1176 for review.
holger