osmocom-net-gprs

osmocom-net-gprs@lists.osmocom.org

6 participants
480 discussions

[PATCH 1/2] llist: Reduce the external dependencies of this test

by Holger Hans Peter Freyther

Debian is using the classic bfd linker and when passing libosmogb as link dependency it always wants/needs to resolve the bssgp_prim_cb symbol (which is to be provided by the application). Only keep the libosmocore dependency. Fixes: lib/libosmogb.so: undefined reference to `bssgp_prim_cb' collect2: error: ld returned 1 exit status Makefile:511: recipe for target 'llist/LListTest' failed --- tests/Makefile.am | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index b822e46..77760f3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -56,9 +56,6 @@ ms_MsTest_LDFLAGS = \ llist_LListTest_SOURCES = llist/LListTest.cpp llist_LListTest_LDADD = \ - $(top_builddir)/src/libgprs.la \ - $(LIBOSMOGB_LIBS) \ - $(LIBOSMOGSM_LIBS) \ $(LIBOSMOCORE_LIBS) \ $(COMMON_LA) -- 2.3.5

10 years

OsmoBTS - OsmocomBB emulation project

by Dominiq T

Dear Osmcom, I am working on a project, where I am connecting OsmoBTS with OsmocomBB without hardware. I am trying to remove l1 on both sides and connect OsmoBTS with BB application via simple unix sockets. Based on the further recommendations, I am using osmobts-trx branch. Currently I am able to handle messages between BTS and TRX driver on clock and control ports, and on BB side I am in state that phone wants to connect into a cell (so its waiting for BCCH) . I am now trying to find a possible way how to handle messages on data port , between BTS – TRX ( TRX is removed, there is my application instead), and forward these messages to my customized BB l1 interface . The thing is that I need to send to BB phone (layer23) messages in structures from gsm_04_08.h (i.e. gsm48_system_information_type_3). I am not sure if I will be able to get needed from the messages coming on the data port 5702. I found, that PCU creates unix socket on “/tmp/pcu_bts” , but only in case sysmoBTS is in use (please correct me if I am wrong), so this will be not possible due compilation errors without HW. Here I found the gsm48_system_information_type_3 messages. So basically I need somehow to get this message structures on my custom l1 BB interface. Do you have any idea how to do this ? Any advice will be highly appreciated. Many thanks you for your attention :) Best regards, Dominik Tamaskovic.

10 years, 2 months

Announcing OsmoDevCon 2015

by Harald Welte

Dear Osmocom.org project members, I'm happy to be able to announce the annual incarnation of OsmoDevCon. The Date is set for March 27 through 30. Venue: As usual, IN-Berlin e.V. in Berlin, Germany. Further details can be obtained from http://openbsc.osmocom.org/trac/wiki/OsmoDevCon2015 Attendance, as usual, is restricted to people with an active history in the Project by contributions in terms of code, patches, discussions, documentation or in other form. = Registration = If you have wiki access, please add yourself to the #Requested section. Alternatively, you can send me private e-mail about it. After review, your (nick)name will be listed in the #Confirmed section. Looking forward to meeting all of you again soon! -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)

10 years, 4 months

Re: Configure problem with openggsn

by nisse＠southpole.se

Holger Hans Peter Freyther <hfreyther(a)sysmocom.de> writes: > If you don't want to use linux/if.h then change it? E.g. something > like this? Thanks for the response. I did something similar. I don't have the code in front of me, (and the project where I used openggsn is not very active at the moment), but I think the result of these configure tests are unused. If tun.c never checks HAVE_NET_IF_H, the corresponding configure test could be deleted. Regards, /Niels

10 years, 7 months

Fwd: Running OpenGGSN with UmTRX(Osmobts-trx)

by Joe Ge

Hi All, I have installed OpenBSC +Osmo-BTS following Osmocom's netwrok from scratch link http://openbsc.osmocom.org/trac/wiki/network_from_scratch Now I would like to implemenet GPRS facility in the testbedusing OpenGGSN and Osmo-SGSN. I am using fairwaves UmDESK for this implementation. I followed the procedure as suggested in the http://openbsc.osmocom.org/trac/wiki/OpenBSC_GPRS with the added modification as suggested in https://wush.net/trac/rangepublic/wiki/fairwaves.gprs But this doesn't seem to work out. Currently the systems execute properly with the following outputs *GGSN Output:* root@nist:/home/nist# ggsn cmdline_parser_configfile listen: 127.0.0.1 conf: /etc/ggsn.conf fg: 1 debug: 1 qos: 0x0b921f apn: internet net: 192.168.0.0/24 dynip: 192.168.0.0/24 pidfile: /var/run/ggsn.pid statedir: /var/lib/ggsn/ timelimit: 0 gtpclient: Initialising GTP tunnel openggsn[3822]: GTP: gtp_newgsn() started Creating tun interface Setting tun IP address *Osmo-SGSN Output:* root@nist:/home/nist# osmo-sgsn -c OpenBSC_GPRS/openbsc/openbsc/src/gprs/osmo_sgsn.cfg <0010> gprs_ns.c:199 NSVCI=65534 Creating NS-VC *Osmo-PCU Output:* root@nist:/home/nist# osmo-pcu No config file: 'osmo-pcu.cfg' Using default config. With these I also ran: Osmo-NITB Osmobts-TRX Osmo-TRX All of these run normally as well. My UE is able to detect the network as well but not able to connect with it. Given below are the config file entries *ggsn.conf:* listen 127.0.0.1 *osmo-sgsn.cfg:* gtp local-ip 127.0.0.2 ggsn 0 remote-ip 127.0.0.1 ..... encapsulation udp local-ip 127.0.0.2 *open-bsc.cfg*: gprs nsvc 0 remote udp port 23000 gprs nsvc 0 remote ip 127.0.0.2 I had the following doubts regarding the given installation procedure 1. The fairwaves.gprs implementation using Chemeris's gprs-work seems to implement with Asterisk as PBX whereas I require it to run with the osmo-nitb. 2. The gprs-work branch still makes use of BTS transceiver and I wanted it to work with the Osmo-nitb implementation using osmobts-trx and osmo-trx Can somebody please help me out with this? Or is there any alternative implementation which can be tried to execute them together. Looking forward to hearing from you, With Regards, Jijo

11 years, 1 month

State of sysmocom/master and upcoming work

by Holger Hans Peter Freyther

Hi, Daniel and me spent another day in the sysmocom office to go through the PCU code. We finished clean-ups, made some simple manual tests and looked at the traces. We will work on the following items during the next weeks: * For DL handling and multi-slot allocation more than one slot will only be allocated _after_ the TBF is re-used. E.g. for a simple download this might mean a single slot is used for the entire download. Daniel made a prototype to send a packet downlink assignment directly _after_ the assignment through the CCCH has completed. We manage to run into a use after free in the TBF code but will work on it. The issue is that the start of a TBF will take a bit longer. We might want to add some heuristic to decide when or when not to do it. * Re-sending and window stalls. When the entire window has been sent once, resending will start but when the ACK/NACK is arrived the resending will conntinue. As it is more likely that frames have arrived we should stop the resending and increase the window. This will increase the throughput. cheers holger -- - Holger Freyther <hfreyther(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

11 years, 5 months

[PATCH 1/1] Set csnStream direction *after* csnStreamInit

by Daniel Willmann

Fixes a bug introduced in commit 402cdc. That commit sets direction to zero so setting it to 1 should be done after the call to csnStreamInit(). This issue was discovered by the rlcmac test. --- src/csn1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/csn1.cpp b/src/csn1.cpp index 7f64823..258f7c9 100644 --- a/src/csn1.cpp +++ b/src/csn1.cpp @@ -544,11 +544,11 @@ csnStreamDecoder(csnStream_t* ar, const CSN_DESCR* pDescr, bitvec *vector, unsig guint8 length = bitvec_read_field(vector, readIndex, length_len); LOGPC(DCSN1, LOGL_NOTICE, "%s length = %d | ", pDescr->sz , (int)length); - arT.direction = 1; bit_offset += length_len; remaining_bits_len -= length_len; csnStreamInit(&arT, bit_offset, length); + arT.direction = 1; Status = serialize(&arT, vector, readIndex, pvDATA(data, pDescr->offset)); if (Status >= 0) -- 1.8.4.2

11 years, 5 months

Multislot allocation failures and defects

by Holger Hans Peter Freyther

Dear Andreas, I went through the multislot allocation algorithm and cleaned and structured the code in testable parts that take over parts of the allocation and I have added a unit test for some of the allocation cases (UL first, then DL.. e.g. due a RACH burst and then DL single, UL and DL update). Today morning I added a testcase that tests all PDCH combinations and all MS Classes and verifies that an allocation takes place and that the DL and UL first_common_ts do match. For (xxOxOOxO) and MS_Class=5 this assert is wrong. The alloc/AllocTest of the sysmocom/allocation-cleanups branch should show you this condition. While reading the code I noticed the following things. Could you please explain why these are problems or no problems. * select_first_ts (it exists after the refactoring). It initializes i and compares it but it will never increment it. This means that the code can look at PDCHs _outside_ of the tx_range. * first_common_ts handling. When assigning the DL tbf we pick a first_common_ts but when the actual UL assignment happens there might not be a free USF on the Uplink and at that point the phone might not listen on the TS we think. * Sum for Rx+Tx is not used. I see that in update_rx_win_max you modify the window to make some room. * select_ul_slots. "i" is not incremented in all cases which could potentially lead to using slots outside of the tx_range. For the MS Type == 1 handling you could introduce a different variable that counts how many slots were used? it would be nice if we could fix that during the 30C3. holger -- - Holger Freyther <hfreyther(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

11 years, 5 months

Coverity issues in gsm_rlcmac.cpp

by Holger Hans Peter Freyther

Dear Ivan, could you please have a look at the coverity issues in the gsm_rlcmac.cpp routines? Uninitialized scalar variable: gsm_rlcmac.cpp:5321 ar.direction not initialized gsm_rlcmac.cpp:5039 ar.direction not initialized gsm_rlcmac.cpp:5155 ar.direction not initialized gsm_rlcmac.cpp:4872 ar.direction not initialized Just initialize it in csnStreamInit? Out-of-bounds read: gsm_rlcmac.cpp:5502 " Overrunning array "data->RLC_DATA" of 20 bytes at byte offset 22 using index "i" (which evaluates to 22)." gsm_rlcmac.cpp:5440 " Overrunning array "data->RLC_DATA" of 20 bytes at byte offset 22 using index "i" (which evaluates to 22)." Maybe just add an assert that dataNumOctets <= 20? -- - Holger Freyther <hfreyther(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte

11 years, 5 months

[PATCH] alloc_algorithm_b: Remove obsolete 'i' incrementation from for-loop

by Andreas Eversberg

--- src/gprs_rlcmac_ts_alloc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp index 58dd2e9..366732c 100644 --- a/src/gprs_rlcmac_ts_alloc.cpp +++ b/src/gprs_rlcmac_ts_alloc.cpp @@ -459,7 +459,7 @@ inc_window: "1 slot assigned\n"); break; } - if (++i == ms_max_txslots) { + if (i+1 == ms_max_txslots) { LOGP(DRLCMAC, LOGL_DEBUG, "- Done, because " "slots / window reached maximum " "allowed Tx size\n"); -- 1.8.1.5 --------------010607040705070003040009--

11 years, 5 months

← Newer
1
...
39
40
41
42
43
44
45
...
48
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

osmocom-net-gprs