Attention is currently required from: neels.
Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email )
Change subject: pfcp_tool: add 'date'
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-pfcp-tool/pfcp_tool_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17587):
https://gerrit.osmocom.org/c/osmo-upf/+/37761/comment/69a69e07_ce456227?usp… :
PS2, Line 147: vty_out(vty,"%04d-%02d-%02d,%02d:%02d:%02d.%03d%s",
space required after that ',' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I0486cc92ea298bb9926a0e5c26da17ba5970a72c
Gerrit-Change-Number: 37761
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 06:21:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37642?usp=email )
Change subject: filesystem: add export method for ADF files
......................................................................
Patch Set 2:
(1 comment)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/37642/comment/2590ecb7_7b50d3f2?usp=em… :
PS2, Line 538:
this assumes that every application will have an 'export' method. I believe this is not the case (particularly not with this patch alone)?
There's two ways I can see:
* have an Application base class export method that does nothing, and then override that method in the ARA-M application to acutally do something, selectively
* do a hasattr() here to check if the application has an export method, and only call it in that case.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886
Gerrit-Change-Number: 37642
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 14:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37741?usp=email )
Change subject: pySim.esim.saip.templates: Add expand_default_value() method
......................................................................
Patch Set 2:
(1 comment)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/37741/comment/339c816c_6ee68ec5?usp=em… :
PS2, Line 55: or 100
> just too be sure: is this intentional and coming from some spec. […]
no, it is just a random value. The return value of the below call is not actually used anywhere. All we want to do here is to verify that *if* we later need to actually compute the default value, it will work. So we're just verifying that the pattern from the template can be processed as the comment states below.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37741?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id3eb16910c0bdfa572294e14ca1cd44ca95ca69f
Gerrit-Change-Number: 37741
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 15:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>