- gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: ttcn3-epdg-test: remove latest code path
by osmith 10 Aug '24

10 Aug '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37781?usp=email ) Change subject: ttcn3-epdg-test: remove latest code path ...................................................................... ttcn3-epdg-test: remove latest code path Use the same config in latest as in master, as a new version 0.1.0 has been released recently. This fixes the two currently failing tests on latest. The ttcn3-epdg-test has not been replaced by testenv (OS#6494) yet, so let's fix it here. Change-Id: I522824a6df3c58d26788c8d9e978759e7ec8a462 --- M ttcn3-epdg-test/epdg.sh D ttcn3-epdg-test/osmo-epdg.latest.config 2 files changed, 1 insertion(+), 92 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/37781/1 diff --git a/ttcn3-epdg-test/epdg.sh b/ttcn3-epdg-test/epdg.sh index b8cb7b7..2614bf9 100755 --- a/ttcn3-epdg-test/epdg.sh +++ b/ttcn3-epdg-test/epdg.sh @@ -11,11 +11,7 @@ ip addr add $UE_ADDR dev $UE_IFACE ip link set $UE_IFACE up ip rule add from $UE_SUBNET table 45 -if [ "$IMAGE_SUFFIX" = "latest" ]; then - ERL_FLAGS='-config /data/osmo-epdg.latest.config' /usr/bin/osmo-epdg & -else - ERL_FLAGS='-config /data/osmo-epdg.config' /tmp/osmo-epdg/_build/default/bin/osmo-epdg & -fi +ERL_FLAGS='-config /data/osmo-epdg.config' /tmp/osmo-epdg/_build/default/bin/osmo-epdg & MYPID=$! # We cannot set a route for the interface until it is created by osmo-epdg... diff --git a/ttcn3-epdg-test/osmo-epdg.latest.config b/ttcn3-epdg-test/osmo-epdg.latest.config deleted file mode 100644 index ab176c8..0000000 --- a/ttcn3-epdg-test/osmo-epdg.latest.config +++ /dev/null @@ -1,87 +0,0 @@ -[ - %% =========================================== - %% Application config - %% =========================================== - {osmo_epdg, - [% GSUP Server connection parameters - {gsup_local_ip, "172.18.10.20"}, - {gsup_local_port, 4222}, - % Diameter Connection parameters - {dia_swx_remote_ip, "172.18.10.103"}, - {dia_swx_remote_port, 3868}, - {dia_swx_proto, sctp}, - {dia_swx_connect_timer, 200}, - {dia_swx_watchdog_timer, 6000}, - {dia_swx_watchdog_config, - [{okay, 1}, - {suspect, 1}]}, - {dia_swx_vendor_id, 0}, - {dia_swx_origin_host, "epdg.localdomain"}, - {dia_swx_origin_realm, "localdomain"}, - {dia_swx_context_id, "epdg@localdomain"}, - % Diameter s6b Connection parameters - {dia_s6b_local_ip, "172.18.10.20"}, - {dia_s6b_local_port, 3869}, - {dia_s6b_proto, sctp}, - {dia_s6b_connect_timer, 200}, - {dia_s6b_watchdog_timer, 6000}, - {dia_s6b_watchdog_config, - [{okay, 1}, - {suspect, 1}]}, - {dia_s6b_vendor_id, 0}, - {dia_s6b_origin_host, "aaa.localdomain"}, - {dia_s6b_origin_realm, "localdomain"}, - {dia_s6b_context_id, "aaa@localdomain"}, - % GTPv2C Connection parameters - {gtpc_local_ip, "172.18.10.20"}, - {gtpc_local_port, 2123}, - {gtpc_remote_ip, "172.18.10.103"}, - {gtpc_remote_port, 2123} - ] - }, - %% =========================================== - %% gtp_u_kmod config - %% =========================================== - {gtp_u_kmod, [ - {sockets, [{gtp0, [%% ip: IP Address assigned at the tunnel: - {ip, {172,18,10,20}}, - %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): - freebind, - % Create gtp tundev with role SGSN: - {role, sgsn} - ] - }] - } - ]}, - %% =========================================== - %% gen_socket config - %% =========================================== - {gen_socket, [ - {libdir, "/usr/lib"} -]}, - %% =========================================== - %% Lager logging config - %% =========================================== - {lager, [ - {log_root, "/data/"}, - {colored, true}, - {handlers, - [{lager_console_backend, [{level, debug}]}, - {lager_file_backend, - [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, - {lager_file_backend, - [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, - {crash_log, "crash.log"}, - {crash_log_msg_size, 65536}, - {crash_log_size, 104857600}, - {crash_log_date, "$D0"}, - {crash_log_count, 10}, - {error_logger_redirect, true} - ]}, - {kernel, [ - {logger, [{handler, debug, logger_std_h, % {handler, HandlerId, Module, - #{config => #{file => "/data/erlang.log"}} - }] - } - ]} -]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I522824a6df3c58d26788c8d9e978759e7ec8a462 Gerrit-Change-Number: 37781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman.is_running() -> testenv.args.podman
by osmith 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email to look at the new patch set (#3). Change subject: testenv: podman.is_running() -> testenv.args.podman ...................................................................... testenv: podman.is_running() -> testenv.args.podman Use testenv.args.podman instead of testenv.podman.is_running() in all places except for testenv.podman.stop(). - testenv.args.podman is always True when --podman is used. - testenv.podman.is_running() is only True while the container is currently running. Most of the time the behavior is the same. But without this patch, when the container crashes, commands would unexpectedly run outside of the container (and then fail on jenkins due to missing programs). Related: OS#6494 Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23 --- M _testenv/testenv/cmd.py M _testenv/testenv/daemons.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/37765/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23 Gerrit-Change-Number: 37765 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: erab_fsm: E-RAB FSM implementation
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email ) Change subject: erab_fsm: E-RAB FSM implementation ...................................................................... Patch Set 10: (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317/comment/2e0b3451_3e32… : PS9, Line 169: ?LOG_ERROR("PFCP session establisment timeout"), > spelling Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic57e14675339b7cadb0cdd7cbc5d3a56288d7297 Gerrit-Change-Number: 37317 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 19:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: filesystem: add placeholder export method in CardFile base class
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37775?usp=email ) Change subject: filesystem: add placeholder export method in CardFile base class ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d Gerrit-Change-Number: 37775 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:11:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: add debian package files
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, lynxis lazus. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email ) Change subject: add debian package files ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c Gerrit-Change-Number: 37730 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:15:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: Makefile: add 'install' target
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: add 'install' target ...................................................................... Makefile: add 'install' target Related: SYS#7040 Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 --- M Makefile 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/28/37728/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 Gerrit-Change-Number: 37728 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo_dia2gsup[master]: examples: add dev.config, let 'make run' use it by default
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37721?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: examples: add dev.config, let 'make run' use it by default ...................................................................... examples: add dev.config, let 'make run' use it by default This is basically the same config, but intended to be used during development when running osmo-dia2gsup using 'make run'. The key difference is having time and module/function/line info. Related: OS#6450 Change-Id: I4928051be173b8e5d0977d8039dbe5bc3ed9c1ab --- M Makefile A examples/dev.config 2 files changed, 31 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/21/37721/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4928051be173b8e5d0977d8039dbe5bc3ed9c1ab Gerrit-Change-Number: 37721 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman.is_running() -> testenv.args.podman
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email ) Change subject: testenv: podman.is_running() -> testenv.args.podman ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23 Gerrit-Change-Number: 37765 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:30:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/podman: use explicit no_podman=True
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37766?usp=email ) Change subject: testenv/podman: use explicit no_podman=True ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I41afe6d6b565a8e8c384229ee44f1b75f25c0a4b Gerrit-Change-Number: 37766 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-mgw[master]: mgcp_network: use an uint16_t to store the port number
by dexter 10 Aug '24

10 Aug '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37776?usp=email ) Change subject: mgcp_network: use an uint16_t to store the port number ...................................................................... mgcp_network: use an uint16_t to store the port number The comment in struct mgcp_rtp_end says that the RTCP port number has to be stored in network byte order. Such a port number is 16 bit long, so let's use an uint16_t instead of an int here. Related: OS#6527 Change-Id: I392b07b243389a78d4ad1d784cdfdc28ec59b487 --- M include/osmocom/mgcp/mgcp_network.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp_network.h b/include/osmocom/mgcp/mgcp_network.h index 8f6505c..453fbe9 100644 --- a/include/osmocom/mgcp/mgcp_network.h +++ b/include/osmocom/mgcp/mgcp_network.h @@ -94,7 +94,7 @@ struct osmo_sockaddr addr; /* in network byte order */ - int rtcp_port; + uint16_t rtcp_port; /* currently selected audio codec */ struct mgcp_rtp_codec *codec; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I392b07b243389a78d4ad1d784cdfdc28ec59b487 Gerrit-Change-Number: 37776 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log