Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email )
Change subject: pySim-shell: enable export of DF and ADF files
......................................................................
Patch Set 2:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37641/comment/e9de4b7e_856dc5bd?usp=em… :
PS2, Line 602:
> what is the rationale of making it conditional? Shouldn't we simply always try to export as much as […]
I made it conditionally because I the information from the ADF (ADF.ARA-M in this case) are technically not file contents. I thought that those added commands might cause trouble for some use-cases. In any case, If you think we do not need the --include-df option, then I am happy to remove it.
I also think that we should cover the applications that do not have an ADF as well. I will look into the code now and see what we can do there.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5
Gerrit-Change-Number: 37641
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2024 07:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: fixeria, osmith.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email )
Change subject: subscriber-create-on-demand: rework configuration
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
a
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/37779/comment/4933ab0f_d310fea3?usp… :
PS1, Line 300: vty_out(vty, " no subscriber-create-on-demand%s", VTY_NEWLINE);
> Well, I believe printing a setting explicitly is better than omitting values. […]
the point IMHO is less what each of us feel at this point, but more "what is consistent with the existing way how we do things in the vty"
--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9
Gerrit-Change-Number: 37779
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2024 14:07:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>