- gerrit-log - lists.osmocom.org

[XS] Change in osmo-upf[master]: vty doc fix
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email ) Change subject: vty doc fix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie1ba8c0a1fb6613b7f21d6889e3c6978288a51e4 Gerrit-Change-Number: 37754 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 13:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config
by osmith 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-shell: fix typo
by dexter 10 Aug '24

10 Aug '24

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37772?usp=email ) Change subject: pySim-shell: fix typo ...................................................................... pySim-shell: fix typo Change-Id: I1bd995ae9eb59a44a48da62a7b0262faa84a4f2b --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/37772/1 diff --git a/pySim-shell.py b/pySim-shell.py index 6e59e58..36cb839 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -373,7 +373,7 @@ first = True while 1: # TODO: Count consecutive failures, if more than N consecutive failures occur, then stop. - # The ratinale is: There may be a problem with the device, we do want to prevent that + # The rationale is: There may be a problem with the device, we do want to prevent that # all remaining cards are fired to the error bin. This is only relevant for situations # with large stacks, probably we do not need this feature right now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1bd995ae9eb59a44a48da62a7b0262faa84a4f2b Gerrit-Change-Number: 37772 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: filesystem: add placeholder export method in CardFile base class
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: filesystem: add placeholder export method in CardFile base class ...................................................................... filesystem: add placeholder export method in CardFile base class We add export methods in subclasses of CardFile but the base class itself lacks an export method. To make the code more readable and to avoid unnecessary exceptions, les's add a default export method that just returns a comment. Related: OS#6092 Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d --- M pySim/filesystem.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/37775/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d Gerrit-Change-Number: 37775 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in ...osmo_dia2gsup[master]: examples/sys.config: add pid, delete time
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: examples/sys.config: add pid, delete time ...................................................................... examples/sys.config: add pid, delete time pid is useful for understanding which process logs messages. time is not needed, since systemd-journald adds timestamps for us. Related: OS#6450 Change-Id: I1dd98bae69c6d644870d44f8217262669fc20c6d --- M examples/sys.config 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/20/37720/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1dd98bae69c6d644870d44f8217262669fc20c6d Gerrit-Change-Number: 37720 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: filesystem: add export method for ADF files
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: filesystem: add export method for ADF files ...................................................................... filesystem: add export method for ADF files This patch adds an export method to CardADF, which calls the application specific export method in CardApplication class Related: OS#6092 Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 --- M pySim/filesystem.py 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37642/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add 'install' target, clean up debian/rules
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: add 'install' target, clean up debian/rules ...................................................................... Makefile: add 'install' target, clean up debian/rules Debian's dh_* scripts execute make commands by default, so we no longer need to override dh_* targets in debian/rules. Related: OS#6148 Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 --- M Makefile D debian/osmo-diameter2gsup.install M debian/rules 3 files changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/37727/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-upf[master]: pfcp-tool: fix extra newline in vty_out
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email ) Change subject: pfcp-tool: fix extra newline in vty_out ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01 Gerrit-Change-Number: 37755 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: Makefile: add 'install' target
by fixeria 10 Aug '24

10 Aug '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email ) Change subject: Makefile: add 'install' target ...................................................................... Makefile: add 'install' target Related: SYS#7040 Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 --- M Makefile 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/Makefile b/Makefile index fdf454f..52390d1 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,10 @@ +# config file used by 'run' and 'shell' CONFIG ?= config/sys.config +# arguments passed to eunit, used by 'check' EUNIT_ARGS ?= +# directory paths for 'install' +BINDIR ?= /usr/bin +CONFDIR ?= /etc/osmocom all: build @@ -24,6 +29,12 @@ analyze: $(GEN_FILES) rebar3 dialyzer +install: build + install -Dm0755 _build/default/bin/osmo-s1gw \ + $(DESTDIR)$(BINDIR)/osmo-s1gw + install -Dm0644 config/sys.config \ + $(DESTDIR)$(CONFDIR)/osmo-s1gw.config + clean: # Avoid running rebar3 clean if _build doesn't exist, since it would try # to fetch deps from the Internet and that may not be avaialble when in -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 Gerrit-Change-Number: 37728 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: remove Ubuntu:23.10
by osmith 10 Aug '24

10 Aug '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37771?usp=email ) Change subject: jobs/osmocom-obs-sync: remove Ubuntu:23.10 ...................................................................... jobs/osmocom-obs-sync: remove Ubuntu:23.10 This release is EOL, remove it. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Linux_Distributio… Change-Id: I2a145e2459cc1052e7a532f7e252907f5f6e7835 --- M jobs/osmocom-obs-sync.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/37771/1 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 3776688..7f13e02 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -36,7 +36,6 @@ Raspbian:11 Raspbian:12 Ubuntu:22.04 - Ubuntu:23.10 Ubuntu:24.04 " ./scripts/obs/sync_obs_projects.py \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37771?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2a145e2459cc1052e7a532f7e252907f5f6e7835 Gerrit-Change-Number: 37771 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log