Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email )
Change subject: build: do not link against libosmo-abis
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37793?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I11168a7b25942d6c70566441fb0a1d26c3ae5c43
Gerrit-Change-Number: 37793
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Aug 2024 14:35:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email )
Change subject: erab_fsm: include Network Instance IE in PDRs and FARs
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
i would consider this WIP until the values are configurable.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37795?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4dbe8e0b1d14eed5fdb3f9f3f2543c44fd543d22
Gerrit-Change-Number: 37795
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Aug 2024 14:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email )
Change subject: SGSN: add paging a whole routing area with multiple cells
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5
Gerrit-Change-Number: 37796
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 11 Aug 2024 14:34:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email )
Change subject: SGSN: add paging a whole routing area with multiple cells
......................................................................
SGSN: add paging a whole routing area with multiple cells
1. Attach + PDP Request
2. Wait for UE to be in Standby
3. Transmit to GTP Userdata
4. See the Paging on 2 BVCIs within the Routing Area
Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 51 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/37796/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index fe4b086..ecdd778 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2603,6 +2603,56 @@
f_cleanup();
}
+/*
+ * Wait for T3314 expiration and check that PS PAGING is created on DL PDU
+ * Use a Routing Area with 2 cells and expect paging on both cells.
+ *
+ * MS <-> SGSN: Attach Procedure
+ * MS <-> SGSN: PDP Context Request/Response
+ * MS SGSN: Timeout of T3314, MS location known only on Routing Area precision
+ * GGSN -> SGSN: User Data
+ * MS <-- SGSN: Paging PS all BVCI within the Routing Area
+ */
+private function f_TC_paging_ps_ra_multiple_cells(charstring id) runs on BSSGP_ConnHdlr {
+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));
+ var default d;
+
+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[0]);
+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);
+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[2]);
+
+ /* first perform regular attach */
+ f_gmm_attach(false, false, ran_index := 1);
+ /* then activate PDP context */
+ f_pdp_ctx_act(apars, ran_index := 1);
+
+ /* do a RAU to second BVCI */
+ /* then transceive a downlink PDU */
+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 1);
+
+ /* now wait for T3314 expiration (test_CT below has reduced it to 3s) */
+ f_sleep(5.0);
+
+ /* now data should be flowing again, but with PS PAGING */
+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 1);
+ BSSGP_SIG[1].receive(tr_BSSGP_PS_PAGING(?));
+ BSSGP_SIG[2].receive(tr_BSSGP_PS_PAGING(?));
+
+ /* FIXME: simulate paging response */
+ /* FIXME: verify PDU actually arrives only after paging response was successful */
+}
+
+testcase TC_paging_ps_ra_multiple_cells() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ f_init();
+ f_vty_config(SGSNVTY, "sgsn", "timer 3314 3");
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_paging_ps_ra_multiple_cells), testcasename(), g_gb, 52);
+ vc_conn.done;
+ f_vty_config(SGSNVTY, "sgsn", "timer 3314 default");
+ f_cleanup();
+}
+
/* Run a RIM single report procedure over the sgsn. Since the SGSN will only do a transparent routing of the
* RIM messages this basically tests if the message is correctly transfered from one GB interface to the
* other and vice versa. */
@@ -3168,6 +3218,7 @@
execute( TC_suspend_resume() );
execute( TC_suspend_rau() );
execute( TC_paging_ps() );
+ execute( TC_paging_ps_ra_multiple_cells() );
execute( TC_bssgp_rim_single_report() );
execute( TC_rim_eutran_to_geran() );
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37796?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I88dc95669d57278a96e05ec84f934ebf70b319e5
Gerrit-Change-Number: 37796
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37738?usp=email )
Change subject: pySim.esim.saip.templates: Add SaipSpecVersion
......................................................................
pySim.esim.saip.templates: Add SaipSpecVersion
The SAIP specification version implicitly determines which filesystem
templates (or versions thereof) are supported. So if a given eUICC
states it implements SAIP version 2.3.0, then we have to translate
this into which template versions that means. The new SaipSpecVersion
and its derived classes do exactly that.
Change-Id: I3a894c72c22e42bd2067e067be80a67197ad1bf2
---
M pySim/esim/saip/templates.py
1 file changed, 83 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py
index a35779d..79afc91 100644
--- a/pySim/esim/saip/templates.py
+++ b/pySim/esim/saip/templates.py
@@ -17,6 +17,7 @@
from typing import *
from copy import deepcopy
+from pySim.utils import all_subclasses
from pySim.filesystem import Path
import pySim.esim.saip.oid as OID
@@ -807,3 +808,85 @@
13: ['800113A406830101950108', '800148A40683010A950108'],
14: ['80015EA40683010A950108'],
}
+
+class SaipSpecVersionMeta(type):
+ def __getitem__(self, ver: str):
+ """Syntactic sugar so that SaipSpecVersion['2.3.0'] will work."""
+ return SaipSpecVersion.for_version(ver)
+
+class SaipSpecVersion(object, metaclass=SaipSpecVersionMeta):
+ """Represents a specific version of the SIMalliance / TCA eUICC Profile Package:
+ Interoperable Format Technical Specification."""
+ version = None
+ oids = []
+
+ @classmethod
+ def suports_template_OID(cls, OID: OID.OID) -> bool:
+ """Return if a given spec version supports a template of given OID."""
+ return OID in cls.oids
+
+ @classmethod
+ def version_match(cls, ver: str) -> bool:
+ """Check if the given version-string matches the classes version. trailing zeroes are ignored,
+ so that for example 2.2.0 will be considered equal to 2.2"""
+ def strip_trailing_zeroes(l: List):
+ while l[-1] == '0':
+ l.pop()
+ cls_ver_l = cls.version.split('.')
+ strip_trailing_zeroes(cls_ver_l)
+ ver_l = ver.split('.')
+ strip_trailing_zeroes(ver_l)
+ return cls_ver_l == ver_l
+
+ @staticmethod
+ def for_version(req_version: str) -> Optional['SaipSpecVersion']:
+ """Return the subclass for the requested version number string."""
+ for cls in all_subclasses(SaipSpecVersion):
+ if cls.version_match(req_version):
+ return cls
+
+
+class SaipSpecVersion101(SaipSpecVersion):
+ version = '1.0.1'
+ oids = [OID.MF, OID.DF_CD, OID.DF_TELECOM, OID.ADF_USIM_by_default, OID.ADF_USIMopt_not_by_default,
+ OID.DF_PHONEBOOK_ADF_USIM, OID.DF_GSM_ACCESS_ADF_USIM, OID.ADF_ISIM_by_default,
+ OID.ADF_ISIMopt_not_by_default, OID.ADF_CSIM_by_default, OID.ADF_CSIMopt_not_by_default]
+
+class SaipSpecVersion20(SaipSpecVersion):
+ version = '2.0'
+ # no changes in filesystem teplates to previous 1.0.1
+ oids = SaipSpecVersion101.oids
+
+class SaipSpecVersion21(SaipSpecVersion):
+ version = '2.1'
+ # no changes in filesystem teplates to previous 2.0
+ oids = SaipSpecVersion20.oids
+
+class SaipSpecVersion22(SaipSpecVersion):
+ version = '2.2'
+ oids = SaipSpecVersion21.oids + [OID.DF_EAP]
+
+class SaipSpecVersion23(SaipSpecVersion):
+ version = '2.3'
+ oids = SaipSpecVersion22.oids + [OID.DF_5GS, OID.DF_SAIP]
+
+class SaipSpecVersion231(SaipSpecVersion):
+ version = '2.3.1'
+ # no changes in filesystem teplates to previous 2.3
+ oids = SaipSpecVersion23.oids
+
+class SaipSpecVersion31(SaipSpecVersion):
+ version = '3.1'
+ oids = [OID.MF, OID.DF_CD, OID.DF_TELECOM_v2, OID.ADF_USIM_by_default_v2, OID.ADF_USIMopt_not_by_default_v2,
+ OID.DF_PHONEBOOK_ADF_USIM, OID.DF_GSM_ACCESS_ADF_USIM, OID.DF_5GS_v2, OID.DF_5GS_v3, OID.DF_SAIP,
+ OID.ADF_ISIM_by_default, OID.ADF_ISIMopt_not_by_default_v2, OID.ADF_CSIM_by_default_v2,
+ OID.ADF_CSIMopt_not_by_default_v2, OID.DF_EAP]
+
+class SaipSpecVersion32(SaipSpecVersion):
+ version = '3.2'
+ # no changes in filesystem teplates to previous 3.1
+ oids = SaipSpecVersion31.oids
+
+class SaipSpecVersion331(SaipSpecVersion):
+ version = '3.3.1'
+ oids = SaipSpecVersion32.oids + [OID.ADF_USIMopt_not_by_default_v3, OID.DF_5GS_v4, OID.DF_SAIP, OID.DF_SNPN, OID.DF_5GProSe, OID.IoT_by_default, OID.IoTopt_not_by_default]
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37738?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3a894c72c22e42bd2067e067be80a67197ad1bf2
Gerrit-Change-Number: 37738
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email )
Change subject: add debian package files
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> The build passes when adding the same `contrib/generate_build_dep.sh` (with executable flag): […]
Thanks a lot, Oliver! I added this file with the contents you suggested above.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c
Gerrit-Change-Number: 37730
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Aug 2024 11:41:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>