- gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup.service: use /etc/osmocom/osmo-dia2gsup.config
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37718?usp=email ) Change subject: osmo_dia2gsup.service: use /etc/osmocom/osmo-dia2gsup.config ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5ff07341597b2838bce0750a576e463addd2964f Gerrit-Change-Number: 37718 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: [TEST] contrib/generate_build_dep.sh: manually install meck
by fixeria 10 Aug '24

10 Aug '24

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: [TEST] contrib/generate_build_dep.sh: manually install meck ...................................................................... [TEST] contrib/generate_build_dep.sh: manually install meck Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378 --- M contrib/generate_build_dep.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/87/37787/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378 Gerrit-Change-Number: 37787 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in ...osmo_dia2gsup[master]: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config
by fixeria 10 Aug '24

10 Aug '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config Related: OS#6148 Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile index f08f388..919bdd4 100644 --- a/Makefile +++ b/Makefile @@ -2,6 +2,7 @@ CONFIG ?= examples/sys.config # directory paths for 'install' BINDIR ?= /usr/bin +CONFDIR ?= /etc/osmocom SYSTEMDUNITDIR ?= /lib/systemd/system/ all: build @@ -25,6 +26,8 @@ install: build install -Dm0755 _build/default/bin/osmo-dia2gsup \ $(DESTDIR)$(BINDIR)/osmo-dia2gsup + install -Dm0644 examples/sys.config \ + $(DESTDIR)$(CONFDIR)/osmo-dia2gsup.config install -Dm0644 contrib/systemd/osmo_dia2gsup.service \ $(DESTDIR)$(SYSTEMDUNITDIR)/osmo_dia2gsup.service -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in pysim[master]: filesystem: add export method for ADF files
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37642?usp=email ) Change subject: filesystem: add export method for ADF files ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:12:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: add debian package files
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by osmith, Verified+1 by Jenkins Builder Change subject: add debian package files ...................................................................... add debian package files Related: SYS#7040 Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c --- A contrib/generate_build_dep.sh A debian/changelog A debian/compat A debian/control A debian/postinst A debian/rules A debian/source/format 7 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/30/37730/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5446c70c1c1f232a2a45de60be7068cfd683a99c Gerrit-Change-Number: 37730 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: pySim-shell: enable export of DF and ADF files
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email ) Change subject: pySim-shell: enable export of DF and ADF files ...................................................................... Patch Set 2: (2 comments) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37641/comment/7b0ae629_92742cca?usp=em… : PS1, Line 500: When walking through the file system tree the action must not : # always restore the currently selected file > I think the code is doing the opposite of what the comment states? IF the action *must not restore* […] Thanks. The "not" is of course wrong. https://gerrit.osmocom.org/c/pysim/+/37641/comment/b1d58645_73d2b54f?usp=em… : PS1, Line 651: include_df > let's stick to using dash in command line arguments […] We are using this style in many places. Maybe we should go through and fix it everywhere? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5 Gerrit-Change-Number: 37641 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 13:27:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in pysim[master]: ara_m: add export support for the ARA-M application
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37643?usp=email ) Change subject: ara_m: add export support for the ARA-M application ...................................................................... Patch Set 2: (1 comment) File pySim/ara_m.py: https://gerrit.osmocom.org/c/pysim/+/37643/comment/ef433b0e_69f514aa?usp=em… : PS2, Line 425: if 'ref_ar_do' in ref_ar_do_list: : for ref_ar_do in ref_ar_do_list['ref_ar_do']: : if 'ref_do' in ref_ar_do: : ref_do_list = ref_ar_do['ref_do'] : if 'ar_do' in ref_ar_do: : ar_do_list = ref_ar_do['ar_do'] : : if ref_do_list and ar_do_list: : aid_ref_do = None : dev_app_id_ref_do = None : apdu_ar_do = None : nfc_ar_do = None : perm_ar_do = None : pkg_ref_do = None : for ref_do in ref_do_list: : if 'aid_ref_do' in ref_do: : aid_ref_do = ref_do['aid_ref_do'] : if 'dev_app_id_ref_do' in ref_do: : dev_app_id_ref_do = ref_do['dev_app_id_ref_do'] : if 'pkg_ref_do' in ref_do: : pkg_ref_do = ref_do['pkg_ref_do'] : for ar_do in ar_do_list: : if 'apdu_ar_do' in ar_do: : apdu_ar_do = ar_do['apdu_ar_do'] : if 'nfc_ar_do' in ar_do: : nfc_ar_do = ar_do['nfc_ar_do'] : if 'perm_ar_do' in ar_do: : perm_ar_do = ar_do['perm_ar_do'] why do we need all those maipulations? it's a lot of hand-written code which I'd rather avoid (also, all of it in the same style). I'd hope there is a better way... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I811cb9d25cb8ee194b4ead5fb2cabf1fdc0c1c43 Gerrit-Change-Number: 37643 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 14:34:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in docker-playground[master]: common/Release.key: update
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/37783?usp=email ) Change subject: common/Release.key: update ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I think this deserves also a news item on osmocom.org. Not on the day the old one expires, but right now so people are warned ahead of the expiration. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7446565ff3bbbcd30e53234786d84109583284a5 Gerrit-Change-Number: 37783 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: ara_m: fix --apdu-filter setting
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37640?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ara_m: fix --apdu-filter setting ...................................................................... ara_m: fix --apdu-filter setting The code for the --apdu-filter commandline option is not yet finished. Let's finish it and make it work. Related: OS#6092 Change-Id: Ib5fb388972fde0d50c3db0082ebf40bcca404681 --- M pySim/ara_m.py 1 file changed, 15 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/37640/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib5fb388972fde0d50c3db0082ebf40bcca404681 Gerrit-Change-Number: 37640 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: osmo-s1gw: build debian pkgs, publish source tarballs
by osmith 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/37773?usp=email ) Change subject: osmo-s1gw: build debian pkgs, publish source tarballs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia51a4815feb99fa3bf067090fec6f2ccd20ffdae Gerrit-Change-Number: 37773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2024 08:50:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log