Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37642?usp=email )
Change subject: filesystem: add export method for ADF files ......................................................................
Patch Set 2:
(1 comment)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/37642/comment/2590ecb7_7b50d3f2?usp=ema... : PS2, Line 538: this assumes that every application will have an 'export' method. I believe this is not the case (particularly not with this patch alone)?
There's two ways I can see: * have an Application base class export method that does nothing, and then override that method in the ARA-M application to acutally do something, selectively * do a hasattr() here to check if the application has an export method, and only call it in that case.