Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email )
Change subject: osmo-bts-trx: check sscanf() result in NOMTXPOWER/SETPOWER handlers
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3dc399cfae70c450d53d66bb99f3832f160fca39
Gerrit-Change-Number: 42511
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Mar 2026 21:56:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email )
Change subject: osmo-bts-trx: check sscanf() result in NOMTXPOWER/SETPOWER handlers
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bts-trx/trx_if.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bts/+/42511/comment/15c3eeea_8b3d8ec3?usp… :
PS1, Line 584: if (sscanf(rsp->params, "%d", &nominal_power) != 1) {
Prefer kstrto<type> to single variable sscanf
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bts/+/42511/comment/ca9f2c3d_a36d8213?usp… :
PS1, Line 603: if (sscanf(rsp->params, "%d", &power_att) != 1) {
Prefer kstrto<type> to single variable sscanf
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3dc399cfae70c450d53d66bb99f3832f160fca39
Gerrit-Change-Number: 42511
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 26 Mar 2026 21:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No