Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email )
Change subject: eIM_Tests: align RSP version number in HTTP header
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 09:54:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, laforge, neels.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42353?usp=email )
Change subject: docs/put_key: add tutorial that explains how to manage global platform keys
......................................................................
Patch Set 5:
(7 comments)
File docs/put_key-tutorial.rst:
https://gerrit.osmocom.org/c/pysim/+/42353/comment/dbe5c561_5c018433?usp=em… :
PS4, Line 16: It
> It's
Done
https://gerrit.osmocom.org/c/pysim/+/42353/comment/74677cb0_77145249?usp=em… :
PS4, Line 39: exists
> [two domains] exist
Done
https://gerrit.osmocom.org/c/pysim/+/42353/comment/cc93f9e0_2dd45d47?usp=em… :
PS4, Line 46: there will
> there will be
Done
https://gerrit.osmocom.org/c/pysim/+/42353/comment/8a1feaec_2ea7f731?usp=em… :
PS4, Line 67: we simply have `pySim-shell`
: into making the GlobalPlatform related commands available
> something is not right here, do you mean "we simply force pySim-shell"?
Done
https://gerrit.osmocom.org/c/pysim/+/42353/comment/f546f385_0f72d328?usp=em… :
PS4, Line 91: Along with the card we have received the following keyset:
> Maybe add an extra warning/clarification here that each card has its own unique keyset, and the give […]
I thought this would be obvious, but who knows. Maybe there are people out there who mistakenly think that those keys are "default keys" that always work. This might become a trap indeed. Also for GlobalPlatform default keys indeed exist, so people might be used to this.
https://gerrit.osmocom.org/c/pysim/+/42353/comment/2a777de2_26e55692?usp=em… :
PS4, Line 108: establish_scp02
> Don't we need to specify `--key-ver 122` here?
The funny thing here is that this command-line indeed works without the --key-ver argument. The reason for this is that the default of --key-ver is 0, which tells the ISD to use the first available keyset and this is by coincidence the one with KVN 122. However, we do not want to rely on coincidences here.
https://gerrit.osmocom.org/c/pysim/+/42353/comment/c01f5864_4c5ccafe?usp=em… :
PS4, Line 440: That different schemes are possible shows the second example
> Looks like the halves of this sentence are swapped. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e
Gerrit-Change-Number: 42353
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 09:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, neels.
Hello Jenkins Builder, daniel, laforge, neels,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42353?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: docs/put_key: add tutorial that explains how to manage global platform keys
......................................................................
docs/put_key: add tutorial that explains how to manage global platform keys
With the increased interest in using GlobalPlatform features of
UICC and eUICCs (OTA-SMS, applets, etc.), also comes an increased
interest in how the related GlobalPlatform keys can be managed
(key rotation, adding/removing keysets from/to a Security Domain).
Unfortunately, many aspects of this topic are not immediately
obvious for the average user. Let's add a tutorial that contains
some practical examples to shine some light on the topic.
Related: SYS#7881
Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e
---
A docs/put_key-tutorial.rst
M docs/shell.rst
2 files changed, 837 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/42353/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e
Gerrit-Change-Number: 42353
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email )
Change subject: enb_{proxy,registry}: signal MME conn info on SCTP comm_up
......................................................................
Patch Set 2:
(1 comment)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445/comment/55899490_4925… :
PS2, Line 260: enb_registry:notify_mme_comm_up(S#state.enb_handle, conn_info(NewS)),
> I'd say it makes more sense to register the mme *before* generating external events (send msg) which […]
MMEs are already registered at this point - the `mme_registry` takes care of that. Here we're signalling **connection** information to a selected MME, i.e. SCTP assoc ID, local address and port (plus some extra info that is separated from `mme_conn_info()` in a follow-up patch).
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea9ba4fdf961e6cd262edc154884a2eee3d95355
Gerrit-Change-Number: 42445
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 09:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42448?usp=email )
Change subject: s1ap_proxy: add public erab_list() type
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42448?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I21a674537d1d9f16fdb319aaf2d758ba0906b407
Gerrit-Change-Number: 42448
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 08:53:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42446?usp=email )
Change subject: enb_proxy: split conn_info() into mme_conn_info() and proxy_info()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42446?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia428ceb4762f972211e9b790688dc89fb5b8a274
Gerrit-Change-Number: 42446
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 08:48:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email )
Change subject: enb_{proxy,registry}: signal MME conn info on SCTP comm_up
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445/comment/817183af_d0ef… :
PS2, Line 260: enb_registry:notify_mme_comm_up(S#state.enb_handle, conn_info(NewS)),
I'd say it makes more sense to register the mme *before* generating external events (send msg) which may want to interact with the information.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea9ba4fdf961e6cd262edc154884a2eee3d95355
Gerrit-Change-Number: 42445
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Mar 2026 08:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes