Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: firmware: add tear-free 64bit load/store helpers for jiffies
......................................................................
firmware: add tear-free 64bit load/store helpers for jiffies
On Cortex-M4 a 64bit load may compile to two separate LDR
instructions which can lead to torn reads due to interrupts.
LDRD/STRD are restartable, they either complete or restart from
scratch, so the result is always consistent. The only "downside" is the
required alignment, which is fine.
Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625
---
M sysmoOCTSIM/libosmo_emb.c
A sysmoOCTSIM/libosmo_emb.h
2 files changed, 63 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/04/42504/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625
Gerrit-Change-Number: 42504
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: firmware: add tear-free 64bit load/store helpers for jiffies
......................................................................
firmware: add tear-free 64bit load/store helpers for jiffies
On Cortex-M4 a 64bit load may compile to two separate LDR
instructions which can lead to torn reads due to interrupts.
LDRD/STRD are restartable, they either complete or restart from
scratch, so the result is always consistent. The only "downside" is the
required alignment, which is fine.
Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625
---
M sysmoOCTSIM/libosmo_emb.c
A sysmoOCTSIM/libosmo_emb.h
2 files changed, 59 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/04/42504/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625
Gerrit-Change-Number: 42504
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen, jolly, laforge.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by jolly, Verified+1 by Jenkins Builder
Change subject: firmware: replace libosmocore fsm timers
......................................................................
firmware: replace libosmocore fsm timers
Concurrent access from main loop and the different uart irqs was not
going well and caused crashes. The libosmocore fsm does still allocate
one internal timer, but it is not used by the firmware, so libosmocore
will not touch the rbtree.
Additionally ignore checkpatch jiffies complaints because we're trying
to do firmware here.
Closes: SYS#7877
Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd
---
M .checkpatch.conf
M ccid_common/ccid_slot_fsm.c
M ccid_common/cuart.c
M ccid_common/cuart.h
M ccid_common/iso7816_fsm.c
M ccid_host/Makefile
A ccid_host/libosmo_emb.c
A ccid_host/libosmo_emb.h
M sysmoOCTSIM/libosmo_emb.h
M sysmoOCTSIM/main.c
10 files changed, 124 insertions(+), 54 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/81/42481/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd
Gerrit-Change-Number: 42481
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email )
Change subject: sysmoOCTSIM: define own IRQ handlers
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I've tested the chain by doing an invalid memory read via usb vendor requests.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42225?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: If8476fd4a784312a0597ddd0b7eb54a7ebf94868
Gerrit-Change-Number: 42225
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Mar 2026 14:27:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No