March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: contrib/jenkins_manuals: fix doc/manuals paths
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42452?usp=email ) Change subject: contrib/jenkins_manuals: fix doc/manuals paths ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibfccefec7e44a4803d4ff8ad061db395fc498b89 Gerrit-Change-Number: 42452 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Mar 2026 11:54:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-uecups[master]: Use libosmocore netdev API
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email ) Change subject: Use libosmocore netdev API ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: CI failing because it depends on https://gerrit.osmocom.org/c/libosmocore/+/42443 still not merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 Gerrit-Change-Number: 42444 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Mar 2026 11:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-uecups[master]: Use libosmocore netdev API
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, osmith, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email ) Change subject: Use libosmocore netdev API ...................................................................... Patch Set 2: (1 comment) File daemon/internal.h: https://gerrit.osmocom.org/c/osmo-uecups/+/42444/comment/6675a265_0415f6a8?… : PS1, Line 16: logging.h > Is logging stuff needed in this header? Indeed, this is part of next commit I'm preparing. -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 Gerrit-Change-Number: 42444 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Mar 2026 11:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-uecups[master]: Use libosmocore netdev API
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Use libosmocore netdev API ...................................................................... Use libosmocore netdev API Depends: libosmocore.git Change-Id I75153eb59e96a6a2505dc5b29432c76e5c21ea24 Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 --- A TODO-RELEASE M daemon/Makefile.am M daemon/gtp_tunnel.c M daemon/internal.h D daemon/netdev.c M daemon/tun_device.c 6 files changed, 68 insertions(+), 182 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/44/42444/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 Gerrit-Change-Number: 42444 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-uecups[master]: Use libosmocore netdev API
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email ) Change subject: Use libosmocore netdev API ...................................................................... Patch Set 2: (1 comment) File daemon/gtp_tunnel.c: https://gerrit.osmocom.org/c/osmo-uecups/+/42444/comment/7a6af90e_77aad278?… : PS1, Line 20: #define ADDR_SUBNET_PREFIX 16 > I'm unsure which address subnet should I be setting here. […] Fixed, I accidentally disabled the code path adding the default route. -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 Gerrit-Change-Number: 42444 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Mar 2026 11:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: rest_server: log received requests (as debug)
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42451?usp=email ) Change subject: rest_server: log received requests (as debug) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I25da9662fb98a0eafcedfde21b12a937225f5fb9 Gerrit-Change-Number: 42451 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Mar 2026 11:42:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-uecups[master]: Use libosmocore netdev API
by pespin 20 Mar '26

20 Mar '26

Attention is currently required from: daniel, laforge, lynxis lazus, osmith, pespin. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Use libosmocore netdev API ...................................................................... Use libosmocore netdev API Depends: libosmocore.git Change-Id I75153eb59e96a6a2505dc5b29432c76e5c21ea24 Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 --- A TODO-RELEASE M daemon/Makefile.am M daemon/gtp_tunnel.c M daemon/internal.h D daemon/netdev.c M daemon/tun_device.c 6 files changed, 69 insertions(+), 182 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/44/42444/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/42444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I8f18ef56a6e7186fed88f965fbb34aa390c3bac1 Gerrit-Change-Number: 42444 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...osmo-s1gw[master]: contrib/jenkins_manuals: fix doc/manuals paths
by osmith 20 Mar '26

20 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42452?usp=email ) Change subject: contrib/jenkins_manuals: fix doc/manuals paths ...................................................................... contrib/jenkins_manuals: fix doc/manuals paths Change-Id: Ibfccefec7e44a4803d4ff8ad061db395fc498b89 --- M contrib/jenkins_manuals.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/52/42452/1 diff --git a/contrib/jenkins_manuals.sh b/contrib/jenkins_manuals.sh index 05d53dc..0797f0d 100755 --- a/contrib/jenkins_manuals.sh +++ b/contrib/jenkins_manuals.sh @@ -1,7 +1,7 @@ #!/bin/sh -ex -make -C docs/manuals +make -C doc/manuals if [ "$PUBLISH" = "1" ]; then - make -C docs/manuals publish + make -C doc/manuals publish fi -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42452?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ibfccefec7e44a4803d4ff8ad061db395fc498b89 Gerrit-Change-Number: 42452 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: rest_server: log received requests (as debug)
by fixeria 20 Mar '26

20 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42451?usp=email ) Change subject: rest_server: log received requests (as debug) ...................................................................... rest_server: log received requests (as debug) Change-Id: I25da9662fb98a0eafcedfde21b12a937225f5fb9 Related: SYS#7066 --- M src/osmo_s1gw_sup.erl M src/rest_server.erl 2 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/51/42451/1 diff --git a/src/osmo_s1gw_sup.erl b/src/osmo_s1gw_sup.erl index 06174b2..fd89b3c 100644 --- a/src/osmo_s1gw_sup.erl +++ b/src/osmo_s1gw_sup.erl @@ -163,7 +163,8 @@ #{callback => rest_server, spec_path => list_to_binary(osmo_s1gw:get_priv("openapi.json")), port => osmo_s1gw:get_env(rest_srv_port, ?ENV_DEFAULT_REST_SRV_PORT), - swagger_ui => osmo_s1gw:get_env(rest_srv_swagger_ui, ?ENV_DEFAULT_REST_SRV_SWAGGER_UI)}. + swagger_ui => osmo_s1gw:get_env(rest_srv_swagger_ui, ?ENV_DEFAULT_REST_SRV_SWAGGER_UI), + preprocess_middlewares => [rest_server]}. %% vim:set ts=4 sw=4 et: diff --git a/src/rest_server.erl b/src/rest_server.erl index 19554ac..f9176cb 100644 --- a/src/rest_server.erl +++ b/src/rest_server.erl @@ -34,6 +34,8 @@ -module(rest_server). +-behaviour(erf_preprocess_middleware). + -export([config_read/1, metrics_list/1, pfcp_assoc_state/1, @@ -53,6 +55,8 @@ erab_delete/1 ]). +-export([preprocess/1]). + -include_lib("kernel/include/logger.hrl"). -include("osmo_s1gw.hrl"). @@ -629,4 +633,25 @@ bval(V) -> V. +%% ------------------------------------------------------------------ +%% erf_preprocess_middleware API +%% ------------------------------------------------------------------ + +-spec preprocess(erf:request()) -> erf:request(). +preprocess(#{peer := Peer, + method := Method, + path := Path, + query_parameters := QP} = Request) -> + %% We're not really pre-processing anything here, just logging requests + MethodStr = string:uppercase(atom_to_list(Method)), + PathStr = lists:join("/", [binary_to_list(P) || P <- Path]), + QPStr = case QP of + [] -> ""; + _ -> [$? | lists:join($&, [<<K/bytes, $=, V/bytes>> || {K, V} <- QP])] + end, + ?LOG_DEBUG("[REST] ~s - \"~s /~s~s\"", + [Peer, MethodStr, PathStr, QPStr]), + Request. + + %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I25da9662fb98a0eafcedfde21b12a937225f5fb9 Gerrit-Change-Number: 42451 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Add PLMN/eNB IDs to EnbItem
by fixeria 20 Mar '26

20 Mar '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42449?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: [REST] Add PLMN/eNB IDs to EnbItem ...................................................................... [REST] Add PLMN/eNB IDs to EnbItem Change-Id: I79690223a34afea5e6661125ac04f98462dadb03 Related: SYS#7066 --- M contrib/openapi.yaml M doc/manuals/chapters/rest.adoc M priv/openapi.json M src/rest_server.erl 4 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/49/42449/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I79690223a34afea5e6661125ac04f98462dadb03 Gerrit-Change-Number: 42449 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026