March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-trx: check sscanf() result in NOMTXPOWER/SETPOWER handlers
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email ) Change subject: osmo-bts-trx: check sscanf() result in NOMTXPOWER/SETPOWER handlers ...................................................................... osmo-bts-trx: check sscanf() result in NOMTXPOWER/SETPOWER handlers Both trx_ctrl_rx_rsp_nomtxpower() and trx_ctrl_rx_rsp_setpower() were calling sscanf() without checking its return value. On a parse failure the local variable remained uninitialized and was passed directly to the callback, resulting in a garbage power level. Change-Id: I3dc399cfae70c450d53d66bb99f3832f160fca39 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 60705fc..56910fd 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -581,7 +581,10 @@ "through VTY cmd 'nominal-tx-power'.\n", rsp->status); if (cb) { - sscanf(rsp->params, "%d", &nominal_power); + if (sscanf(rsp->params, "%d", &nominal_power) != 1) { + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Failed to parse NOMTXPOWER response\n"); + return -EINVAL; + } cb(l1h, nominal_power, rsp->status); } return 0; @@ -597,7 +600,10 @@ LOGPPHI(pinst, DTRX, LOGL_ERROR, "transceiver SETPOWER failed with status %d\n", rsp->status); if (cb) { - sscanf(rsp->params, "%d", &power_att); + if (sscanf(rsp->params, "%d", &power_att) != 1) { + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Failed to parse SETPOWER response\n"); + return -EINVAL; + } cb(l1h, power_att, rsp->status); } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3dc399cfae70c450d53d66bb99f3832f160fca39 Gerrit-Change-Number: 42511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: clean up log messages in response handlers
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42512?usp=email ) Change subject: osmo-bts-trx: clean up log messages in response handlers ...................................................................... osmo-bts-trx: clean up log messages in response handlers Drop the redundant "transceiver" prefix from LOGPPHI() calls - the macro already prepends the PHY instance name. Change-Id: Iec722198f161621dd00ce3baabb732e1a1d91a37 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 56910fd..6445e9d 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -511,13 +511,13 @@ unsigned int tn, ts_type; if (rsp->status) - LOGPPHI(pinst, DTRX, LOGL_ERROR, "transceiver SETSLOT failed with status %d\n", + LOGPPHI(pinst, DTRX, LOGL_ERROR, "SETSLOT failed with status %d\n", rsp->status); /* Since message was already validated against CMD we sent, we know format * of params is: "<TN> <TS_TYPE>" */ if (sscanf(rsp->params, "%u %u", &tn, &ts_type) < 2) { - LOGPPHI(pinst, DTRX, LOGL_ERROR, "transceiver SETSLOT unable to parse params\n"); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Failed to parse SETSLOT response\n"); return -EINVAL; } @@ -575,10 +575,9 @@ int nominal_power; if (rsp->status) - LOGPPHI(pinst, DTRX, LOGL_ERROR, "transceiver NOMTXPOWER failed " - "with status %d. If your transceiver doesn't support this " - "command, then please set the nominal transmit power manually " - "through VTY cmd 'nominal-tx-power'.\n", + LOGPPHI(pinst, DTRX, LOGL_ERROR, "NOMTXPOWER failed with status %d. " + "If your transceiver doesn't support this command, then please " + "set the nominal transmit power manually through VTY cmd 'nominal-tx-power'.\n", rsp->status); if (cb) { if (sscanf(rsp->params, "%d", &nominal_power) != 1) { @@ -597,7 +596,7 @@ int power_att; if (rsp->status) - LOGPPHI(pinst, DTRX, LOGL_ERROR, "transceiver SETPOWER failed with status %d\n", + LOGPPHI(pinst, DTRX, LOGL_ERROR, "SETPOWER failed with status %d\n", rsp->status); if (cb) { if (sscanf(rsp->params, "%d", &power_att) != 1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iec722198f161621dd00ce3baabb732e1a1d91a37 Gerrit-Change-Number: 42512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: l1sap: check_for_ciph_cmd(): add missing msgb length check
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42513?usp=email ) Change subject: l1sap: check_for_ciph_cmd(): add missing msgb length check ...................................................................... l1sap: check_for_ciph_cmd(): add missing msgb length check The function accesses msg->data[0..4] without first verifying that the message is at least 5 bytes long, which would cause a buffer over-read on a malformed (too short) LAPDm frame. Change-Id: I47690f1a6357e42913bfa8100e36c05cb4f0607a --- M src/common/l1sap.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 3d0263f..e150398 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -215,6 +215,9 @@ return 0; } + if (msgb_length(msg) < 5) + return 0; + /* First byte (Address Field) of LAPDm header) */ if (msg->data[0] != 0x03) return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I47690f1a6357e42913bfa8100e36c05cb4f0607a Gerrit-Change-Number: 42513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: bts_ctrl_commands: remove debugging leftover
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42514?usp=email ) Change subject: bts_ctrl_commands: remove debugging leftover ...................................................................... bts_ctrl_commands: remove debugging leftover Change-Id: I571a10f94482e3097aa915f192db6215f085dbcd --- M src/common/bts_ctrl_commands.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/bts_ctrl_commands.c b/src/common/bts_ctrl_commands.c index 5f6857c..af8fca7 100644 --- a/src/common/bts_ctrl_commands.c +++ b/src/common/bts_ctrl_commands.c @@ -53,8 +53,6 @@ struct trx_power_params *tpp = &trx->power_params; int val = atoi(cmd->value); - printf("set_therm_att(trx=%p, tpp=%p)\n", trx, tpp); - tpp->thermal_attenuation_mdB = val; power_ramp_start(trx, tpp->p_total_cur_mdBm, 0, NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I571a10f94482e3097aa915f192db6215f085dbcd Gerrit-Change-Number: 42514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bts[master]: phy_link: phy_{link,instance}_name(): fix shared static buffer
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42509?usp=email ) Change subject: phy_link: phy_{link,instance}_name(): fix shared static buffer ...................................................................... phy_link: phy_{link,instance}_name(): fix shared static buffer Both functions were writing into the same static buffer, so any caller holding a pointer returned by one and then invoking the other would silently end up with a stale/overwritten string. Move name_buf into each function as a local static, so the two buffers are independent. Change-Id: I79e9d7f5b1e5c275911cf88854211f1ce8a28669 --- M src/common/phy_link.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/common/phy_link.c b/src/common/phy_link.c index ee5ef8a..8f1e389 100644 --- a/src/common/phy_link.c +++ b/src/common/phy_link.c @@ -149,9 +149,9 @@ talloc_free(plink); } -static char name_buf[32]; const char *phy_link_name(const struct phy_link *plink) { + static char name_buf[32]; snprintf(name_buf, sizeof(name_buf), "phy%u", plink->num); return name_buf; } @@ -182,6 +182,7 @@ const char *phy_instance_name(const struct phy_instance *pinst) { + static char name_buf[32]; snprintf(name_buf, sizeof(name_buf), "phy%u.%u", pinst->phy_link->num, pinst->num); return name_buf; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I79e9d7f5b1e5c275911cf88854211f1ce8a28669 Gerrit-Change-Number: 42509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: scheduler: trx_sched_is_sacch_fn(): fix returning non-bool
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42508?usp=email ) Change subject: scheduler: trx_sched_is_sacch_fn(): fix returning non-bool ...................................................................... scheduler: trx_sched_is_sacch_fn(): fix returning non-bool The function is declared `bool` but returns `-EINVAL` on an error path. `-EINVAL` is `-22`, which in C implicitly converts to `bool true`. Returning `false` makes more sense when we don't know the MF layout. Change-Id: Ib2394687815aed4990c3880446176e4c97440667 --- M src/common/scheduler_mframe.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/common/scheduler_mframe.c b/src/common/scheduler_mframe.c index 60b6353..647ffc0 100644 --- a/src/common/scheduler_mframe.c +++ b/src/common/scheduler_mframe.c @@ -1009,7 +1009,7 @@ i = find_sched_mframe_idx(ts_pchan(ts), ts->nr); if (i < 0) - return -EINVAL; + return false; sched = &trx_sched_multiframes[i]; frame = &sched->frames[fn % sched->period]; if (uplink) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib2394687815aed4990c3880446176e4c97440667 Gerrit-Change-Number: 42508 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: phy_link: phy_instance_link_to_trx(): add missing semicolon
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42507?usp=email ) Change subject: phy_link: phy_instance_link_to_trx(): add missing semicolon ...................................................................... phy_link: phy_instance_link_to_trx(): add missing semicolon Change-Id: Ica33798adfdc5aad6b6aa9e252e9cc9294bad659 --- M src/common/phy_link.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/phy_link.c b/src/common/phy_link.c index 352d8f7..ee5ef8a 100644 --- a/src/common/phy_link.c +++ b/src/common/phy_link.c @@ -119,7 +119,7 @@ void phy_instance_link_to_trx(struct phy_instance *pinst, struct gsm_bts_trx *trx) { /* There might already be an associated TRX */ - OSMO_ASSERT(pinst->trx == NULL) + OSMO_ASSERT(pinst->trx == NULL); trx->pinst = pinst; pinst->trx = trx; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ica33798adfdc5aad6b6aa9e252e9cc9294bad659 Gerrit-Change-Number: 42507 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: ignore SSCANF_TO_KSTRTO
by osmith 27 Mar '26

27 Mar '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42516?usp=email ) Change subject: lint/checkpatch: ignore SSCANF_TO_KSTRTO ...................................................................... lint/checkpatch: ignore SSCANF_TO_KSTRTO This kernel-specific warning doesn't make sense when linting our code so disable it. Change-Id: If096c600331d7ad5786395c5c41a6742da44a3e8 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index ac586f7..de14044 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -76,6 +76,7 @@ # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...') # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines +# * SSCANF_TO_KSTRTO: kernel specific # * STRING_FRAGMENTS: sometimes used intentionally to improve readability # * SYMBOLIC_PERMS: recommends using octal permissions over symbolic ones, not followed # * TRACING_LOGGING: recommends to use kernel's internal ftrace instead of printf("%s()\n", __func__) @@ -114,6 +115,7 @@ --ignore REPEATED_WORD \ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ + --ignore SSCANF_TO_KSTRTO \ --ignore STRING_FRAGMENTS \ --ignore SYMBOLIC_PERMS \ --ignore TRACING_LOGGING \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If096c600331d7ad5786395c5c41a6742da44a3e8 Gerrit-Change-Number: 42516 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/checkpatch: ignore SSCANF_TO_KSTRTO
by pespin 27 Mar '26

27 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42516?usp=email ) Change subject: lint/checkpatch: ignore SSCANF_TO_KSTRTO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If096c600331d7ad5786395c5c41a6742da44a3e8 Gerrit-Change-Number: 42516 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 07:41:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: measurement: is_meas_complete(): fix fn_mod variable type
by pespin 27 Mar '26

27 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email ) Change subject: measurement: is_meas_complete(): fix fn_mod variable type ...................................................................... Patch Set 1: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/42515/comment/0a2c2b6c_ee141e25?usp… : PS1, Line 277: fn_mod = fn % 102; so here and in line 283 we are now doing (-1 % 102)? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b0bce9bc9fca1d6effbb2da2319132cdff4e9c7 Gerrit-Change-Number: 42515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 07:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026