March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: measurement: is_meas_complete(): fix fn_mod variable type
by pespin 27 Mar '26

27 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email ) Change subject: measurement: is_meas_complete(): fix fn_mod variable type ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/42515/comment/89798325_aff548c3?usp… : PS1, Line 277: fn_mod = fn % 102; > No? We're doing `fn % 102`, `fn` is an argument of type `uint32_t`. Ah sorry indeed I saw it wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b0bce9bc9fca1d6effbb2da2319132cdff4e9c7 Gerrit-Change-Number: 42515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 11:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42305?usp=email ) Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 09:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: PySimLogger: add parameter to set initial log-level/verbosity
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42304?usp=email ) Change subject: PySimLogger: add parameter to set initial log-level/verbosity ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/42304/comment/8b04ba8a_d5f00ed6?usp=em… : PS2, Line 110: setup Are you intentionally not passing `verbose` here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 Gerrit-Change-Number: 42304 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 09:28:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove semicolon
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42311?usp=email ) Change subject: pySim-shell/cosmetic: remove semicolon ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc Gerrit-Change-Number: 42311 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 09:22:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: add python 3.14
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email ) Change subject: OBS: pyhss_download_deps: add python 3.14 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f Gerrit-Change-Number: 42518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 09:22:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: fix dependency loop
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42517?usp=email ) Change subject: OBS: pyhss_download_deps: fix dependency loop ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0484627fd105627fabe9435379e704db54e72ae3 Gerrit-Change-Number: 42517 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 09:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: add python 3.14
by osmith 27 Mar '26

27 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email ) Change subject: OBS: pyhss_download_deps: add python 3.14 ...................................................................... OBS: pyhss_download_deps: add python 3.14 Download binary package dependencies for python 3.14 too, so we can build the package for Ubuntu 26.04. Related: OS#6983 Related: https://gitea.osmocom.org/osmocom/pyhss/commit/2125f52c5eb1b3e66b1ebe2febad… Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f --- M scripts/obs/data/pyhss_download_deps.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/42518/1 diff --git a/scripts/obs/data/pyhss_download_deps.sh b/scripts/obs/data/pyhss_download_deps.sh index fb71e9a..6c23032 100644 --- a/scripts/obs/data/pyhss_download_deps.sh +++ b/scripts/obs/data/pyhss_download_deps.sh @@ -24,6 +24,7 @@ 3.11 3.12 3.13 + 3.14 " # See e.g. https://pypi.org/project/SQLAlchemy/#files local platform -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f Gerrit-Change-Number: 42518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: fix dependency loop
by osmith 27 Mar '26

27 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42517?usp=email ) Change subject: OBS: pyhss_download_deps: fix dependency loop ...................................................................... OBS: pyhss_download_deps: fix dependency loop Fix that the Osmocom_OBS_nightly job is failing for the pyhss package with a dependency loop in hatchling: LookupError: https://files.pythonhosted.org/…/hatchling-1.29.0.tar.gz (from https://pypi.org/simple/hatchling/) (requires-python:>=3.10) is already being built: hatchling>=1.21.0 from https://files.pythonhosted.org/…/hatchling-1.29.0.tar.gz This happens as it recursively collects source packages and their (build) dependencies: pymongo -> dnspython -> hatchling -> pluggy -> setuptools-scm -> vcs-versioning -> hatchling When only ignoring the hatchling source package, we get a similar dependency loop with pluggy, so ignore both source packages. Hatchling gets added later as binary package and pluggy is only a build-time dependency for hatchling. The resulting PyHSS package builds fine with this change. Change-Id: I0484627fd105627fabe9435379e704db54e72ae3 --- M scripts/obs/data/pyhss_download_deps.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/42517/1 diff --git a/scripts/obs/data/pyhss_download_deps.sh b/scripts/obs/data/pyhss_download_deps.sh index 7dfd5d9..fb71e9a 100644 --- a/scripts/obs/data/pyhss_download_deps.sh +++ b/scripts/obs/data/pyhss_download_deps.sh @@ -63,6 +63,8 @@ pip download \ --dest debian/deps \ --no-binary=:all: \ + --only-binary=hatchling \ + --only-binary=pluggy \ -r "$srcpkgs" for py_ver in $python_versions; do -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0484627fd105627fabe9435379e704db54e72ae3 Gerrit-Change-Number: 42517 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: measurement: is_meas_complete(): fix fn_mod variable type
by fixeria 27 Mar '26

27 Mar '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email ) Change subject: measurement: is_meas_complete(): fix fn_mod variable type ...................................................................... Patch Set 1: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/42515/comment/b7def2cd_70d2fb90?usp… : PS1, Line 277: fn_mod = fn % 102; > so here and in line 283 we are now doing (-1 % 102)? No? We're doing `fn % 102`, `fn` is an argument of type `uint32_t`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b0bce9bc9fca1d6effbb2da2319132cdff4e9c7 Gerrit-Change-Number: 42515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Mar 2026 08:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: tx_power: get_pa_drive_level_mdBm(): assert on out-of-range ARFCN
by fixeria 27 Mar '26

27 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42510?usp=email ) Change subject: tx_power: get_pa_drive_level_mdBm(): assert on out-of-range ARFCN ...................................................................... tx_power: get_pa_drive_level_mdBm(): assert on out-of-range ARFCN The function previously returned `INT_MIN` as an error sentinel when the ARFCN exceeded the calibration table size (1024 entries, covering all valid GSM ARFCNs 0..1023). None of the callers checked for this value, so it would silently propagate through power calculations and eventually be passed to `bts_model_change_power()`. An out-of-range ARFCN indicates a serious misconfiguration; replace the range check and `return INT_MIN` with an `OSMO_ASSERT`. Change-Id: I70c54652e0b07d399363276bc60946aa8b195725 --- M src/common/tx_power.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/common/tx_power.c b/src/common/tx_power.c index 83cdb62..1e026dd 100644 --- a/src/common/tx_power.c +++ b/src/common/tx_power.c @@ -20,7 +20,6 @@ */ #include <stdint.h> -#include <limits.h> #include <errno.h> #include <osmocom/core/utils.h> @@ -34,8 +33,7 @@ static int get_pa_drive_level_mdBm(const struct power_amp *pa, int desired_p_out_mdBm, unsigned int arfcn) { - if (arfcn >= ARRAY_SIZE(pa->calib.delta_mdB)) - return INT_MIN; + OSMO_ASSERT(arfcn < ARRAY_SIZE(pa->calib.delta_mdB)); /* FIXME: temperature compensation */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70c54652e0b07d399363276bc60946aa8b195725 Gerrit-Change-Number: 42510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026