[XS] Change in osmo-bts[master]: measurement: is_meas_complete(): fix fn_mod variable type - gerrit-log

27 Mar 2026


      Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email )
Change subject: measurement: is_meas_complete(): fix fn_mod variable type
......................................................................
Patch Set 1:
(1 comment)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42515/comment/b7def2cd_70d2fb90?usp=... :
PS1, Line 277: 		fn_mod = fn % 102;
...
so here and in line 283 we are now doing (-1 % 102)?
No? We're doing `fn % 102`, `fn` is an argument of type `uint32_t`.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42515?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b0bce9bc9fca1d6effbb2da2319132cdff4e9c7
Gerrit-Change-Number: 42515
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 27 Mar 2026 08:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de