March 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ccid-firmware[master]: firmware: replace libosmocore fsm timers
by jolly 26 Mar '26

26 Mar '26

Attention is currently required from: Hoernchen, laforge. jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email ) Change subject: firmware: replace libosmocore fsm timers ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Mar 2026 14:17:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: xua_snm: Add spec reference regarding no SSNM tx
by pespin 26 Mar '26

26 Mar '26

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42505?usp=email ) Change subject: cosmetic: xua_snm: Add spec reference regarding no SSNM tx ...................................................................... cosmetic: xua_snm: Add spec reference regarding no SSNM tx Change-Id: I69912d5b7032c12e06648e5f5a700384182bb1f9 --- M src/xua_snm.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/05/42505/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I69912d5b7032c12e06648e5f5a700384182bb1f9 Gerrit-Change-Number: 42505 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: xua_snm: Add spec reference regarding no SSNM tx
by pespin 26 Mar '26

26 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42505?usp=email ) Change subject: cosmetic: xua_snm: Add spec reference regarding no SSNM tx ...................................................................... cosmetic: xua_snm: Add spec reference regarding no SSNM tx Change-Id: I69912d5b7032c12e06648e5f5a700384182bb1f9 --- M src/xua_snm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/05/42505/1 diff --git a/src/xua_snm.c b/src/xua_snm.c index 916f6c3..c3a6cf8 100644 --- a/src/xua_snm.c +++ b/src/xua_snm.c @@ -236,7 +236,7 @@ /* inform remote ASPs via DUNA/DAVA */ llist_for_each_entry(asp, &s7i->asp_list, list) { - /* SSNM is only permitted for ASPs in ACTIVE state */ + /* SSNM is only permitted for ASPs in ACTIVE state (RFC4666 4.3.1) */ if (!osmo_ss7_asp_active(asp)) continue; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I69912d5b7032c12e06648e5f5a700384182bb1f9 Gerrit-Change-Number: 42505 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: add Ubuntu 26.04
by pespin 26 Mar '26

26 Mar '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email ) Change subject: OBS: add Ubuntu 26.04 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id22f4902b73ad9b4131b837a8036df68cf665f8f Gerrit-Change-Number: 42503 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Mar 2026 12:49:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: replace libosmocore fsm timers
by Hoernchen 26 Mar '26

26 Mar '26

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: firmware: replace libosmocore fsm timers ...................................................................... firmware: replace libosmocore fsm timers Concurrent access from main loop and the different uart irqs was not going well and caused crashes. The libosmocore fsm does still allocate one internal timer, but it is not used by the firmware, so libosmocore will not touch the rbtree. Additionally ignore checkpatch jiffies complaints because we're trying to do firmware here. Closes: SYS#7877 Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd --- M .checkpatch.conf M ccid_common/ccid_slot_fsm.c M ccid_common/cuart.c M ccid_common/cuart.h M ccid_common/iso7816_fsm.c M ccid_host/Makefile A ccid_host/libosmo_emb.c A ccid_host/libosmo_emb.h M sysmoOCTSIM/main.c 9 files changed, 112 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/81/42481/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: replace libosmocore fsm timers
by Hoernchen 26 Mar '26

26 Mar '26

Attention is currently required from: jolly, laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email ) Change subject: firmware: replace libosmocore fsm timers ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > I would prefer if the host code would simply get a jiffies variable + a timer updating it. […] no idea what is easier to test on the host since it has very little in common with interrupt driven uarts and their failure modes which was the reason why the octsim had everything except the one thing that mattered which was error handling and it has not been used by anone during the past 6 years but oh well there is a jiffies emulation now so it keeps building. File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/504bdec0_6b… : PS4, Line 271: ip->uart->wtime_deadline = timeout_ms ? (jiffies + timeout_ms) + 1 : 0; > You are reading 'jiffies', which is incremented by interrupt. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 26 Mar 2026 12:39:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: add tear-free 64bit load/store helpers for jiffies
by Hoernchen 26 Mar '26

26 Mar '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email ) Change subject: firmware: add tear-free 64bit load/store helpers for jiffies ...................................................................... firmware: add tear-free 64bit load/store helpers for jiffies On Cortex-M4 a 64bit load may compile to two separate LDR instructions which can lead to torn reads due to interrupts. LDRD/STRD are restartable, they either complete or restart from scratch, so the result is always consistent. The only "downside" is the required alignment, which is fine. Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625 --- A ccid_common/atomic_u64.h M sysmoOCTSIM/libosmo_emb.c A sysmoOCTSIM/libosmo_emb.h 3 files changed, 97 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/04/42504/1 diff --git a/ccid_common/atomic_u64.h b/ccid_common/atomic_u64.h new file mode 100644 index 0000000..fea0ae3 --- /dev/null +++ b/ccid_common/atomic_u64.h @@ -0,0 +1,38 @@ +#pragma once +/* Tear-free 64bit load/store for Cortex-M4. + * + * LDRD/STRD are restartable: if an interrupt arrives mid-instruction the + * core restarts the access from scratch, so the result is always consistent. + * This requires 8-byte alignment! + */ + +#include <stdint.h> + +#if defined(__arm__) +static inline uint64_t ldrd_u64(const volatile uint64_t *p) +{ + uint32_t lo, hi; + __asm__ volatile ( + "ldrd %0, %1, [%2]\n" + : "=&r"(lo), "=&r"(hi) + : "r"(p) + : "memory" + ); + return ((uint64_t)hi << 32) | lo; +} + +static inline void strd_u64(volatile uint64_t *p, uint64_t v) +{ + uint32_t lo = (uint32_t)v; + uint32_t hi = (uint32_t)(v >> 32); + __asm__ volatile ( + "strd %1, %2, [%0]\n" + : : "r"(p), "r"(lo), "r"(hi) + : "memory" + ); +} +#else +/* host */ +static inline uint64_t ldrd_u64(const volatile uint64_t *p) { return *p; } +static inline void strd_u64(volatile uint64_t *p, uint64_t v) { *p = v; } +#endif diff --git a/sysmoOCTSIM/libosmo_emb.c b/sysmoOCTSIM/libosmo_emb.c index 81b29e3..37f6126 100644 --- a/sysmoOCTSIM/libosmo_emb.c +++ b/sysmoOCTSIM/libosmo_emb.c @@ -15,8 +15,19 @@ #include <sys/time.h> #include "driver_init.h" +#include "libosmo_emb.h" -volatile uint64_t jiffies; +volatile uint64_t jiffies __attribute__((aligned(8))); + +uint64_t get_jiffies(void) +{ + ldrd_u64(&jiffies); +} + +void store_jiffies(uint64_t j) +{ + strd_u64(&jiffies, j); +} void SysTick_Handler(void) { @@ -25,8 +36,9 @@ int _gettimeofday(struct timeval *tv, void *tz) { - tv->tv_sec = jiffies / 1000; - tv->tv_usec = (jiffies % 1000) * 1000; + uint64_t j = get_jiffies(); + tv->tv_sec = j / 1000; + tv->tv_usec = (j % 1000) * 1000; return 0; } diff --git a/sysmoOCTSIM/libosmo_emb.h b/sysmoOCTSIM/libosmo_emb.h new file mode 100644 index 0000000..3588925 --- /dev/null +++ b/sysmoOCTSIM/libosmo_emb.h @@ -0,0 +1,44 @@ +/* Tear-free 64-bit load/store for Cortex-M4. + * + * LDRD/STRD are restartable: if an interrupt arrives mid-instruction the + * core restarts the access from scratch, so the result is always consistent. + * This requires 8-byte alignment (unaligned LDRD silently becomes two + * separate word accesses, losing the restart guarantee). + * + * Worst-case outcome is being off by one tick (1 ms) which is irrelevant + * for the timeout use-case. + */ + +#include <stdint.h> + +#if defined(__arm__) +static inline uint64_t ldrd_u64(const volatile uint64_t *p) +{ + uint32_t lo, hi; + __asm__ volatile ( + "ldrd %0, %1, [%2]\n" + : "=&r"(lo), "=&r"(hi) + : "r"(p) + : "memory" + ); + return ((uint64_t)hi << 32) | lo; +} + +static inline void strd_u64(volatile uint64_t *p, uint64_t v) +{ + uint32_t lo = (uint32_t)v; + uint32_t hi = (uint32_t)(v >> 32); + __asm__ volatile ( + "strd %1, %2, [%0]\n" + : : "r"(p), "r"(lo), "r"(hi) + : "memory" + ); +} +#else +/* host */ +static inline uint64_t ldrd_u64(const volatile uint64_t *p) { return *p; } +static inline void strd_u64(volatile uint64_t *p, uint64_t v) { *p = v; } +#endif + +uint64_t get_jiffies(void); +void store_jiffies(uint64_t j); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I729c0fdfb5b228b03c2df1cf098743100b1ea625 Gerrit-Change-Number: 42504 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: replace libosmocore fsm timers
by Hoernchen 26 Mar '26

26 Mar '26

Attention is currently required from: Hoernchen, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: firmware: replace libosmocore fsm timers ...................................................................... firmware: replace libosmocore fsm timers Concurrent access from main loop and the different uart irqs was not going well and caused crashes. The libosmocore fsm does still allocate one internal timer, but it is not used by the firmware, so libosmocore will not touch the rbtree. Additionally ignore checkpatch jiffies complaints because we're trying to do firmware here. Closes: SYS#7877 Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd --- M .checkpatch.conf M ccid_common/ccid_slot_fsm.c M ccid_common/cuart.c M ccid_common/cuart.h M ccid_common/iso7816_fsm.c M ccid_host/Makefile A ccid_host/libosmo_emb.c A ccid_host/libosmo_emb.h M sysmoOCTSIM/main.c 9 files changed, 109 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/81/42481/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd Gerrit-Change-Number: 42481 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ci[master]: OBS: add Ubuntu 26.04
by fixeria 26 Mar '26

26 Mar '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email ) Change subject: OBS: add Ubuntu 26.04 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id22f4902b73ad9b4131b837a8036df68cf665f8f Gerrit-Change-Number: 42503 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Mar 2026 12:07:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: add Ubuntu 26.04
by osmith 26 Mar '26

26 Mar '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email ) Change subject: OBS: add Ubuntu 26.04 ...................................................................... OBS: add Ubuntu 26.04 Change-Id: Id22f4902b73ad9b4131b837a8036df68cf665f8f --- M contrib/obs-mirror/obs-mirror-include.txt M jobs/osmocom-obs-sync.yml 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/42503/1 diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 5031b57..47b9253 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -9,6 +9,7 @@ latest/xUbuntu_24.04 latest/xUbuntu_25.04 latest/xUbuntu_25.10 +latest/xUbuntu_26.04 nightly/CentOS_7 nightly/Debian_11 @@ -21,3 +22,4 @@ nightly/xUbuntu_24.04 nightly/xUbuntu_25.04 nightly/xUbuntu_25.10 +nightly/xUbuntu_26.04 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 146efa3..1d16c94 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -45,6 +45,7 @@ Ubuntu:24.04 Ubuntu:25.04 Ubuntu:25.10 + Ubuntu:26.04 " ./scripts/obs/sync_obs_projects.py \ --docker \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id22f4902b73ad9b4131b837a8036df68cf665f8f Gerrit-Change-Number: 42503 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026