Attention is currently required from: jolly, laforge.

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )

Change subject: firmware: replace libosmocore fsm timers ......................................................................

Patch Set 5:

(2 comments)

Patchset:

PS4:

I would prefer if the host code would simply get a jiffies variable + a timer updating it. […]

no idea what is easier to test on the host since it has very little in common with interrupt driven uarts and their failure modes which was the reason why the octsim had everything except the one thing that mattered which was error handling and it has not been used by anone during the past 6 years but oh well there is a jiffies emulation now so it keeps building.

File ccid_common/iso7816_fsm.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/504bdec0_6b9... : PS4, Line 271: ip->uart->wtime_deadline = timeout_ms ? (jiffies + timeout_ms) + 1 : 0;

You are reading 'jiffies', which is incremented by interrupt. […]

Done