October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: es*_Types_JSON: use ts_responseHeader instead of manual assignments
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43821?usp=email ) Change subject: es*_Types_JSON: use ts_responseHeader instead of manual assignments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcc3ed49053bd737c96cb34ab142b5522d86821c Gerrit-Change-Number: 43821 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 09:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed
by dexter 09 Oct '26

09 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email ) Change subject: es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed ...................................................................... es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed The spec (SGP.22) is not 100% clear about how euiccCiPKIdToBeUsed shall be encoded as JSON object. However, observations on a productive SM-DP+ confirm that the implementation in es9p_Types_JSON.ttcn is correct. To prevent further confusion about this, let's add a comment that explains our implementation choice. Related: SYS#8203 Change-Id: I4cb2c9c7e098aa42ae040c5eef0f24eb16a361f7 --- M library/euicc/es9p_Types_JSON.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: jolly: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/euicc/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn index 3e13c42..f7e6587 100644 --- a/library/euicc/es9p_Types_JSON.ttcn +++ b/library/euicc/es9p_Types_JSON.ttcn @@ -227,6 +227,11 @@ str2oct(json_pdu.initiateAuthenticationResponse.transactionId), dec_ServerSigned1(decode_base64(json_pdu.initiateAuthenticationResponse.serverSigned1)), decode_base64(json_pdu.initiateAuthenticationResponse.serverSignature1), + /* The specification (SGP.22) is a bit vague about if the euiccCiPKIdToBeUsed JSON object shall + * be encoded as SubjectKeyIdentifier or if it is to be sent as plain octetstring. However, + * observations in the wild show that we typically find the SubjectKeyIdentifier with a BER-TLV + * header prepended (e.g. 0x0414), which means the encoded form is likely the correct one to + * use. */ dec_SubjectKeyIdentifier(decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdToBeUsed)), dec_Certificate(decode_base64(json_pdu.initiateAuthenticationResponse.serverCertificate)))); } else if (ispresent(json_pdu.getBoundProfilePackageResponse)) { @@ -271,6 +276,7 @@ encode_base64(enc_ServerSigned1(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.serverSigned1)); json_pdu.initiateAuthenticationResponse.serverSignature1 := encode_base64(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.serverSignature1); + /* See comment in dec_RemoteProfileProvisioningResponse_from_JSON (above) */ json_pdu.initiateAuthenticationResponse.euiccCiPKIdToBeUsed := encode_base64(enc_SubjectKeyIdentifier(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.euiccCiPKIdToBeUsed)); json_pdu.initiateAuthenticationResponse.serverCertificate := -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cb2c9c7e098aa42ae040c5eef0f24eb16a361f7 Gerrit-Change-Number: 43779 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: remove code dup in f_esipa_transceive
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email ) Change subject: eIM_Tests: remove code dup in f_esipa_transceive ...................................................................... Patch Set 1: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820/comment/e13154fb_0418… : PS1, Line 481: var template EsipaMessageFromEimToIpa esipa_res This var can be removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Gerrit-Change-Number: 43820 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 09:05:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octets...
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email ) Change subject: esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octetstring ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780/comment/382bfa2a_0839… : PS2, Line 9: SGP.22 Isn't it SGP.32? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f38c5a864c168f1fac0742a72b60de2abd25d49 Gerrit-Change-Number: 43780 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 09:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email ) Change subject: es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4cb2c9c7e098aa42ae040c5eef0f24eb16a361f7 Gerrit-Change-Number: 43779 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 08:55:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally
by pespin 09 Oct '26

09 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email ) Change subject: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally ...................................................................... mtp_sap.h: Introduce new MTP_SIO helpers and use them internally Change-Id: I07a7102b8671482f636fe9e6d41f6d4525f39c85 --- M TODO-RELEASE M include/osmocom/sigtran/mtp_sap.h M src/m3ua.c M src/tcap_as_loadshare.c 4 files changed, 14 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/33/43833/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index ac06fda..a6d47f9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -10,3 +10,4 @@ libosmocore >1.14.2 new VTY node L_CS7_QOS_CLASS_NODE added libosmo-sigtran added enum osmo_sccp_reset_reason_*, enum osmo_sccp_release_reason_* libosmo-sigtran added enum osmo_sccp_return_reason +libosmo-sigtran added MTP_SIO_*() diff --git a/include/osmocom/sigtran/mtp_sap.h b/include/osmocom/sigtran/mtp_sap.h index 1816b2d..3be178a 100644 --- a/include/osmocom/sigtran/mtp_sap.h +++ b/include/osmocom/sigtran/mtp_sap.h @@ -37,7 +37,14 @@ } /* ITU Q.704 14.2 Service information octet. See enum mtp_si_ni00 in mtp.h. */ -#define MTP_SIO(service, net_ind) ((((net_ind) & 0x3) << 6) | ((service) & 0xF)) +#define MTP_SIO_EXT(service, net_ind, mp) \ + ((((net_ind) & 0x3) << 6) | \ + (((mp) & 0x3) << 4) | \ + ((service) & 0xf)) +#define MTP_SIO(service, net_ind) MTP_SIO_EXT(service, net_ind, 0) +#define MTP_SIO_NI(sio) (((sio) >> 6) & 0x3) +#define MTP_SIO_MP(sio) (((sio) >> 4) & 0x3) +#define MTP_SIO_SI(sio) ((sio) & 0xf) struct osmo_mtp_transfer_param { uint32_t opc; diff --git a/src/m3ua.c b/src/m3ua.c index 973e1cd..39272ee 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -526,9 +526,9 @@ { mdh->opc = htonl(param->opc); mdh->dpc = htonl(param->dpc); - mdh->si = param->sio & 0xF; - mdh->ni = (param->sio >> 6) & 0x3; - mdh->mp = (param->sio >> 4) & 0x3; + mdh->si = MTP_SIO_SI(param->sio); + mdh->ni = MTP_SIO_NI(param->sio); + mdh->mp = MTP_SIO_MP(param->sio); mdh->sls = param->sls; } @@ -540,9 +540,7 @@ param->dpc = ntohl(mdh->dpc); param->sls = mdh->sls; /* re-construct SIO */ - param->sio = (mdh->si & 0xF) | - ((mdh->mp & 0x3) << 4) | - ((mdh->ni & 0x3) << 6); + param->sio = MTP_SIO_EXT(mdh->si, mdh->ni, mdh->mp); } struct msgb *m3ua_msgb_alloc(const char *name) diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index b699281..5e8cbb8 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -736,7 +736,7 @@ /* return 0 and asp is set */ int tcap_as_select_asp_loadshare(struct osmo_ss7_asp **asp, struct osmo_ss7_as *as, const struct xua_msg *xua) { - uint8_t service_ind = xua->mtp.sio & 0xF; + uint8_t service_ind = MTP_SIO_SI(xua->mtp.sio); struct xua_msg_part *m3ua_data_ie; struct msgb *sccp_msg; uint8_t *cur; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07a7102b8671482f636fe9e6d41f6d4525f39c85 Gerrit-Change-Number: 43833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: esim/http_json_api.py: support text/plain response Content-Type
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email ) Change subject: esim/http_json_api.py: support text/plain response Content-Type ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS6: I think everything is fine here. File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42155/comment/6012328b_31fc517f?usp=em… : PS5, Line 431: if 'header' in output: > This is not matching some plaintext blob. […] Ah, now I get it. Yes its indeed a dict. I somehow thought you were putting plaintext in output directly, but that's not the case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Gerrit-Change-Number: 42155 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 07:01:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip/batch: add blacklist to to_csv_rows(), improve doc
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43516?usp=email ) Change subject: saip/batch: add blacklist to to_csv_rows(), improve doc ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24 Gerrit-Change-Number: 43516 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 06:55:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: test_configurable_parameters.py: tweak logging
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43513?usp=email ) Change subject: test_configurable_parameters.py: tweak logging ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File tests/unittests/xo/test_configurable_parameters: https://gerrit.osmocom.org/c/pysim/+/43513/comment/55a7bb50_215b1cfe?usp=em… : PS2, Line 4: read_back_val={'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} > This is is just some code tweak in a unit test, I'd appreciate if we can just pass it. […] Thanks for the explanation. Then let's merge it as it is. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38e85ce0902f2ec4db63e158770b6d2cecb2dd30 Gerrit-Change-Number: 43513 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 06:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: personalization: EF_SMSP: keep same length as found in template
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43515?usp=email ) Change subject: personalization: EF_SMSP: keep same length as found in template ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43515/comment/dc2e6225_bacef77a?usp=em… : PS2, Line 640: #f_smsp.rec_len = 42 > i like to put no space before commented-out code lines =) but ok Ok, I try to memorize that ;-) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Gerrit-Change-Number: 43515 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 06:51:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0