October 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: cat: Fix alpha identifier
by dexter 09 Oct '26

09 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43782?usp=email ) Change subject: cat: Fix alpha identifier ...................................................................... cat: Fix alpha identifier Add implementation so that it prints. Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4 Signed-off-by: Eric Salem <ericsalem(a)gmail.com> --- M pySim/cat.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve diff --git a/pySim/cat.py b/pySim/cat.py index e65af3f..80cd002 100644 --- a/pySim/cat.py +++ b/pySim/cat.py @@ -24,7 +24,7 @@ from construct import Struct, Enum, BitStruct, this from construct import Switch, GreedyRange, FlagsEnum, Adapter from osmocom.tlv import TLV_IE, COMPR_TLV_IE, BER_TLV_IE, TLV_IE_Collection -from osmocom.construct import PlmnAdapter, BcdAdapter, GsmStringAdapter, TonNpi, GsmString, Bytes, GreedyBytes +from osmocom.construct import PlmnAdapter, BcdAdapter, GsmOrUcs2Adapter, GsmStringAdapter, TonNpi, GsmString, Bytes, GreedyBytes from osmocom.utils import b2h, h2b from pySim.utils import dec_xplmn_w_act @@ -37,8 +37,7 @@ # TS 102 223 Section 8.2 class AlphaIdentifier(COMPR_TLV_IE, tag=0x85): - # FIXME: like EF.ADN - pass + _construct = GsmOrUcs2Adapter(GreedyBytes) # TS 102 223 Section 8.3 class Subaddress(COMPR_TLV_IE, tag=0x88): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4 Gerrit-Change-Number: 43782 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Salem <ericsalem(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: cat: Fix alpha identifier
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: Eric Salem. dexter has posted comments on this change by Eric Salem. ( https://gerrit.osmocom.org/c/pysim/+/43782?usp=email ) Change subject: cat: Fix alpha identifier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4 Gerrit-Change-Number: 43782 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Salem <ericsalem(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Eric Salem <ericsalem(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Oct 2026 06:48:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: refactor the transceiver FSM
by osmith 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email ) Change subject: trxcon/trx_if: refactor the transceiver FSM ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43824/comment/d75ca65e_071aedde?u… : PS1, Line 858: | S(TRX_ST_POWEROFF), > Yes, it's basically a loop state transition. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I243da047ca606986dbf8ce3cadf69ede4c7227d1 Gerrit-Change-Number: 43824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 06:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: personalization: EF_SMSP: keep same length as found in template
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: personalization: EF_SMSP: keep same length as found in template ...................................................................... personalization: EF_SMSP: keep same length as found in template Leave the decision for the record length to the template: callers can can modify the value in the template without having to patch this code. Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/15/43515/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Gerrit-Change-Number: 43515 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: personalization: EF_SMSP: keep same length as found in template
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder Change subject: personalization: EF_SMSP: keep same length as found in template ...................................................................... personalization: EF_SMSP: keep same length as found in template Leave the decision for the record length to the template: callers can can modify the value in the template without having to patch this code. Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Jenkins: skip-card-test --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/15/43515/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Gerrit-Change-Number: 43515 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in pysim[master]: tweak test_configurable_parameters.py: show value found in template
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: neels. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43514?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: tweak test_configurable_parameters.py: show value found in template ...................................................................... tweak test_configurable_parameters.py: show value found in template Change-Id: If9039bbb8547ee24ae784a932f60cd5de6c9247b Jenkins: skip-card-test --- M tests/unittests/test_configurable_parameters.py M tests/unittests/xo/test_configurable_parameters 2 files changed, 354 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/14/43514/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If9039bbb8547ee24ae784a932f60cd5de6c9247b Gerrit-Change-Number: 43514 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: saip/batch: add blacklist to to_csv_rows(), improve doc
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder Change subject: saip/batch: add blacklist to to_csv_rows(), improve doc ...................................................................... saip/batch: add blacklist to to_csv_rows(), improve doc Allow calling code to mute specific parameters from an output CSV. For example, the SUCI CalcInfo data should be identical for all profiles of a batch, and is also very long data. After this patch, an application can name specific parameters to omit from an output CSV. Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24 Jenkins: skip-card-test --- M pySim/esim/saip/batch.py 1 file changed, 46 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/16/43516/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24 Gerrit-Change-Number: 43516 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: saip/batch: add blacklist to to_csv_rows()
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43516?usp=email ) Change subject: saip/batch: add blacklist to to_csv_rows() ...................................................................... Patch Set 2: (1 comment) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/43516/comment/b182e1dd_c68b682e?usp=em… : PS2, Line 328: """generator that yields all audits' values as rows, useful feed to a csv.writer.""" > As far as I understand this method is supposed to be called by the API user. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24 Gerrit-Change-Number: 43516 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 00:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: personalization: EF_SMSP: keep same length as found in template
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43515?usp=email ) Change subject: personalization: EF_SMSP: keep same length as found in template ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/43515/comment/6cb4cda9_3e471175?usp=em… : PS2, Line 11: can modify the value in the template without having to patch this code. > I think its more like 42 is a correct length. […] Done File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43515/comment/32f4fcd6_96b1c9a8?usp=em… : PS2, Line 640: #f_smsp.rec_len = 42 > If wou want to make i perfect, you can put a space between # and f_smsp.... i like to put no space before commented-out code lines =) but ok -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d Gerrit-Change-Number: 43515 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 00:14:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in pysim[master]: test_configurable_parameters.py: tweak logging
by neels 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43513?usp=email ) Change subject: test_configurable_parameters.py: tweak logging ...................................................................... Patch Set 2: (1 comment) File tests/unittests/xo/test_configurable_parameters: https://gerrit.osmocom.org/c/pysim/+/43513/comment/6205155b_e216b5ae?usp=em… : PS2, Line 4: read_back_val={'IMSI': '123456', 'IMSI-ACC': '0040'}:{str, hexstr} > Hmm. As far as I can see the changes here only change the formatting. […] This is is just some code tweak in a unit test, I'd appreciate if we can just pass it. Reasoning, if anyone is interested: this here already is the sparate commit. This patch shows that I am only changing the composition of the output without the expexted output files changing: the unit tests still pass with identical output. The point of the change is, when an exception happens, e.g. while implementing a new ConfigurableParameter: before, the error log doesn't show the value for which a parameter failed. This patch makes debugging much easier. the previous code also was quite weird, spaghetti artefact. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38e85ce0902f2ec4db63e158770b6d2cecb2dd30 Gerrit-Change-Number: 43513 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 00:10:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0