October 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: esim/http_json_api.py: support text/plain response Content-Type
by neels 08 Oct '26

08 Oct '26

Attention is currently required from: dexter. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email ) Change subject: esim/http_json_api.py: support text/plain response Content-Type ...................................................................... Patch Set 5: (1 comment) File pySim/esim/http_json_api.py: https://gerrit.osmocom.org/c/pysim/+/42155/comment/2303fe74_66323951?usp=em… : PS5, Line 431: if 'header' in output: > I think you should draw this header check into the conditional branch because when we decode a plain […] This is not matching some plaintext blob. 'output' is a dict, the 'in' operator here looks up a dict key which must be exactly 'header', case sensitive and full match. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Gerrit-Change-Number: 42155 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 23:56:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/92446cb3_3301e201?u… : PS1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't > I can't find it right now, but I think the auto configure options were discussed some year back on t […] Agree with @osmith@sysmocom.de, auto shouldn't be there. File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/fcd32276_13c8c020?u… : PS1, Line 29: osmo-build-dep.sh osmo-trx "" --disable-doxygen --disable-multi-arfcn --without-proxy AFAIU since we are adding new configure flag, we should change the jenkins.sh to be matrix jenkins job to test both --without-proxy here and also building with it (btw why is there no configure flag when building osmocom-bb below? it's because you are using =auto?) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/0a865356_48754716?u… : PS1, Line 484: const struct trxcon_phyif_burst_ind phybi = { it may make sense to get rid of this struct and pass bi directly below? https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/5da2d97f_0d8cc273?u… : PS1, Line 504: const struct trxcon_phyif_burst_req *br) Similarly, maybe pass struct osmo_trxd_burst_req directly here as a param? https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/c443ae39_f001d72d?u… : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff); this won't be transmitted most of the time. Ideally whatever path currently calls osmo_fsm_terminate() should instead be transitioning to a new cleanup state which would flush + send POWEROFF, then when POWEROFF ACK is received free the whole thing. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 19:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: trxcon/trx_if: make struct trx_instance opaque
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43827?usp=email ) Change subject: trxcon/trx_if: make struct trx_instance opaque ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb6ca85dda0ffdc7f3e4cc0f368d74e9c9cab8ed Gerrit-Change-Number: 43827 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 19:39:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trxcon/trx_if: fix stale doc comments on POWERON/RXTUNE/TXTUNE
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43826?usp=email ) Change subject: trxcon/trx_if: fix stale doc comments on POWERON/RXTUNE/TXTUNE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9408ea573598459d47af957577dece883606caa8 Gerrit-Change-Number: 43826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 19:38:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: trxcon/trx_if: refuse POWERON if Rx/Tx frequency is not set
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43825?usp=email ) Change subject: trxcon/trx_if: refuse POWERON if Rx/Tx frequency is not set ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie570432cd6f28fe77d312f80ed53f248af0230c8 Gerrit-Change-Number: 43825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 19:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: refactor the transceiver FSM
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email ) Change subject: trxcon/trx_if: refactor the transceiver FSM ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43824/comment/2adb730f_60266403?u… : PS1, Line 868: .action = trx_fsm_poweron_action, I lack a "st" somewhere so it becomes obvious when seeing the function that it's a state handling one, it happened to me at the start of the file. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I243da047ca606986dbf8ce3cadf69ede4c7227d1 Gerrit-Change-Number: 43824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 19:35:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Create dynamic routes for AS statically configured routing-key
by pespin 08 Oct '26

08 Oct '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43831?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Create dynamic routes for AS statically configured routing-key ...................................................................... Create dynamic routes for AS statically configured routing-key We already do so for routing-keys registered through RKM. Let's do it too for statically configured ones. This makes it easier to configure default routing on an STP, since there's no need to set up "update route" for the most usual cases. If specific routing is required (eg. combined linkset loadsharing use over multiple AS on a given PC), it can still be configured manually using a higher prio in the routing table. The newly created dynamic routes contain the "match_as_routing_key" setting, which means they are only usable to route a given message if its routing label matches the routing-key of the AS. This opens the door to improved traffic forwarding security as well as more fine-grained traffic routing selection based on eg. OPC. So far only matching on DPC and optionaly on OPC is supported. Matching on SI and SSN is left as TODO work for the future. Related: OS#7070 Change-Id: Ie74f4b502d4e5beacbf1ac5cd772b8735ea853ed --- M src/ss7_as.c M src/ss7_as_vty.c M src/ss7_combined_linkset.c M src/ss7_route.c M src/ss7_route.h M src/ss7_vty.c M tests/vty/osmo_stp_route_prio.vty 7 files changed, 76 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/31/43831/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie74f4b502d4e5beacbf1ac5cd772b8735ea853ed Gerrit-Change-Number: 43831 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmo-sigtran[master]: xua_rkm: Add function helpers to set routes for AS route-key
by pespin 08 Oct '26

08 Oct '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: xua_rkm: Add function helpers to set routes for AS route-key ...................................................................... xua_rkm: Add function helpers to set routes for AS route-key Those will be used in follow-up commit introducing automatic AS route-key full qualified routes for statically configured AS. Related: OS#7070 Change-Id: I1dd83ae2b0d23c92304476692ef6bd9c2417e454 --- M src/ss7_as.c M src/ss7_as.h M src/xua_rkm.c 3 files changed, 54 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/30/43830/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1dd83ae2b0d23c92304476692ef6bd9c2417e454 Gerrit-Change-Number: 43830 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: cat: Fix alpha identifier
by Hoernchen 08 Oct '26

08 Oct '26

Attention is currently required from: Eric Salem. Hoernchen has posted comments on this change by Eric Salem. ( https://gerrit.osmocom.org/c/pysim/+/43782?usp=email ) Change subject: cat: Fix alpha identifier ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4 Gerrit-Change-Number: 43782 Gerrit-PatchSet: 1 Gerrit-Owner: Eric Salem <ericsalem(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: Eric Salem <ericsalem(a)gmail.com> Gerrit-Comment-Date: Thu, 08 Oct 2026 17:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: refactor the transceiver FSM
by fixeria 08 Oct '26

08 Oct '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email ) Change subject: trxcon/trx_if: refactor the transceiver FSM ...................................................................... Patch Set 1: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43824/comment/e30b234f_f7b17e7b?u… : PS1, Line 858: | S(TRX_ST_POWEROFF), > is poweroff a valid out-state for trx_st_poweroff? Yes, it's basically a loop state transition. We may send a POWEROFF in `TRX_ST_POWEROFF` (and we do on `TRXCON_PHYIF_CMDT_RESET`), and then the response from transceiver triggers loop-transition to `TRX_ST_POWEROFF` (see `trx_ctrl_read_cb()`). -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I243da047ca606986dbf8ce3cadf69ede4c7227d1 Gerrit-Change-Number: 43824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 16:12:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0