October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: 5gc: Improve meaningful encoding of Source NG-RAN Node to Target NG-R...
by fixeria 08 Oct '26

08 Oct '26

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43791?usp=email ) Change subject: 5gc: Improve meaningful encoding of Source NG-RAN Node to Target NG-RAN Node Transparent Container ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I275b1b551e0f9bea479effebef457deb3f750fc4 Gerrit-Change-Number: 43791 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 10:50:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: display (JSON/ASN.1) in ESipa error messages
by dexter 08 Oct '26

08 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43766?usp=email ) Change subject: eIM_Tests: display (JSON/ASN.1) in ESipa error messages ...................................................................... eIM_Tests: display (JSON/ASN.1) in ESipa error messages When there is an unexpected response from the eIM on the ESipa interface, let's add a hint whether it is a conflict with a JSON or ASN.1 encoded message. Related: SYS#8203 Change-Id: Iaf6e4b1f8e4fff5e4a1db7b36b6a62119f8f37b7 --- M eim/eIM_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: dexter: Looks good to me, approved Jenkins Builder: Verified diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index 410fb25..7888885 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -445,7 +445,7 @@ esipa_res := dec_EsipaMessageFromEimToIpa(response_http.response_binary.body); if (not istemplatekind(expected_esipa_res, "omit")) { if (not match(valueof(esipa_res), expected_esipa_res)) { - setverdict(fail, "unexpected response from eIM on ESipa"); + setverdict(fail, "unexpected response (ASN.1) from eIM on ESipa"); } } return esipa_res; @@ -459,7 +459,7 @@ esipa_res := esipa_res_wrap.asn1_pdu; if (not istemplatekind(expected_esipa_res, "omit")) { if (not match(valueof(esipa_res), expected_esipa_res)) { - setverdict(fail, "unexpected response from eIM on ESipa"); + setverdict(fail, "unexpected response (JSON) from eIM on ESipa"); } } return esipa_res; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6e4b1f8e4fff5e4a1db7b36b6a62119f8f37b7 Gerrit-Change-Number: 43766 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: display (JSON/ASN.1) in ESipa error messages
by dexter 08 Oct '26

08 Oct '26

Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43766?usp=email ) Change subject: eIM_Tests: display (JSON/ASN.1) in ESipa error messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf6e4b1f8e4fff5e4a1db7b36b6a62119f8f37b7 Gerrit-Change-Number: 43766 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 08 Oct 2026 10:36:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler: add TODO for missing confirmation code handling
by dexter 08 Oct '26

08 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email ) Change subject: esipa_asn1_handler: add TODO for missing confirmation code handling ...................................................................... esipa_asn1_handler: add TODO for missing confirmation code handling The eIM implementation lacks the handling of a Confirmation Code, let's add a TODO for this. Change-Id: I1265606549f9eb0872c7ea21407d651f34dc9eed --- M src/esipa_asn1_handler.erl 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index f21d89f..b898850 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -121,6 +121,11 @@ % To simplify this we should automate this process by requesting and caching the IpaCapabilities once, % so that we the info within reach when we need it (similar to how we cache signPubKey, see also % mnesia_db_euicc.hrl). + % TODO: Implement Confirmation Code handling: This SM-DP+ does not support the handling of a + % confirmation code. To add support may add another field to the REST API, so that the REST API user + % may supply a confirmation code. Then we would calculate the Confirmation Code hash here and supply it + % with the hashCc field of authenticateClientOkDPEsipa. (the IPAd would then forward the contents of + % hashCc to the eUICC with the PrepareDownloadRequest). AuthenticateClientOkDPEsipa = AuthClntRespEs9#{ profileMetaData => StoreMetadataRequest }, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I1265606549f9eb0872c7ea21407d651f34dc9eed Gerrit-Change-Number: 43816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler: add TODO for missing confirmation code handling
by dexter 08 Oct '26

08 Oct '26

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email ) Change subject: esipa_asn1_handler: add TODO for missing confirmation code handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I1265606549f9eb0872c7ea21407d651f34dc9eed Gerrit-Change-Number: 43816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Oct 2026 10:00:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-eim[master]: es9p_client: use atom undefinedError instead of 127
by dexter 08 Oct '26

08 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43817?usp=email ) Change subject: es9p_client: use atom undefinedError instead of 127 ...................................................................... es9p_client: use atom undefinedError instead of 127 The error code fixed in this patch is passed 1:1 to the REST API. When we put the integer value, the integer becomes visible on the REST API as it is. This means the REST API user gets the number 127 in the result field, where normally should appear the error code as a string. So let's use the atom undefinedError instead of the integer value so that the REST API user gets the string "undefinedError" instead of the number 127. Related: SYS#8203 Change-Id: I70ee698a73a7e57d6818a606b0af81ef455e4348 --- M src/es9p_client.erl 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/17/43817/1 diff --git a/src/es9p_client.erl b/src/es9p_client.erl index 13ca93b..47c9bd4 100644 --- a/src/es9p_client.erl +++ b/src/es9p_client.erl @@ -218,7 +218,7 @@ }, {initiateAuthenticationOk, R}; _ -> - {initiateAuthenticationError, 127} + {initiateAuthenticationError, undefinedError} % TODO: At the moment we only react on "Executed-Success", we should also react on the other status % codes and return an apropriate tuple (in JSON the concept of xyzOk/xyzError members % like we have it in the ASN.1 definition seems not to exist), see also SGP.22, section 6.5.1.4. @@ -268,7 +268,7 @@ }, {authenticateClientOk, R}; _ -> - {authenticateClientError, 127} + {authenticateClientError, undefinedError} % TODO: (see above) end, {authenticateClientResponseEs9, Choice}; @@ -300,7 +300,7 @@ }, {getBoundProfilePackageOk, R}; _ -> - {getBoundProfilePackageError, 127} + {getBoundProfilePackageError, undefinedError} % TODO: (see above) end, {getBoundProfilePackageResponse, Choice}; @@ -325,7 +325,7 @@ % This function has no output data {cancelSessionOk, none}; _ -> - {cancelSessionError, 127} + {cancelSessionError, undefinedError} % TODO: (see above) end, {cancelSessionResponseEs9, Choice}; -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43817?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I70ee698a73a7e57d6818a606b0af81ef455e4348 Gerrit-Change-Number: 43817 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: esipa_asn1_handler: add TODO for missing confirmation code handling
by dexter 08 Oct '26

08 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email ) Change subject: esipa_asn1_handler: add TODO for missing confirmation code handling ...................................................................... esipa_asn1_handler: add TODO for missing confirmation code handling The eIM implementation lacks the handling of a Confirmation Code, let's add a TODO for this. Change-Id: I1265606549f9eb0872c7ea21407d651f34dc9eed --- M src/esipa_asn1_handler.erl 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/16/43816/1 diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index f21d89f..b898850 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -121,6 +121,11 @@ % To simplify this we should automate this process by requesting and caching the IpaCapabilities once, % so that we the info within reach when we need it (similar to how we cache signPubKey, see also % mnesia_db_euicc.hrl). + % TODO: Implement Confirmation Code handling: This SM-DP+ does not support the handling of a + % confirmation code. To add support may add another field to the REST API, so that the REST API user + % may supply a confirmation code. Then we would calculate the Confirmation Code hash here and supply it + % with the hashCc field of authenticateClientOkDPEsipa. (the IPAd would then forward the contents of + % hashCc to the eUICC with the PrepareDownloadRequest). AuthenticateClientOkDPEsipa = AuthClntRespEs9#{ profileMetaData => StoreMetadataRequest }, -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I1265606549f9eb0872c7ea21407d651f34dc9eed Gerrit-Change-Number: 43816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa_json_handler: use atoms as JSON field names
by dexter 08 Oct '26

08 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43818?usp=email ) Change subject: esipa_json_handler: use atoms as JSON field names ...................................................................... esipa_json_handler: use atoms as JSON field names It is sufficient to use atoms as JSON fieldnames. It is not necessary to write the field names as binaries. When using atoms, the code is much easier to read. Related: SYS#8203 Change-Id: I14edb8f60c755dfc8940015fe7c3436fa14e32b1 --- M src/esipa_json_handler.erl 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/18/43818/1 diff --git a/src/esipa_json_handler.erl b/src/esipa_json_handler.erl index 6e55675..aad3929 100644 --- a/src/esipa_json_handler.erl +++ b/src/esipa_json_handler.erl @@ -93,7 +93,7 @@ {initiateAuthenticationOkEsipa, InitiateAuthenticationOkEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, InitiateAuthenticationOkEsipa, absent))}, @@ -146,7 +146,7 @@ {authenticateClientOkDPEsipa, AuthenticateClientOkDPEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, AuthenticateClientOkDPEsipa, absent))}, @@ -201,7 +201,7 @@ {getBoundProfilePackageOkEsipa, GetBoundProfilePackageOkEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, GetBoundProfilePackageOkEsipa, absent))}, @@ -265,7 +265,7 @@ {getEimPackageResponse, {euiccPackageRequest, EuiccPackageRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {euiccPackageRequest, to_base64asn1( @@ -275,7 +275,7 @@ {getEimPackageResponse, {ipaEuiccDataRequest, IpaEuiccDataRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {ipaEuiccDataRequest, to_base64asn1( @@ -285,7 +285,7 @@ {getEimPackageResponse, {profileDownloadTriggerRequest, ProfileDownloadTriggerRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {profileDownloadTriggerRequest, to_base64asn1( @@ -310,7 +310,7 @@ end, join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {eimPackageError, EimPackageErrorInt} ]); @@ -334,7 +334,7 @@ {provideEimPackageResultResponse, {eimAcknowledgements, EimAcknowledgements}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {eimAcknowledgements, to_base64asn1( @@ -344,7 +344,7 @@ {provideEimPackageResultResponse, {emptyResponse, #{}}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); {provideEimPackageResultError, @@ -377,7 +377,7 @@ emptyResponse -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); _ -> @@ -402,7 +402,7 @@ {cancelSessionResponseEsipa, {cancelSessionOk, _CancelSessionOk}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); {cancelSessionResponseEsipa, {cancelSessionError, _CancelSessionError}} -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I14edb8f60c755dfc8940015fe7c3436fa14e32b1 Gerrit-Change-Number: 43818 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: esipa_json_handler: return subjectCode and reasonCode on error
by dexter 08 Oct '26

08 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email ) Change subject: esipa_json_handler: return subjectCode and reasonCode on error ...................................................................... esipa_json_handler: return subjectCode and reasonCode on error When an ESipa request runs into an error, the JSON API only returns a status ("Failed") but no statusCodeData field is returned. This is technically acceptable since the statusCodeData field is an optional field. However, it is common sense that an error response should include a statusCodeData field. So let's at least put a statusCodeData fields with a generic subjectCode and reasonCode field into the response. Let's also add TODO comments and placeholders into the code, so that we can pick this up later to add more specific error codes. (For our concrete implementation the JSON API bindings have no relevance since onomondo-ipa uses the ASN.1 API bindings. This patch is currently only relevant for the TTCN3 testsuite, which requires the presence of the statusCodeData field) Change-Id: I2d836f7f8d8ced10ba0e9880268079a27c804b04 Related: SYS#8203 --- M src/esipa_json_handler.erl 1 file changed, 149 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/19/43819/1 diff --git a/src/esipa_json_handler.erl b/src/esipa_json_handler.erl index aad3929..4311776 100644 --- a/src/esipa_json_handler.erl +++ b/src/esipa_json_handler.erl @@ -123,8 +123,31 @@ maps:get(ctxParams1, InitiateAuthenticationOkEsipa, absent) )} ]); + {initiateAuthenticationResponseEsipa, + {initiateAuthenticationErrorEsipa, _InitiateAuthenticationErrorEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.2 handle_json({<<"/gsma/rsp2/esipa/authenticateClient">>, EsipaReq}) -> @@ -178,8 +201,44 @@ maps:get(hashCc, AuthenticateClientOkDPEsipa, absent) )} ]); + {authenticateClientResponseEsipa, + {authenticateClientOkDSEsipa, _AuthenticateClientOkDSEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); + {authenticateClientResponseEsipa, + {authenticateClientErrorEsipa, _AuthenticateClientErrorEsipa}} -> + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.3 handle_json({<<"/gsma/rsp2/esipa/getBoundProfilePackage">>, EsipaReq}) -> @@ -214,9 +273,29 @@ ]); {getBoundProfilePackageResponseEsipa, {getBoundProfilePackageErrorEsipa, _GetBoundProfilePackageErrorEsipa}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.5 handle_json({<<"/gsma/rsp2/esipa/getEimPackage">>, EsipaReq}) -> @@ -315,7 +394,17 @@ {eimPackageError, EimPackageErrorInt} ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.6 handle_json({<<"/gsma/rsp2/esipa/provideEimPackageResult">>, EsipaReq}) -> @@ -349,9 +438,29 @@ ]); {provideEimPackageResultError, {provideEimPackageResultError, _ProvideEimPackageResultError}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.7 handle_json({<<"/gsma/rsp2/esipa/handleNotification">>, EsipaReq}) -> @@ -381,7 +490,17 @@ }} ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %GSMA SGP.32, section 6.4.1.8 handle_json({<<"/gsma/rsp2/esipa/cancelSession">>, EsipaReq}) -> @@ -406,9 +525,29 @@ }} ]); {cancelSessionResponseEsipa, {cancelSessionError, _CancelSessionError}} -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]); + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]); _ -> - join([{header, #{<<"functionExecutionStatus">> => #{<<"status">> => <<"Failed">>}}}]) + %TODO: Return more specific subjectCode and reasonCode + join([ + {header, #{ + functionExecutionStatus => + #{ + status => <<"Failed">>, + statusCodeData => + #{subjectCode => <<"1">>, reasonCode => <<"1">>} + } + }} + ]) end; %Unsupported request handle_json(Request) -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I2d836f7f8d8ced10ba0e9880268079a27c804b04 Gerrit-Change-Number: 43819 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: Add optional timeout to mapping
by jolly 08 Oct '26

08 Oct '26

Attention is currently required from: lynxis lazus. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email ) Change subject: Add optional timeout to mapping ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Couldn't this be a generic timeout for both mappings (normal and maintenance)? Yes. I changed that. I don't see a use case for normal mappings, but it works for both mappings. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2f7ee24e6c926b65876af2b14da3534555398769 Gerrit-Change-Number: 43746 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 08 Oct 2026 09:15:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0