dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43818?usp=email ) Change subject: esipa_json_handler: use atoms as JSON field names ...................................................................... esipa_json_handler: use atoms as JSON field names It is sufficient to use atoms as JSON fieldnames. It is not necessary to write the field names as binaries. When using atoms, the code is much easier to read. Related: SYS#8203 Change-Id: I14edb8f60c755dfc8940015fe7c3436fa14e32b1 --- M src/esipa_json_handler.erl 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/18/43818/1 diff --git a/src/esipa_json_handler.erl b/src/esipa_json_handler.erl index 6e55675..aad3929 100644 --- a/src/esipa_json_handler.erl +++ b/src/esipa_json_handler.erl @@ -93,7 +93,7 @@ {initiateAuthenticationOkEsipa, InitiateAuthenticationOkEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, InitiateAuthenticationOkEsipa, absent))}, @@ -146,7 +146,7 @@ {authenticateClientOkDPEsipa, AuthenticateClientOkDPEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, AuthenticateClientOkDPEsipa, absent))}, @@ -201,7 +201,7 @@ {getBoundProfilePackageOkEsipa, GetBoundProfilePackageOkEsipa}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {transactionId, to_hex(maps:get(transactionId, GetBoundProfilePackageOkEsipa, absent))}, @@ -265,7 +265,7 @@ {getEimPackageResponse, {euiccPackageRequest, EuiccPackageRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {euiccPackageRequest, to_base64asn1( @@ -275,7 +275,7 @@ {getEimPackageResponse, {ipaEuiccDataRequest, IpaEuiccDataRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {ipaEuiccDataRequest, to_base64asn1( @@ -285,7 +285,7 @@ {getEimPackageResponse, {profileDownloadTriggerRequest, ProfileDownloadTriggerRequest}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {profileDownloadTriggerRequest, to_base64asn1( @@ -310,7 +310,7 @@ end, join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {eimPackageError, EimPackageErrorInt} ]); @@ -334,7 +334,7 @@ {provideEimPackageResultResponse, {eimAcknowledgements, EimAcknowledgements}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }}, {eimAcknowledgements, to_base64asn1( @@ -344,7 +344,7 @@ {provideEimPackageResultResponse, {emptyResponse, #{}}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); {provideEimPackageResultError, @@ -377,7 +377,7 @@ emptyResponse -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); _ -> @@ -402,7 +402,7 @@ {cancelSessionResponseEsipa, {cancelSessionOk, _CancelSessionOk}} -> join([ {header, #{ - <<"functionExecutionStatus">> => #{<<"status">> => <<"Executed-Success">>} + functionExecutionStatus => #{status => <<"Executed-Success">>} }} ]); {cancelSessionResponseEsipa, {cancelSessionError, _CancelSessionError}} -> -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I14edb8f60c755dfc8940015fe7c3436fa14e32b1 Gerrit-Change-Number: 43818 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de>