October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Expand maintenance mapping test with timeout
by jolly 09 Oct '26

09 Oct '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email ) Change subject: RemSIM/server: Expand maintenance mapping test with timeout ...................................................................... RemSIM/server: Expand maintenance mapping test with timeout Expand the previous test by adding a timeout. Instead of removing the maintenance mapping via REST API, wait until timeout and expect the mapping to be removed automatically. Related: SYS#8159 Change-Id: Iab27eb51ef51fafc2cdef8aee7dc96892fb613fd --- M remsim/RemsimServer_Tests.ttcn 1 file changed, 30 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/43839/1 diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 5edee33..28f89b8 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -37,7 +37,8 @@ } /* run a HTTP PUT to add a new slotmap to the remsim-server */ -function f_rsres_post_slotmap(JsSlotmap slotmap, template integer exp_sts := 201, boolean maintenance := false) +function f_rsres_post_slotmap(JsSlotmap slotmap, template integer exp_sts := 201, boolean maintenance := false, + integer tiout := 0) runs on http_CT return HTTPResponse { var charstring body := oct2char(f_enc_JsSlotmap(slotmap)); var HTTPMessage http_resp; @@ -45,6 +46,14 @@ if (maintenance) { url := url & "?maintenance=true"; } + if (tiout > 0) { + if (maintenance) { + url := url & "&"; + } else { + url := url & "?"; + } + url := url & "timeout=" & int2str(tiout); + } http_resp := f_http_transact(url := url, method := "POST", body := body, exp := tr_HTTP_Resp(exp_sts)) return http_resp.response; } @@ -672,7 +681,7 @@ /* Create a regular mapping between client and bank, then override it via maintenance mapping. */ -testcase TC_slotmap_switch_maintenance() runs on test_CT { +function f_TC_slotmap_switch_maintenance(integer tiout := 0) runs on test_CT { var ComponentIdentity rspro_id := valueof(ts_CompId(remsimBankd, testcasename())); var BankSlot bslot := valueof(ts_BankSlot(1, 2)); var ClientSlot cslot1 := valueof(ts_ClientSlot(3, 4)); @@ -719,7 +728,7 @@ /* 2. Create mainenance mapping, while having a regular mapping. */ /* Create a new slotmap via HTTP. It uses the same bankd/slot */ - f_rsres_post_slotmap(sm2, maintenance := true); + f_rsres_post_slotmap(sm2, maintenance := true, tiout := tiout); /* Expect the slotmap to be removed from bank. */ as_rspro_remove_mapping(0, sm1.client, sm1.bank); @@ -744,8 +753,13 @@ /* 3. Delete mainenance mapping while still having regular mapping. */ - /* Delete the maintenance slotmap via REST. */ - f_rsres_delete_slotmap(sm2.bank, maintenance := true); + if (tiout == 0) { + /* Delete the maintenance slotmap via REST. */ + f_rsres_delete_slotmap(sm2.bank, maintenance := true); + } else { + log("Waiting for mapping to time out..."); + f_sleep(int2float(tiout + 2)); + } /* Expect the maintenance slotmap to be removed from bank. */ as_rspro_remove_mapping(0, sm2.client, sm2.bank); @@ -783,6 +797,16 @@ as_rspro_cfg_client_bank(1, ?, tr_IpPort(ts_IPv4("0.0.0.0"), 0)); } +/* Create a regular mapping between client and bank, then override it via maintenance mapping. */ +testcase TC_slotmap_switch_maintenance() runs on test_CT { + f_TC_slotmap_switch_maintenance(); +} + +/* Same as above, but use timeout rather than delete command via rest API to remove maintenance mapping. */ +testcase TC_slotmap_switch_maintenance_timeout() runs on test_CT { + f_TC_slotmap_switch_maintenance(tiout := 10); +} + @@ -813,6 +837,7 @@ execute( TC_slotmap_del_active_client() ); execute( TC_slotmap_add_active_bank() ); execute( TC_slotmap_switch_maintenance() ); + execute( TC_slotmap_switch_maintenance_timeout() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab27eb51ef51fafc2cdef8aee7dc96892fb613fd Gerrit-Change-Number: 43839 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmo-sigtran[master]: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h
by pespin 09 Oct '26

09 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email ) Change subject: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h ...................................................................... xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h Needed for struct osmo_xlm_prim_notify used in header. Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed --- M src/xua_internal.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/37/43837/1 diff --git a/src/xua_internal.h b/src/xua_internal.h index c580c82..2c0658f 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -5,6 +5,7 @@ #include <osmocom/core/tdef.h> #include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/sigtran/sigtran_sap.h> #include "xua_msg.h" #define M3UA_MSG_SIZE 2048 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed Gerrit-Change-Number: 43837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Add missing include mtp_sap.h
by pespin 09 Oct '26

09 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43835?usp=email ) Change subject: sccp_scrc: Add missing include mtp_sap.h ...................................................................... sccp_scrc: Add missing include mtp_sap.h The file uses osmo_mtp_prim_xfer_req_prepend(), which is in mtp_sap.h, but it's not including it. Change-Id: I78f30dee05ff1f29b59ccf6f0ccbfe8d76109fa0 --- M src/sccp_scrc.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/35/43835/1 diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 1e12ffd..f18ce02 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -28,6 +28,7 @@ #include <osmocom/sccp/sccp_types.h> #include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/sigtran/mtp_sap.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> #include <osmocom/sigtran/protocol/sua.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I78f30dee05ff1f29b59ccf6f0ccbfe8d76109fa0 Gerrit-Change-Number: 43835 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sua: Add missing include mtp_sap.h
by pespin 09 Oct '26

09 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43836?usp=email ) Change subject: sua: Add missing include mtp_sap.h ...................................................................... sua: Add missing include mtp_sap.h The file uses MTP_SIO, but didn't include mtp_sap.h, where it is defined. Change-Id: I496ae727bccb667c16ad36c201d74eb81513b511 --- M src/sua.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/36/43836/1 diff --git a/src/sua.c b/src/sua.c index 6972091..37364c5 100644 --- a/src/sua.c +++ b/src/sua.c @@ -35,6 +35,7 @@ #include <osmocom/netif/stream.h> +#include <osmocom/sigtran/mtp_sap.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/protocol/mtp.h> #include <osmocom/sigtran/protocol/sua.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I496ae727bccb667c16ad36c201d74eb81513b511 Gerrit-Change-Number: 43836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: ss7_route_table.h: Add missing forward declarations
by pespin 09 Oct '26

09 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43834?usp=email ) Change subject: ss7_route_table.h: Add missing forward declarations ...................................................................... ss7_route_table.h: Add missing forward declarations Change-Id: I3b8ac78bf61e8478d8d64c28f320205889595e98 --- M src/ss7_route_table.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/34/43834/1 diff --git a/src/ss7_route_table.h b/src/ss7_route_table.h index 98cddab..24b2d9c 100644 --- a/src/ss7_route_table.h +++ b/src/ss7_route_table.h @@ -8,6 +8,8 @@ * SS7 Routing Tables ***********************************************************************/ +struct osmo_ss7_as; +struct osmo_ss7_linkset; struct osmo_ss7_instance; enum osmo_ss7_route_status; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3b8ac78bf61e8478d8d64c28f320205889595e98 Gerrit-Change-Number: 43834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: sccp: Introduce N-NOTICE.ind Reason for return
by pespin 09 Oct '26

09 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43806?usp=email ) Change subject: sccp: Introduce N-NOTICE.ind Reason for return ...................................................................... sccp: Introduce N-NOTICE.ind Reason for return The SCCP-User SAP primitive N-NOTICE.ind carries a "Reason for return" field, described in ITU Q.711 6.2.2.2.4 Reason for return. According to Q.713 A.5 Return cause: "There is a one-to-one mapping between the return cause of UDTS, XUDTS or LUDTS messages and the reason for return in the N-NOTICE primitives". Still, even if the values can be mapped one to one, the SCCP-User field is a field conceptually different than the return cause field sent over the wire in SCCP messages. Hence, add a new enum to sccp_sap.h so that users of SCCP-User can match existing values without having to use unintended sccp_types.h, which holds wire-format SCCP stuff. Related: OS#2601 Change-Id: I492df5b57bdeefc02b334c4a4db3ca346767dc60 --- M TODO-RELEASE M include/osmocom/sccp/sccp_types.h M include/osmocom/sigtran/sccp_sap.h M src/sccp_sap.c M src/sccp_sclc.c 5 files changed, 58 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 22fd2f9..ac06fda 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmocore >1.14.2 new VTY node L_CS7_QOS_CLASS_NODE added libosmo-sigtran added enum osmo_sccp_reset_reason_*, enum osmo_sccp_release_reason_* +libosmo-sigtran added enum osmo_sccp_return_reason diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index ab688b3..8e76568 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -231,7 +231,10 @@ static inline const char *osmo_sccp_release_cause_name(enum sccp_release_cause val) { return get_value_string(osmo_sccp_release_cause_names, val); } -/* ITU-T Q.713, Section 3.12 Return cause */ +/* ITU-T Q.713, Section 3.12 Return cause + * Q.713 A.5 Return cause: "There is a one-to-one mapping between the return + * cause of UDTS, XUDTS or LUDTS messages and the reason for return in the + * N-NOTICE primitives" (Q.711 6.2.2.2.4 Reason for return) */ enum sccp_return_cause { SCCP_RETURN_CAUSE_NO_TRANSLATION_NATURE = 0, SCCP_RETURN_CAUSE_NO_TRANSLATION = 1, diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h index d8ee43e..12bb602 100644 --- a/include/osmocom/sigtran/sccp_sap.h +++ b/include/osmocom/sigtran/sccp_sap.h @@ -198,6 +198,31 @@ OSMO_SCCP_REL_REASON_UNDEFINED = 0x100, }; +/* Q.711 6.2.2.2.4 Reason for return. + * Q.713 A.5 Return cause: "There is a one-to-one mapping between the return + * cause of UDTS, XUDTS or LUDTS messages and the reason for return in the + * N-NOTICE primitives" (ITU-T Q.713, Section 3.12 Return cause) */ +enum osmo_sccp_return_reason { + OSMO_SCCP_RETURN_REASON_NO_TRANSLATION_NATURE = 0, + OSMO_SCCP_RETURN_REASON_NO_TRANSLATION = 1, + OSMO_SCCP_RETURN_REASON_SUBSYSTEM_CONGESTION = 2, + OSMO_SCCP_RETURN_REASON_SUBSYSTEM_FAILURE = 3, + OSMO_SCCP_RETURN_REASON_UNEQUIPPED_USER = 4, + OSMO_SCCP_RETURN_REASON_MTP_FAILURE = 5, + OSMO_SCCP_RETURN_REASON_NETWORK_CONGESTION = 6, + OSMO_SCCP_RETURN_REASON_UNQUALIFIED = 7, + OSMO_SCCP_RETURN_REASON_ERROR_IN_MSG_TRANSPORT = 8, + OSMO_SCCP_RETURN_REASON_ERROR_IN_LOCAL_PROCESSING = 9, + OSMO_SCCP_RETURN_REASON_DEST_CANNOT_PERFORM_REASSEMBLY = 10, + OSMO_SCCP_RETURN_REASON_SCCP_FAILURE = 11, + OSMO_SCCP_RETURN_REASON_HOP_COUNTER_VIOLATION = 12, + OSMO_SCCP_RETURN_REASON_SEGMENTATION_NOT_SUPPORTED = 13, + OSMO_SCCP_RETURN_REASON_SEGMENTATION_FAILURE = 14 +}; +extern const struct value_string osmo_sccp_return_reason_names[]; +static inline const char *osmo_sccp_return_reason_name(enum osmo_sccp_return_reason val) +{ return get_value_string(osmo_sccp_return_reason_names, val); } + /* Q.711 6.3.2.2.5 Signalling point status */ enum osmo_sccp_sp_status { OSMO_SCCP_SP_S_INACCESSIBLE = 1, @@ -320,8 +345,7 @@ struct osmo_scu_notice_param { struct osmo_sccp_addr called_addr; struct osmo_sccp_addr calling_addr; - /* ITU Q.711 6.2.2.2.4 "Reason for return": - * enum sccp_return_cause (ITU Q.713 3.12), as per ITU Q.713 A.5. */ + /* ITU Q.711 6.2.2.2.4 "Reason for return" (enum osmo_sccp_return_reason): */ uint32_t cause; uint32_t importance; /* ITU Q.711 6.2.2.2.6, Q.713 3.19 */ /* user data */ diff --git a/src/sccp_sap.c b/src/sccp_sap.c index 95d2070..d0e0974 100644 --- a/src/sccp_sap.c +++ b/src/sccp_sap.c @@ -506,6 +506,29 @@ } } +/* Q.711 6.2.2.2.4 Reason for return. + * Q.713 A.5 Return cause: "There is a one-to-one mapping between the return + * cause of UDTS, XUDTS or LUDTS messages and the reason for return in the + * N-NOTICE primitives" (ITU-T Q.713, Section 3.12 Return cause) + */ +const struct value_string osmo_sccp_return_reason_names[] = { + { OSMO_SCCP_RETURN_REASON_NO_TRANSLATION_NATURE, "no translation for an address of such nature" }, + { OSMO_SCCP_RETURN_REASON_NO_TRANSLATION, "no translation for this specific address" }, + { OSMO_SCCP_RETURN_REASON_SUBSYSTEM_CONGESTION, "subsystem congestion" }, + { OSMO_SCCP_RETURN_REASON_SUBSYSTEM_FAILURE, "subsystem failure" }, + { OSMO_SCCP_RETURN_REASON_UNEQUIPPED_USER, "unequipped user" }, + { OSMO_SCCP_RETURN_REASON_MTP_FAILURE, "MTP failure" }, + { OSMO_SCCP_RETURN_REASON_NETWORK_CONGESTION, "network congestion" }, + { OSMO_SCCP_RETURN_REASON_UNQUALIFIED, "unqualified" }, + { OSMO_SCCP_RETURN_REASON_ERROR_IN_MSG_TRANSPORT, "error in message transport" }, + { OSMO_SCCP_RETURN_REASON_ERROR_IN_LOCAL_PROCESSING, "error in local processing" }, + { OSMO_SCCP_RETURN_REASON_DEST_CANNOT_PERFORM_REASSEMBLY, "destination cannot perform reassembly" }, + { OSMO_SCCP_RETURN_REASON_SCCP_FAILURE, "SCCP failure" }, + { OSMO_SCCP_RETURN_REASON_HOP_COUNTER_VIOLATION, "hop counter violation" }, + { OSMO_SCCP_RETURN_REASON_SEGMENTATION_NOT_SUPPORTED, "segmentation not supported" }, + { OSMO_SCCP_RETURN_REASON_SEGMENTATION_FAILURE, "segmentation failure" }, + {} +}; /* get the Connection ID of the given SCU primitive */ static uint32_t scu_prim_conn_id(const struct osmo_scu_prim *prim) diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 704c4bb..1d821f0 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -287,6 +287,10 @@ } param->importance = xua_msg_get_u32(xua, SUA_IEI_IMPORTANCE); + /* Q.713 A.5 Return cause: "There is a one-to-one mapping between the + * return cause of UDTS, XUDTS or LUDTS messages and the reason for return in + * the N-NOTICE primitives" + */ param->cause = xua_msg_get_u32(xua, SUA_IEI_CAUSE) & ~SUA_CAUSE_T_MASK; scu = sccp_user_find(inst, param->called_addr.ssn, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I492df5b57bdeefc02b334c4a4db3ca346767dc60 Gerrit-Change-Number: 43806 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: sccp: Introduce N-NOTICE.ind Reason for return
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43806?usp=email ) Change subject: sccp: Introduce N-NOTICE.ind Reason for return ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I492df5b57bdeefc02b334c4a4db3ca346767dc60 Gerrit-Change-Number: 43806 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:15:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new template
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43823?usp=email ) Change subject: SGP32Definitions_Templates: add new template ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e5db6125315d9a77b98a5f089bd350effaaa9ff Gerrit-Change-Number: 43823 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:13:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: esx_header_Types_JSON: add parameters to ts/tr_responseHeader
by jolly 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43822?usp=email ) Change subject: esx_header_Types_JSON: add parameters to ts/tr_responseHeader ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie65532432b24899505e0c51d6714be58cf5f594b Gerrit-Change-Number: 43822 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:11:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Patch Set 1: (3 comments) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/c8f4527b_0d0cbc02?u… : PS1, Line 484: const struct trxcon_phyif_burst_ind phybi = { > it may make sense to get rid of this struct and pass bi directly below? No. PHYIF is an abstract interface of libtrxcon and exists for a reason. It was introduced when we worked on osmo-trx-ms, which does not use the TRXC/TRXD interface at all. This interface shall remain abstract. https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/0f5147ee_a21b07ac?u… : PS1, Line 504: const struct trxcon_phyif_burst_req *br) > Similarly, maybe pass struct osmo_trxd_burst_req directly here as a param? See my comment above. https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/7891c430_ebeaa607?u… : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff); > this won't be transmitted most of the time. […] Actually, the comment is inaccurate (it predates the final state of libosmo-trx) and the API actually does take care of sending pending TRXC message(s) on close()/free(). I'll amend the comment. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:10:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0