Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email )

Change subject: trxcon/trx_if: migrate to libosmo-trx ......................................................................

Patch Set 1:

(3 comments)

File src/host/trxcon/src/trx_if.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/c8f4527b_0d0cbc02?us... : PS1, Line 484: const struct trxcon_phyif_burst_ind phybi = {

it may make sense to get rid of this struct and pass bi directly below?

No. PHYIF is an abstract interface of libtrxcon and exists for a reason. It was introduced when we worked on osmo-trx-ms, which does not use the TRXC/TRXD interface at all. This interface shall remain abstract.

https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/0f5147ee_a21b07ac?us... : PS1, Line 504: const struct trxcon_phyif_burst_req *br)

Similarly, maybe pass struct osmo_trxd_burst_req directly here as a param?

See my comment above.

https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/7891c430_ebeaa607?us... : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);

this won't be transmitted most of the time. […]

Actually, the comment is inaccurate (it predates the final state of libosmo-trx) and the API actually does take care of sending pending TRXC message(s) on close()/free(). I'll amend the comment.