Attention is currently required from: pespin.

View Change

3 comments:

• File src/host/trxcon/src/trx_if.c:

  • Patch Set #1, Line 484: const struct trxcon_phyif_burst_ind phybi = {

    it may make sense to get rid of this struct and pass bi directly below?

    No. PHYIF is an abstract interface of libtrxcon and exists for a reason. It was introduced when we worked on osmo-trx-ms, which does not use the TRXC/TRXD interface at all. This interface shall remain abstract.

  • Patch Set #1, Line 504: const struct trxcon_phyif_burst_req *br)

    Similarly, maybe pass struct osmo_trxd_burst_req directly here as a param?

    See my comment above.

  • Patch Set #1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff);

    this won't be transmitted most of the time. […]

    Actually, the comment is inaccurate (it predates the final state of libosmo-trx) and the API actually does take care of sending pending TRXC message(s) on close()/free(). I'll amend the comment.

To view, visit change 43828. To unsubscribe, or for help writing mail filters, visit settings.