October 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: Add INACTIVE state to slot mapping
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: jolly, lynxis lazus. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43744?usp=email ) Change subject: Add INACTIVE state to slot mapping ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43744?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I95dff90deb965f8198effdd355d45419bb4c2b02 Gerrit-Change-Number: 43744 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:54:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: Add maintenance flag to slot_mapping structure
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: jolly, lynxis lazus. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43743?usp=email ) Change subject: Add maintenance flag to slot_mapping structure ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ibc9f771cda5d3ba94934cb04e00e60acd466e8bf Gerrit-Change-Number: 43743 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:53:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: remove code dup in f_esipa_transceive
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: eIM_Tests: remove code dup in f_esipa_transceive ...................................................................... eIM_Tests: remove code dup in f_esipa_transceive In f_esipa_transceive we check if the response returned from f_esipa_receive is the one we expect. But we can also pass the expected response template to f_esipa_receive and let f_esipa_receive perform the check. Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Related: SYS#8203 --- M eim/eIM_Tests.ttcn 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/43820/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Gerrit-Change-Number: 43820 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: es*_Types_JSON: use ts_responseHeader instead of manual assignments
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: dexter. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43821?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: es*_Types_JSON: use ts_responseHeader instead of manual assignments ...................................................................... es*_Types_JSON: use ts_responseHeader instead of manual assignments The template ts_responseHeader already provides a response header ("Executed-Success") ready to use. Let's use this template instead of assigning the header members indidvidually each time. Related: SYS#8203 Change-Id: Ifcc3ed49053bd737c96cb34ab142b5522d86821c --- M library/euicc/es9p_Types_JSON.ttcn M library/euicc/esipa_Types_JSON.ttcn 2 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/43821/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43821?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcc3ed49053bd737c96cb34ab142b5522d86821c Gerrit-Change-Number: 43821 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: remove code dup in f_esipa_transceive
by dexter 09 Oct '26

09 Oct '26

Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email ) Change subject: eIM_Tests: remove code dup in f_esipa_transceive ...................................................................... Patch Set 2: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820/comment/80a762b9_d522… : PS1, Line 481: var template EsipaMessageFromEimToIpa esipa_res > This var can be removed. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Gerrit-Change-Number: 43820 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:53:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-remsim[master]: Introduce osmo-remsim-client-socket
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: jolly, lynxis lazus. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email ) Change subject: Introduce osmo-remsim-client-socket ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/client/user_socket.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/0dac4e98_160c382b?… : PS3, Line 57: LOGP(DMAIN, LOGL_INFO, "APDU response %s\n", osmo_hexdump(data, len)); APDUs are normal information that should't be logged unless DEBUG is enabled, IMHO -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9eddb60e4e7c3191ca2b340690416b53005f714f Gerrit-Change-Number: 43742 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email ) Change subject: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07a7102b8671482f636fe9e6d41f6d4525f39c85 Gerrit-Change-Number: 43833 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:50:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email ) Change subject: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837/comment/f7dbb944_33cd9… : PS1, Line 9: struct osmo_xlm_prim_notify > Because it's anyway fine to do this way, since xua_internal.h is a private header and sigtran_sap. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed Gerrit-Change-Number: 43837 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: xua_rkm: Add function helpers to set routes for AS route-key
by laforge 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email ) Change subject: xua_rkm: Add function helpers to set routes for AS route-key ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1dd83ae2b0d23c92304476692ef6bd9c2417e454 Gerrit-Change-Number: 43830 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 11:49:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octets...
by dexter 09 Oct '26

09 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email ) Change subject: esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octetstring ...................................................................... esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octetstring The SGP.32 ASN.1 object InitiateAuthenticationOkEsipa defines the member euiccCiPKIdentifierToBeUsed as OCTET STRING. The JSON bindings for ESipa, also handle euiccCiPKIdentifierToBeUsed the same way by encoding/decoding it with BASE64 without further encoding on top. This means that it is not correct to apply an extra enc/dec_SubjectKeyIdentifier function call when encoding/decoding euiccCiPKIdentifierToBeUsed to/from JSON. From the perspective of InitiateAuthenticationOkEsipa, euiccCiPKIdentifierToBeUsed is just a plain octetstring without further context. Related: SYS#8203 Change-Id: I1f38c5a864c168f1fac0742a72b60de2abd25d49 --- M library/euicc/esipa_Types_JSON.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/library/euicc/esipa_Types_JSON.ttcn b/library/euicc/esipa_Types_JSON.ttcn index 132aaa8..18f28ce 100644 --- a/library/euicc/esipa_Types_JSON.ttcn +++ b/library/euicc/esipa_Types_JSON.ttcn @@ -379,7 +379,7 @@ transactionId, dec_ServerSigned1(decode_base64(json_pdu.initiateAuthenticationResponse.serverSigned1)), decode_base64(json_pdu.initiateAuthenticationResponse.serverSignature1), - dec_SubjectKeyIdentifier(decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed)), + decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed), dec_Certificate(decode_base64(json_pdu.initiateAuthenticationResponse.serverCertificate)), matchingId, ctxParams1)); @@ -481,7 +481,7 @@ json_pdu.initiateAuthenticationResponse.serverSignature1 := encode_base64(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.serverSignature1); json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed := - encode_base64(enc_SubjectKeyIdentifier(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.euiccCiPKIdentifierToBeUsed)); + encode_base64(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.euiccCiPKIdentifierToBeUsed); json_pdu.initiateAuthenticationResponse.serverCertificate := encode_base64(enc_Certificate(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.serverCertificate)); if (ispresent(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.matchingId)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f38c5a864c168f1fac0742a72b60de2abd25d49 Gerrit-Change-Number: 43780 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>

1 0