October 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is n...
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43846?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is not implemented ...................................................................... ss7_as_vty: Warn user that AS routing-key filtering based on SSN is not implemented The feature is not yet ready, so better warn the user in case expectancy is the feature to work. Related: OS#7070 Change-Id: I81888ad6b298457d774e15f6eadc5ad1cf3e3f9d --- M src/ss7_as_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 17 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/46/43846/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I81888ad6b298457d774e15f6eadc5ad1cf3e3f9d Gerrit-Change-Number: 43846 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Support AS routing filtering based on its routing-key SI
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Support AS routing filtering based on its routing-key SI ...................................................................... Support AS routing filtering based on its routing-key SI Pass the full ss7_mtp3_rtlabel instead of the generic osmo_ss7_routing_label to combined_linkset() lookup, which contains also the SIO of the message being routed. Then, update ss7_route_is_available_for_rtlabel() -> ss7_route_is_available_for_mtp3_rtlabel() to also take into account the SIO field when figuring out if the message can be routed to an AS. Also update the VTY "route-lookup" command to require an SI from the user, since routing may changed based on it now. Related: OS#7070 Change-Id: Iec4af5d9a3607747006c26e2baa61ab945f88532 --- M src/ss7_combined_linkset.c M src/ss7_combined_linkset.h M src/ss7_route.c M src/ss7_route.h M src/ss7_route_table.c M src/ss7_vty.c M tests/ss7/ss7_test.err M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 10 files changed, 55 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/45/43845/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iec4af5d9a3607747006c26e2baa61ab945f88532 Gerrit-Change-Number: 43845 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: ss7_as_vty: Add missing MTP SI value strings
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43843?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ss7_as_vty: Add missing MTP SI value strings ...................................................................... ss7_as_vty: Add missing MTP SI value strings Change-Id: Iaeca51082c95a835f01b79b3193896a9fa95d45a --- M src/ss7_as_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 3 files changed, 19 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/43/43843/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iaeca51082c95a835f01b79b3193896a9fa95d45a Gerrit-Change-Number: 43843 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h
by pespin 09 Oct '26

09 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email ) Change subject: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h ...................................................................... xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h Needed for struct osmo_xlm_prim_notify used in header. Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed --- M src/xua_internal.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/xua_internal.h b/src/xua_internal.h index c580c82..2c0658f 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -5,6 +5,7 @@ #include <osmocom/core/tdef.h> #include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/sigtran/sigtran_sap.h> #include "xua_msg.h" #define M3UA_MSG_SIZE 2048 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed Gerrit-Change-Number: 43837 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally
by pespin 09 Oct '26

09 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email ) Change subject: mtp_sap.h: Introduce new MTP_SIO helpers and use them internally ...................................................................... mtp_sap.h: Introduce new MTP_SIO helpers and use them internally Change-Id: I07a7102b8671482f636fe9e6d41f6d4525f39c85 --- M TODO-RELEASE M include/osmocom/sigtran/mtp_sap.h M src/m3ua.c M src/tcap_as_loadshare.c 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index ac06fda..a6d47f9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -10,3 +10,4 @@ libosmocore >1.14.2 new VTY node L_CS7_QOS_CLASS_NODE added libosmo-sigtran added enum osmo_sccp_reset_reason_*, enum osmo_sccp_release_reason_* libosmo-sigtran added enum osmo_sccp_return_reason +libosmo-sigtran added MTP_SIO_*() diff --git a/include/osmocom/sigtran/mtp_sap.h b/include/osmocom/sigtran/mtp_sap.h index 1816b2d..3be178a 100644 --- a/include/osmocom/sigtran/mtp_sap.h +++ b/include/osmocom/sigtran/mtp_sap.h @@ -37,7 +37,14 @@ } /* ITU Q.704 14.2 Service information octet. See enum mtp_si_ni00 in mtp.h. */ -#define MTP_SIO(service, net_ind) ((((net_ind) & 0x3) << 6) | ((service) & 0xF)) +#define MTP_SIO_EXT(service, net_ind, mp) \ + ((((net_ind) & 0x3) << 6) | \ + (((mp) & 0x3) << 4) | \ + ((service) & 0xf)) +#define MTP_SIO(service, net_ind) MTP_SIO_EXT(service, net_ind, 0) +#define MTP_SIO_NI(sio) (((sio) >> 6) & 0x3) +#define MTP_SIO_MP(sio) (((sio) >> 4) & 0x3) +#define MTP_SIO_SI(sio) ((sio) & 0xf) struct osmo_mtp_transfer_param { uint32_t opc; diff --git a/src/m3ua.c b/src/m3ua.c index 973e1cd..39272ee 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -526,9 +526,9 @@ { mdh->opc = htonl(param->opc); mdh->dpc = htonl(param->dpc); - mdh->si = param->sio & 0xF; - mdh->ni = (param->sio >> 6) & 0x3; - mdh->mp = (param->sio >> 4) & 0x3; + mdh->si = MTP_SIO_SI(param->sio); + mdh->ni = MTP_SIO_NI(param->sio); + mdh->mp = MTP_SIO_MP(param->sio); mdh->sls = param->sls; } @@ -540,9 +540,7 @@ param->dpc = ntohl(mdh->dpc); param->sls = mdh->sls; /* re-construct SIO */ - param->sio = (mdh->si & 0xF) | - ((mdh->mp & 0x3) << 4) | - ((mdh->ni & 0x3) << 6); + param->sio = MTP_SIO_EXT(mdh->si, mdh->ni, mdh->mp); } struct msgb *m3ua_msgb_alloc(const char *name) diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index b699281..5e8cbb8 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -736,7 +736,7 @@ /* return 0 and asp is set */ int tcap_as_select_asp_loadshare(struct osmo_ss7_asp **asp, struct osmo_ss7_as *as, const struct xua_msg *xua) { - uint8_t service_ind = xua->mtp.sio & 0xF; + uint8_t service_ind = MTP_SIO_SI(xua->mtp.sio); struct xua_msg_part *m3ua_data_ie; struct msgb *sccp_msg; uint8_t *cur; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I07a7102b8671482f636fe9e6d41f6d4525f39c85 Gerrit-Change-Number: 43833 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use proper envtype for --shell
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43848?usp=email ) Change subject: testenv: use proper envtype for --shell ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ef93c452a0696a18e0875e40465ef5c985f6e86 Gerrit-Change-Number: 43848 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 13:46:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use proper envtype for testsuite (no -b)
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43847?usp=email ) Change subject: testenv: use proper envtype for testsuite (no -b) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia44ec060818adcb97038043a9c6a0328c1831a15 Gerrit-Change-Number: 43847 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 13:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add parameters to tr/ts_profileInstallation...
by dexter 09 Oct '26

09 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43849?usp=email ) Change subject: RSPDefinitions_Templates: add parameters to tr/ts_profileInstallationResult ...................................................................... RSPDefinitions_Templates: add parameters to tr/ts_profileInstallationResult The template tr/ts_profileInstallationResult has all parameters hardcoded. To use the template more flexible, let's add parameters. Change-Id: I4578440fc2dc4851d5d068e47952c831f18bf4d9 Related: SYS#8203 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/43849/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 87b3ca5..a5d5b85 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -634,14 +634,16 @@ } } template (present) ProfileInstallationResult -tr_profileInstallationResult := { - profileInstallationResultData := tr_profileInstallationResultData, - euiccSignPIR := ? +tr_profileInstallationResult(template (present) ProfileInstallationResultData profileInstallationResultData := tr_profileInstallationResultData, + template (present) octetstring euiccSignPIR := ?) := { + profileInstallationResultData := profileInstallationResultData, + euiccSignPIR := euiccSignPIR } template (value) ProfileInstallationResult -ts_profileInstallationResult := { - profileInstallationResultData := ts_profileInstallationResultData, - euiccSignPIR := SGP23_EUICC_SIGN_PIR +ts_profileInstallationResult(template (value) ProfileInstallationResultData profileInstallationResultData := ts_profileInstallationResultData, + template (value) octetstring euiccSignPIR := SGP23_EUICC_SIGN_PIR) := { + profileInstallationResultData := profileInstallationResultData, + euiccSignPIR := euiccSignPIR } /* GSMA SGP.22, section 5.6.1 (ES9+) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4578440fc2dc4851d5d068e47952c831f18bf4d9 Gerrit-Change-Number: 43849 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: esipa_Types_JSON: make eimAcknowledgements mandatory
by dexter 09 Oct '26

09 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43850?usp=email ) Change subject: esipa_Types_JSON: make eimAcknowledgements mandatory ...................................................................... esipa_Types_JSON: make eimAcknowledgements mandatory The JSON type JSON_ESipa_ProvideEimPackageResultResponse has only one optional member eimAcknowledgements (next to the mandatory header field, that all message types have in common). In case the eimAcknowledgements member is missing. The JSON_ESipa_ProvideEimPackageResultResponse becomes indistinguishable from JSON_ESipa_EmptyResponse. To make it distinguishable, let's make the eimAcknowledgements mandatory. So that when it is included, the decoder will decode the message as JSON_ESipa_ProvideEimPackageResultResponse and as JSON_ESipa_EmptyResponse otherwise. It is then up to the API user to interpret the response accordingly. Change-Id: I8e151d7570ee9c3293340a5f8e52cfc62c60a018 Related: SYS#8203 --- M library/euicc/esipa_Types_JSON.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/43850/1 diff --git a/library/euicc/esipa_Types_JSON.ttcn b/library/euicc/esipa_Types_JSON.ttcn index 6d027b5..ab9c420 100644 --- a/library/euicc/esipa_Types_JSON.ttcn +++ b/library/euicc/esipa_Types_JSON.ttcn @@ -116,7 +116,7 @@ }; type record JSON_ESipa_ProvideEimPackageResultResponse { JSON_ESx_ResponseHeader header, - charstring eimAcknowledgements optional + charstring eimAcknowledgements /* required to distinct from JSON_ESipa_EmptyResponse */ }; /* GSMA SGP.32, section 6.4.1.7 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8e151d7570ee9c3293340a5f8e52cfc62c60a018 Gerrit-Change-Number: 43850 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: Add missing defaults to ts_otherSignedNotif...
by dexter 09 Oct '26

09 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43852?usp=email ) Change subject: RSPDefinitions_Templates: Add missing defaults to ts_otherSignedNotification ...................................................................... RSPDefinitions_Templates: Add missing defaults to ts_otherSignedNotification The parameters euiccCertificate and eumCertificate have no default value. Change-Id: I83f1b766b20cb43d798046ab6762664e6ec080f9 Related: SYS#8203 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/43852/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index a5d5b85..9c8219a 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -1127,8 +1127,8 @@ template (value) OtherSignedNotification ts_otherSignedNotification(template (value) NotificationMetadata tbsOtherNotification := ts_notificationMetadata, template (value) octetstring euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG, - template (value) Certificate euiccCertificate, - template (value) Certificate eumCertificate) := { + template (value) Certificate euiccCertificate := ts_cert_euicc_nist, + template (value) Certificate eumCertificate := ts_cert_eum_nist) := { tbsOtherNotification := tbsOtherNotification, euiccNotificationSignature := euiccNotificationSignature, euiccCertificate := euiccCertificate, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I83f1b766b20cb43d798046ab6762664e6ec080f9 Gerrit-Change-Number: 43852 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0