October 2026 - gerrit-log - lists.osmocom.org

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/0910cf06_29b7cd51?u… : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff); > If the API takes care, why then sending it explicitly here? Not sure what you mean by "explicitly". `osmo_trx_ep` does not make any assumptions regarding POWERON/POWEROFF, so there's simply no implicit "send POWEROFF on close()" logic. `fi->state == TRX_ST_POWERON` here in `trx_fsm_cleanup_cb()` is actually an abnormal case. It can happen if the L1CTL peer does not shutdown trxcon properly (i.e. does not send `L1CTL_RESET_REQ`) before disconnecting. In this case we (the FSM) enqueue TRXC POWEROFF message, so that we do not leave the transceiver running. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 19:19:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1)
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email ) Change subject: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) ...................................................................... Patch Set 3: (1 comment) File src/host/trxcon/src/trxcon_shim.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43829/comment/25e40ae8_ba3ee457?u… : PS3, Line 241: * with a burst all soft-bits of which are uncertain (50% 0, 50% 1). */ but memset below sets 100% to 0? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Gerrit-Change-Number: 43829 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/e67bedaf_c10c523f?u… : PS1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't > > This will enable the feature for some people who happen to have libosmo-trx-dev installed, and not […] I'm fine with either "yes" or "no", but "auto" should be removed or at least not be the default one. This was already discussed some time ago, and despite other projects may have decided otherwise, we concluded it was better to have a reproducible default independent of installed libraries in a system. File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/8b619239_4661f5e4?u… : PS1, Line 642: osmo_trx_ep_send_ctrl_msg(trx->ep, 0, &cmd_poweroff); > Actually, the comment is inaccurate (it predates the final state of libosmo-trx) and the API actuall […] If the API takes care, why then sending it explicitly here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:43:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: contrib/jenkins.sh: osmocon: enable -Werror and distcheck
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43858?usp=email ) Change subject: contrib/jenkins.sh: osmocon: enable -Werror and distcheck ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43858?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8dff43ae12dca93ab6adb6e0fd09b738389c5d18 Gerrit-Change-Number: 43858 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: osmocon: fix make distcheck: symlink firmware files
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43857?usp=email ) Change subject: osmocon: fix make distcheck: symlink firmware files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43857?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4566d907642375f72ae98a37e0b8193b02981b81 Gerrit-Change-Number: 43857 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: osmocon: fix make distcheck: add .version to EXTRA_DIST
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43856?usp=email ) Change subject: osmocon: fix make distcheck: add .version to EXTRA_DIST ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43856?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib9f2e5541415c1e034783fee8d215f8941e37dc4 Gerrit-Change-Number: 43856 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:38:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: osmocon/osmoload: fix -Werror=old-style-definition
by pespin 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43855?usp=email ) Change subject: osmocon/osmoload: fix -Werror=old-style-definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43855?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31d4131ab43d4a513e46f5cb88008d6a004bb261 Gerrit-Change-Number: 43855 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:38:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1)
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email ) Change subject: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) ...................................................................... Patch Set 2: (2 comments) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/43829/comment/a786ed77_84f99cd4?u… : PS1, Line 49: #define TRXD_PDU_VER_MAX 1 > why not TTRXDv2? Because TRXDv2 requires Tx PDUs to contain modulation and training sequence info. l1sched currently does not expose this information, so we cannot fill it in here. I've added a comment. https://gerrit.osmocom.org/c/osmocom-bb/+/43829/comment/cc92be61_0d9548de?u… : PS1, Line 502: /* XXX: l1sched does not support NOPE.ind */ > why this change here in this commit? Because once TRXDv1 is negotiated, osmo-trx-proxy will start sending NOPE indications to us. It was actually rather easy to add handling of NOPE.ind, so this check is no longer relevant. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Gerrit-Change-Number: 43829 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 18:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1)
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) ...................................................................... trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) Now that trx_if.c is built against libosmo-trx, enable TRXDv1 by negotiating it (SETFORMAT) before every POWERON, since the transceiver may reset its active format back to legacy on the preceding POWEROFF. This significantly improves the ttcn3-bts-test pass/fail ratio in the frequency hopping configuration: TRXDv1 lets the transceiver (osmo-trx-proxy) send us NOPE.ind, which we rely on to keep driving uplink bursts even when no downlink burst was received. Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Related: OS#6638 --- M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon_shim.c 2 files changed, 36 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/43829/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Gerrit-Change-Number: 43829 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by fixeria 09 Oct '26

09 Oct '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... trxcon/trx_if: migrate to libosmo-trx libosmo-trx (part of osmo-trx.git) is a new library providing a more advanced, shared implementation of the TRXC/TRXD protocol, factored out of osmo-trx and osmo-bts-trx. Replace the existing TRXC/TRXD protocol implementation in trx_if.c with it. This reduces code duplication and gives us TRXDv1/v2 support for free. Since this makes libosmo-trx a hard dependency of trx_if.c, gate the trxcon binary itself behind a new --with-trxcon=yes|no|auto configure flag (default auto), so that building the rest of osmocom-bb doesn't force everyone to have libosmo-trx installed; the scheduler/GPRS libraries are unaffected and keep building unconditionally. Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Related: osmo-trx.git I817e394f74a10e3adae4a0b58342c82acdf0794e Related: osmo-trx.git I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Related: OS#6638 --- M contrib/jenkins.sh M debian/control M src/host/trxcon/configure.ac M src/host/trxcon/src/Makefile.am M src/host/trxcon/src/trx_if.c 5 files changed, 240 insertions(+), 449 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/43828/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0