Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email )

Change subject: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) ......................................................................

Patch Set 2:

(2 comments)

File src/host/trxcon/src/trx_if.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/43829/comment/a786ed77_84f99cd4?us... : PS1, Line 49: #define TRXD_PDU_VER_MAX 1

why not TTRXDv2?

Because TRXDv2 requires Tx PDUs to contain modulation and training sequence info. l1sched currently does not expose this information, so we cannot fill it in here. I've added a comment.

https://gerrit.osmocom.org/c/osmocom-bb/+/43829/comment/cc92be61_0d9548de?us... : PS1, Line 502: /* XXX: l1sched does not support NOPE.ind */

why this change here in this commit?

Because once TRXDv1 is negotiated, osmo-trx-proxy will start sending NOPE indications to us. It was actually rather easy to add handling of NOPE.ind, so this check is no longer relevant.