Attention is currently required from: osmith, pespin.

View Change

2 comments:

• File src/host/trxcon/src/trx_if.c:

  • Patch Set #1, Line 49: #define TRXD_PDU_VER_MAX 1

    why not TTRXDv2?

    Because TRXDv2 requires Tx PDUs to contain modulation and training sequence info. l1sched currently does not expose this information, so we cannot fill it in here. I've added a comment.

  • Patch Set #1, Line 502: /* XXX: l1sched does not support NOPE.ind */

    why this change here in this commit?

    Because once TRXDv1 is negotiated, osmo-trx-proxy will start sending NOPE indications to us. It was actually rather easy to add handling of NOPE.ind, so this check is no longer relevant.

To view, visit change 43829. To unsubscribe, or for help writing mail filters, visit settings.