October 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is n...
by osmith 12 Oct '26

12 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43846?usp=email ) Change subject: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is not implemented ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File tests/vty/osmo_stp_test.vty: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43846/comment/9441ac13_acb03… : PS3, Line 676: OsmoSTP(config-cs7-as)# do show cs7 instance 0 asp are the test changes supposed to be in this patch? (if yes, mention why they are changed in the commit message?) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I81888ad6b298457d774e15f6eadc5ad1cf3e3f9d Gerrit-Change-Number: 43846 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 08:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Support AS routing filtering based on its routing-key SI
by osmith 12 Oct '26

12 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email ) Change subject: Support AS routing filtering based on its routing-key SI ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iec4af5d9a3607747006c26e2baa61ab945f88532 Gerrit-Change-Number: 43845 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 08:11:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Create dynamic routes for AS statically configured routing-key
by osmith 12 Oct '26

12 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43831?usp=email ) Change subject: Create dynamic routes for AS statically configured routing-key ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ie74f4b502d4e5beacbf1ac5cd772b8735ea853ed Gerrit-Change-Number: 43831 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 08:08:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: xua_msg: Use new internal struct to carry routing label
by osmith 12 Oct '26

12 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43844?usp=email ) Change subject: xua_msg: Use new internal struct to carry routing label ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/mtp3_hmdt.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43844/comment/f39820c5_b68ac… : PS2, Line 180: prim->u.transfer = xua->mtp; was this removed on purpose? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic7982f38babcc11d740745a04b155de856517504 Gerrit-Change-Number: 43844 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 08:01:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: ss7_as_vty: Add missing MTP SI value strings
by osmith 12 Oct '26

12 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43843?usp=email ) Change subject: ss7_as_vty: Add missing MTP SI value strings ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iaeca51082c95a835f01b79b3193896a9fa95d45a Gerrit-Change-Number: 43843 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 07:50:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use proper envtype for testsuite (no -b)
by osmith 12 Oct '26

12 Oct '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43847?usp=email ) Change subject: testenv: use proper envtype for testsuite (no -b) ...................................................................... testenv: use proper envtype for testsuite (no -b) Fix that the testsuite was always running with the binary_repo envtype, even if running without --binary-repo. This had the effect that PATH was not set correctly to execute test components built with osmo-dev from the testsuite, which broke the ipad testsuite. Fixes: b728a7fb ("testenv: cmd: init_env: split up by envtype") Change-Id: Ia44ec060818adcb97038043a9c6a0328c1831a15 --- M _testenv/testenv/testsuite.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py index b1bd8a8..52886cf 100644 --- a/_testenv/testenv/testsuite.py +++ b/_testenv/testenv/testsuite.py @@ -44,7 +44,8 @@ cache_dir = "podman" if testenv.args.podman else "host" suffix = testenv.cmd.distro_cache_suffix() builddir = os.path.join(testenv.args.cache, cache_dir, f"titan-{titan_version}{suffix}") - path_old = testenv.cmd.generate_env(podman=testenv.args.podman)["PATH"] + envtype = "binary_repo" if testenv.args.binary_repo else "osmo_dev" + path_old = testenv.cmd.generate_env(podman=testenv.args.podman, envtype=envtype)["PATH"] builddir_env = { "BUILDDIR": builddir, "TTCN3_DIR": ttcn3_dir, @@ -155,7 +156,8 @@ if testenv.args.fast: env["TESTENV_FAST"] = "1" - env = testenv.cmd.generate_env(env, testenv.args.podman) + envtype = "binary_repo" if testenv.args.binary_repo else "osmo_dev" + env = testenv.cmd.generate_env(env, testenv.args.podman, envtype) cmd = [start_testsuite, suite, section_data["config"]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia44ec060818adcb97038043a9c6a0328c1831a15 Gerrit-Change-Number: 43847 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use proper envtype for --shell
by osmith 12 Oct '26

12 Oct '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43848?usp=email ) Change subject: testenv: use proper envtype for --shell ...................................................................... testenv: use proper envtype for --shell When using --podman --shell to run an interactive shell after the testsuite is done (for debugging), use the proper envtype depending on --binary-repo being used or not, instead of always assuming the binary-repo envtype. Fixes: b728a7fb ("testenv: cmd: init_env: split up by envtype") Change-Id: I7ef93c452a0696a18e0875e40465ef5c985f6e86 --- M _testenv/testenv/podman.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 7b5e734..f6264d5 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -367,7 +367,14 @@ logging.info("Running interactive shell before stopping container (--shell)") # stdin=None: override stdin=/dev/null, so we can type into the shell - exec_cmd(["bash"], ["-i"], cwd=testenv.testdir.testdir, stdin=None, check=False) + exec_cmd( + ["bash"], + ["-i"], + cwd=testenv.testdir.testdir, + stdin=None, + check=False, + envtype="binary_repo" if testenv.args.binary_repo else "osmo_dev", + ) run_shell_on_stop = False -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ef93c452a0696a18e0875e40465ef5c985f6e86 Gerrit-Change-Number: 43848 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: trau2rtp_gen: add support for compressed CSD per TW-TS-007
by fixeria 11 Oct '26

11 Oct '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/43871?usp=email ) Change subject: trau2rtp_gen: add support for compressed CSD per TW-TS-007 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/43871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If8ae985672b33cf8867c9f2226bd15da719ab2e1 Gerrit-Change-Number: 43871 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 11 Oct 2026 12:51:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: cosmetic: update trau2rtp_gen documentation
by fixeria 11 Oct '26

11 Oct '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/43870?usp=email ) Change subject: cosmetic: update trau2rtp_gen documentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/43870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I83f3964dd747932952d13f1e511f3d049d2a204f Gerrit-Change-Number: 43870 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 11 Oct 2026 12:50:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau2rtp_gen: add support for compressed CSD per TW-TS-007
by falconia 11 Oct '26

11 Oct '26

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/43871?usp=email ) Change subject: trau2rtp_gen: add support for compressed CSD per TW-TS-007 ...................................................................... trau2rtp_gen: add support for compressed CSD per TW-TS-007 trau2rtp_gen utility converts TRAU frames supplied in hex form into RTP payloads also represented in hex form (TW-TS-005), wrapping around osmo_trau2rtp() API. Up until now this program had no support for CSD modes: the default osmo_trau2rtp() output format in these CSD modes is CLEARMODE with 160-byte payloads, which are too big for TW-TS-005. However, osmo_trau2rtp() now also supports the option of TW-TS-007 output format for CSD, and those compressed CSD payloads do fit within the limits of TW-TS-005 hex format. Add support for this compressed form of CSD to trau2rtp_gen. Change-Id: If8ae985672b33cf8867c9f2226bd15da719ab2e1 --- M tests/trau_conv/trau2rtp_gen.c M tests/trau_conv/trau2rtp_gen.notes 2 files changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/71/43871/1 diff --git a/tests/trau_conv/trau2rtp_gen.c b/tests/trau_conv/trau2rtp_gen.c index 0f36d15..fb514a8 100644 --- a/tests/trau_conv/trau2rtp_gen.c +++ b/tests/trau_conv/trau2rtp_gen.c @@ -180,7 +180,7 @@ trau_8k_mode = false; direction = OSMO_TRAU_DIR_UL; - trau2rtp_st.rtp_extensions = 0; + trau2rtp_st.rtp_extensions = OSMO_RTP_EXT_TWTS007; while ((opt = getopt(argc, argv, "8dx")) != EOF) { switch (opt) { case '8': @@ -190,7 +190,7 @@ direction = OSMO_TRAU_DIR_DL; break; case 'x': - trau2rtp_st.rtp_extensions = + trau2rtp_st.rtp_extensions |= OSMO_RTP_EXT_TWTS001 | OSMO_RTP_EXT_TWTS002; break; default: diff --git a/tests/trau_conv/trau2rtp_gen.notes b/tests/trau_conv/trau2rtp_gen.notes index b6b3617..cba97bd 100644 --- a/tests/trau_conv/trau2rtp_gen.notes +++ b/tests/trau_conv/trau2rtp_gen.notes @@ -45,6 +45,10 @@ HRv1 TRAU-16k TS 48.061 sections 5.1.1.1 and 5.1.4.1.1 HRv1 TRAU-8k TS 48.061 sections 5.2.1.1 and 5.2.4.1 +CSD modes are also supported, in both TRAU-16k and TRAU-8k formats, with RTP +output in the compressed format of TW-TS-007. The resulting hex output follows +TW-TS-005 Annex D. + Input format and examples ========================= @@ -110,8 +114,8 @@ At the level of command line utilities, a separate program exists that exercises the AMR-specific TRAU to RTP conversion APIs - see tests/amr/trau2rtp_amr. -No CSD support yet -================== +CSD in TW-TS-007 format +======================= When the input is a TRAU frame in one of CSD modes, the output from osmo_trau2rtp() can be either a 160-byte CLEARMODE payload or a much more @@ -121,9 +125,12 @@ _can_ be represented in TW-TS-005 hex - and the current version of TW-TS-005 spec linked above includes Annex D that specifies such usage. -trau2rtp_gen utility can be extended to enable TW-TS-007 output and thereby add -support for at least one representation of GSM CSD in RTP - but no such -modification has been made yet. +trau2rtp_gen utility always produces output in TW-TS-007 format if the TRAU +frame input is in any of CSD modes. In the case of FR, HR and EFR speech the +presence or absence of -x option selects whether or not the output will include +RTP payload format extensions of TW-TS-001 or TW-TS-002 - but in the case of +CSD, TW-TS-007 output format is used unconditionally because the more standard +alternative of CLEARMODE cannot be supported in this environment. A need may also arise at some point to represent the bloated-but-standard CLEARMODE formats in hex as well. TW-TS-005 cannot be used for that purpose, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/43871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If8ae985672b33cf8867c9f2226bd15da719ab2e1 Gerrit-Change-Number: 43871 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0