lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2026

  • 1 participants
  • 1202 discussions
[XS] Change in libosmo-sigtran[master]: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h
by pespin 09 Oct '26

09 Oct '26
Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email ) Change subject: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837/comment/41b44eba_aa884… : PS1, Line 9: struct osmo_xlm_prim_notify > Why don't you just add a forward declaration? Because it's anyway fine to do this way, since xua_internal.h is a private header and sigtran_sap.h is a public one, so we won't ever have dependency loops problems. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed Gerrit-Change-Number: 43837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:42:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in libosmo-sigtran[master]: xua_rkm: Add function helpers to set routes for AS route-key
by pespin 09 Oct '26

09 Oct '26
Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email ) Change subject: xua_rkm: Add function helpers to set routes for AS route-key ...................................................................... Patch Set 2: (2 comments) File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830/comment/7d614505_1f4d3… : PS2, Line 745: in > ```suggestion […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830/comment/7efdb677_e36e7… : PS2, Line 776: in > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1dd83ae2b0d23c92304476692ef6bd9c2417e454 Gerrit-Change-Number: 43830 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email ) Change subject: xua_internal.h: Add missing include osmocom/sigtran/sigtran_sap.h ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837/comment/9f943f6e_789be… : PS1, Line 9: struct osmo_xlm_prim_notify Why don't you just add a forward declaration? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8e0ae4297ab7591dd4c071b4b36586d91efde7ed Gerrit-Change-Number: 43837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in libosmo-sigtran[master]: sua: Add missing include mtp_sap.h
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43836?usp=email ) Change subject: sua: Add missing include mtp_sap.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I496ae727bccb667c16ad36c201d74eb81513b511 Gerrit-Change-Number: 43836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:31:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: sccp_scrc: Add missing include mtp_sap.h
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43835?usp=email ) Change subject: sccp_scrc: Add missing include mtp_sap.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I78f30dee05ff1f29b59ccf6f0ccbfe8d76109fa0 Gerrit-Change-Number: 43835 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:31:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: ss7_route_table.h: Add missing forward declarations
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43834?usp=email ) Change subject: ss7_route_table.h: Add missing forward declarations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3b8ac78bf61e8478d8d64c28f320205889595e98 Gerrit-Change-Number: 43834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:30:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmo-sigtran[master]: xua_rkm: Add function helpers to set routes for AS route-key
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email ) Change subject: xua_rkm: Add function helpers to set routes for AS route-key ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830/comment/87e8d2ba_be5da… : PS2, Line 745: in ```suggestion /* Add a fully qualified route to routing table based on configured AS routing-key: */ ``` https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830/comment/04bb2b6d_22478… : PS2, Line 776: in ```suggestion /* Remove fully qualified route from routing table based on configured AS routing-key: */ ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1dd83ae2b0d23c92304476692ef6bd9c2417e454 Gerrit-Change-Number: 43830 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:30:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmo-sigtran[master]: as_vty: Support configuring OPC+mask and improve input validation
by fixeria 09 Oct '26

09 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43813?usp=email ) Change subject: as_vty: Support configuring OPC+mask and improve input validation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icd9e43736ea9240060244cebcacba1f8119043a5 Gerrit-Change-Number: 43813 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2026 10:28:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-remsim[master]: Add maintenance mapping support to osmo-remsim-server
by jolly 09 Oct '26

09 Oct '26
Attention is currently required from: lynxis lazus. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Add maintenance mapping support to osmo-remsim-server ...................................................................... Add maintenance mapping support to osmo-remsim-server A normal mapping and a maintenance mapping may share the same bank/slot. In this case the normal mapping will be inactive until the maintenance mapping has been deleted. The maintenance mapping has priority over the normal mapping. If a maintenance mapping share the same bank/slot of an existing normal mapping, the normal mapping is suspended. The maintenance mapping hat priority over the mapping. The following steps are performed: * The maintenance mapping is put into INACTIVE state. * The normal mapping is deleted and put into INACTIVE state. * The maintenance mapping is created. Once the maintenance mapping is removed, the normal mapping is restored. The following steps are performed: * The maintenance mapping is deleted and then removed. * The normal mapping in INACTIVE state is created again. To control the maintenance flag, the rest API is expanded. An optional 'maintenance' tag is added to the URL. Related: SYS#8159 Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434 --- M src/server/rest_api.c M src/server/rspro_server.c M src/slotmap.h 3 files changed, 106 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/45/43745/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434 Gerrit-Change-Number: 43745 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Add test to verify maintenance mapping
by jolly 09 Oct '26

09 Oct '26
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email ) Change subject: RemSIM/server: Add test to verify maintenance mapping ...................................................................... RemSIM/server: Add test to verify maintenance mapping While have a regular mapping, add a maintenance mapping to a different client but to the same bank/slot. Expect the regular mapping to be suspended while the maintenance mapping exist. After maintenance mapping is deleted, expect the regular mapping to be resumed. Related: SYS#8159 Change-Id: I091dfe999b5b3473c67d6874ca31d238ee75b70e --- M remsim/RSRES.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 138 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/43838/1 diff --git a/remsim/RSRES.ttcn b/remsim/RSRES.ttcn index a988b66..7ccd817 100644 --- a/remsim/RSRES.ttcn +++ b/remsim/RSRES.ttcn @@ -61,7 +61,8 @@ UNACKNOWLEDGED, ACTIVE, DELETE_REQ, - DELETING + DELETING, + INACTIVE }; type record JsSlotmap { diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 4dce01f..5edee33 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -37,12 +37,15 @@ } /* run a HTTP PUT to add a new slotmap to the remsim-server */ -function f_rsres_post_slotmap(JsSlotmap slotmap, template integer exp_sts := 201) +function f_rsres_post_slotmap(JsSlotmap slotmap, template integer exp_sts := 201, boolean maintenance := false) runs on http_CT return HTTPResponse { var charstring body := oct2char(f_enc_JsSlotmap(slotmap)); var HTTPMessage http_resp; - http_resp := f_http_transact(url := "/api/backend/v1/slotmaps", method := "POST", - body := body, exp := tr_HTTP_Resp(exp_sts)) + var charstring url := "/api/backend/v1/slotmaps"; + if (maintenance) { + url := url & "?maintenance=true"; + } + http_resp := f_http_transact(url := url, method := "POST", body := body, exp := tr_HTTP_Resp(exp_sts)) return http_resp.response; } @@ -57,12 +60,15 @@ /* run a HTTP DELETE to remove a slotmap from te remsim-server */ -function f_rsres_delete_slotmap(BankSlot bs, template integer exp_sts := 200) +function f_rsres_delete_slotmap(BankSlot bs, template integer exp_sts := 200, boolean maintenance := false) runs on http_CT return HTTPResponse { var HTTPMessage http_resp; var integer slotmap_id := bs.bankId * 65536 + bs.slotNr; - http_resp := f_http_transact(url := "/api/backend/v1/slotmaps/" & int2str(slotmap_id), - method := "DELETE", exp := tr_HTTP_Resp(exp_sts)); + var charstring url := "/api/backend/v1/slotmaps/" & int2str(slotmap_id); + if (maintenance) { + url := url & "?maintenance=true"; + } + http_resp := f_http_transact(url := url, method := "DELETE", exp := tr_HTTP_Resp(exp_sts)); return http_resp.response; } @@ -301,12 +307,16 @@ } -function f_ensure_slotmaps(template JsSlotmaps maps) +function f_ensure_slotmaps(template JsSlotmaps maps, boolean maintenance := false) runs on http_CT { var JsRoot js; + var charstring url := "/api/backend/v1/slotmaps"; /* check that it is actually added */ - js := f_rsres_get("/api/backend/v1/slotmaps"); + if (maintenance) { + url := url & "?maintenance=true"; + } + js := f_rsres_get(url); if (match(js.slotmaps, maps)) { setverdict(pass); } else { @@ -316,16 +326,16 @@ /* verify that exactly only one slotmap exists (the specified one) */ function f_ensure_slotmap_exists_only(template ClientSlot cslot, template BankSlot bslot, - template SlotmapState state := ?) + template SlotmapState state := ?, boolean maintenance := false) runs on http_CT { - f_ensure_slotmaps({ tr_JsSlotmap(bslot, cslot, state) } ); + f_ensure_slotmaps({ tr_JsSlotmap(bslot, cslot, state) }, maintenance); } /* verify that exactly only one slotmap exists (possibly among others) */ function f_ensure_slotmap_exists(template ClientSlot cslot, template BankSlot bslot, - template SlotmapState state := ?) + template SlotmapState state := ?, boolean maintenance := false) runs on http_CT { - f_ensure_slotmaps({ *, tr_JsSlotmap(bslot, cslot, state), * } ); + f_ensure_slotmaps({ *, tr_JsSlotmap(bslot, cslot, state), * }, maintenance); } @@ -661,6 +671,119 @@ } +/* Create a regular mapping between client and bank, then override it via maintenance mapping. */ +testcase TC_slotmap_switch_maintenance() runs on test_CT { + var ComponentIdentity rspro_id := valueof(ts_CompId(remsimBankd, testcasename())); + var BankSlot bslot := valueof(ts_BankSlot(1, 2)); + var ClientSlot cslot1 := valueof(ts_ClientSlot(3, 4)); + var ClientSlot cslot2 := valueof(ts_ClientSlot(5, 6)); + var JsSlotmap sm1 := valueof(ts_JsSlotmap(bslot, cslot1)); + var JsSlotmap sm2 := valueof(ts_JsSlotmap(bslot, cslot2)); + + f_init(); + f_rsres_init(); + + /* Create a band and two clients. */ + f_rspro_init(rspro[0], mp_server_ip, mp_server_port, rspro_id, 0); + rspro[0].rspro_bank_id := bslot.bankId; + rspro[0].rspro_bank_nslots := 8; + f_rspro_connect_client(0); + + rspro_id := valueof(ts_CompId(remsimClient, "client1")); + f_rspro_init(rspro[1], mp_server_ip, mp_server_port, rspro_id, 1); + rspro[1].rspro_client_slot := cslot1; + f_rspro_connect_client(1); + + rspro_id := valueof(ts_CompId(remsimClient, "client2")); + f_rspro_init(rspro[2], mp_server_ip, mp_server_port, rspro_id, 2); + rspro[2].rspro_client_slot := cslot2; + f_rspro_connect_client(2); + + /* 1. Create regular mapping. */ + + /* Create a new slotmap via HTTP. */ + f_rsres_post_slotmap(sm1); + + /* Expect the slotmap to be pushed to bank and ACK it. */ + as_rspro_create_mapping(0, sm1.client, sm1.bank); + + /* An immediate slotmaps check doesn't work. */ + f_sleep(1.0); + + /* Verify that the slotmap exists and is ACTIVE. */ + f_ensure_slotmap_exists_only(sm1.client, sm1.bank, ACTIVE); + + /* Expect the client to be configured to connect to bank. */ + as_rspro_cfg_client_bank(1, sm1.bank, ?); + + /* 2. Create mainenance mapping, while having a regular mapping. */ + + /* Create a new slotmap via HTTP. It uses the same bankd/slot */ + f_rsres_post_slotmap(sm2, maintenance := true); + + /* Expect the slotmap to be removed from bank. */ + as_rspro_remove_mapping(0, sm1.client, sm1.bank); + + /* Verify the slotmap is removed from client by setting IP/port to '0'. */ + as_rspro_cfg_client_bank(1, ?, tr_IpPort(ts_IPv4("0.0.0.0"), 0)); + + /* Expect the maintenance slotmap to be pushed to bank and ACK it. */ + as_rspro_create_mapping(0, sm2.client, sm2.bank); + + /* Expect the second client to be configured to connect to bank. */ + as_rspro_cfg_client_bank(2, sm2.bank, ?); + + /* An immediate slotmaps check doesn't work. */ + f_sleep(1.0); + + /* Verify that the regular slotmap is INACTIVE. */ + f_ensure_slotmap_exists_only(sm1.client, sm1.bank, INACTIVE); + + /* Verify that the maintenance slotmap exists and is ACTIVE. */ + f_ensure_slotmap_exists_only(sm2.client, sm2.bank, ACTIVE, maintenance := true); + + /* 3. Delete mainenance mapping while still having regular mapping. */ + + /* Delete the maintenance slotmap via REST. */ + f_rsres_delete_slotmap(sm2.bank, maintenance := true); + + /* Expect the maintenance slotmap to be removed from bank. */ + as_rspro_remove_mapping(0, sm2.client, sm2.bank); + + /* Verify the maintenance slotmap is removed from client by setting IP/port to '0'. */ + as_rspro_cfg_client_bank(2, ?, tr_IpPort(ts_IPv4("0.0.0.0"), 0)); + + /* Expect the regular INACTIVE slotmap to be pushed to bank and ACK it. */ + as_rspro_create_mapping(0, sm1.client, sm1.bank); + + /* Expect the client to be configured to connect to bank. */ + as_rspro_cfg_client_bank(1, sm1.bank, ?); + + /* An immediate slotmaps check doesn't work. */ + f_sleep(1.0); + + /* Verify that the slotmap exists and is ACTIVE. */ + f_ensure_slotmap_exists_only(sm1.client, sm1.bank, ACTIVE); + + /* 3. Delete regular mapping. */ + + /* delete the slotmap via REST */ + f_rsres_delete_slotmap(sm1.bank); + + /* an immediate slotmaps check doesn't work */ + f_sleep(1.0); + + /* verify the slotmap is gone from REST interface immediately */ + f_ensure_slotmaps({}); + + /* verify the slotmap is removed from bankd */ + as_rspro_remove_mapping(0, sm1.client, sm1.bank); + + /* verify the slotmap is removed from client by setting IP/port to '0' */ + as_rspro_cfg_client_bank(1, ?, tr_IpPort(ts_IPv4("0.0.0.0"), 0)); +} + + /* TODO @@ -689,6 +812,7 @@ execute( TC_slotmap_del_active() ); execute( TC_slotmap_del_active_client() ); execute( TC_slotmap_add_active_bank() ); + execute( TC_slotmap_switch_maintenance() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I091dfe999b5b3473c67d6874ca31d238ee75b70e Gerrit-Change-Number: 43838 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 77
  • 78
  • 79
  • 80
  • 81
  • 82
  • 83
  • ...
  • 121
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.