Attention is currently required from: dexter.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43515?usp=email )
Change subject: personalization: EF_SMSP: keep same length as found in template ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/43515/comment/6cb4cda9_3e471175?usp=ema... : PS2, Line 11: can modify the value in the template without having to patch this code.
I think its more like 42 is a correct length. […]
Done
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/43515/comment/32f4fcd6_96b1c9a8?usp=ema... : PS2, Line 640: #f_smsp.rec_len = 42
If wou want to make i perfect, you can put a space between # and f_smsp....
i like to put no space before commented-out code lines =) but ok