Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email )
Change subject: esim/http_json_api.py: support text/plain response Content-Type
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
I think everything is fine here.
File pySim/esim/http_json_api.py:
https://gerrit.osmocom.org/c/pysim/+/42155/comment/6012328b_31fc517f?usp=ema... :
PS5, Line 431: if 'header' in output:
This is not matching some plaintext blob. […]
Ah, now I get it. Yes its indeed a dict. I somehow thought you were putting plaintext in output directly, but that's not the case.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/42155?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790
Gerrit-Change-Number: 42155
Gerrit-PatchSet: 6
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Fri, 09 Oct 2026 07:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: dexter
pmaier@sysmocom.de