March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: cosmetic: Improve comment with spec references in Cell Selection Para...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email ) Change subject: cosmetic: Improve comment with spec references in Cell Selection Parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 Gerrit-Change-Number: 39832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:11:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bts_vty: drop NL in 'ncc-permitted' commands

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email ) Change subject: bts_vty: drop NL in 'ncc-permitted' commands ...................................................................... bts_vty: drop NL in 'ncc-permitted' commands New line is not needed at the end of the cmdname field. Change-Id: Ic90a817f5e9d0b32bb431420df6a8994a2d87f2d --- M src/osmo-bsc/bts_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1babd4d..6abfbf2 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1467,7 +1467,7 @@ DEFUN_USRATTR(cfg_bts_ncc_permitted_all, cfg_bts_ncc_permitted_all_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), - "ncc-permitted all\n", + "ncc-permitted all", NCC_PERMITTED_STR "Permit all NCCs (default)\n") { @@ -1480,7 +1480,7 @@ DEFUN_USRATTR(cfg_bts_ncc_permitted, cfg_bts_ncc_permitted_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), - "ncc-permitted <1-8> [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>]\n", + "ncc-permitted <1-8> [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>]", NCC_PERMITTED_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic90a817f5e9d0b32bb431420df6a8994a2d87f2d Gerrit-Change-Number: 39838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bts_vty: drop NL in 'ncc-permitted' commands

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email ) Change subject: bts_vty: drop NL in 'ncc-permitted' commands ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic90a817f5e9d0b32bb431420df6a8994a2d87f2d Gerrit-Change-Number: 39838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 23:20:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bts_vty: drop NL in 'ncc-permitted' commands

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email ) Change subject: bts_vty: drop NL in 'ncc-permitted' commands ...................................................................... bts_vty: drop NL in 'ncc-permitted' commands New line is not needed at the end of the cmdname field. Change-Id: Ic90a817f5e9d0b32bb431420df6a8994a2d87f2d --- M src/osmo-bsc/bts_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/39838/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1babd4d..6abfbf2 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1467,7 +1467,7 @@ DEFUN_USRATTR(cfg_bts_ncc_permitted_all, cfg_bts_ncc_permitted_all_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), - "ncc-permitted all\n", + "ncc-permitted all", NCC_PERMITTED_STR "Permit all NCCs (default)\n") { @@ -1480,7 +1480,7 @@ DEFUN_USRATTR(cfg_bts_ncc_permitted, cfg_bts_ncc_permitted_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), - "ncc-permitted <1-8> [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>]\n", + "ncc-permitted <1-8> [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>] [<1-8>]", NCC_PERMITTED_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR NCC_STR) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic90a817f5e9d0b32bb431420df6a8994a2d87f2d Gerrit-Change-Number: 39838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Document missing CBQ3 optional field in SI4ro

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email ) Change subject: cosmetic: Document missing CBQ3 optional field in SI4ro ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I52705a6a3422911698547c101329f7d01176e634 Gerrit-Change-Number: 39836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 19:59:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve spec references of fields/structs related to SI3ro ...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email ) Change subject: cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 19:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve comment with spec ref in RACH Control Parameters

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email ) Change subject: cosmetic: Improve comment with spec ref in RACH Control Parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 19:57:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: cosmetic: Improve documentation with spec references about several pa...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email ) Change subject: cosmetic: Improve documentation with spec references about several parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 Gerrit-Change-Number: 39837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 19:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: vty: Improve cmd 'cell barred' description

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email ) Change subject: vty: Improve cmd 'cell barred' description ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 19:54:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: cosmetic: Improve documentation with spec references about several pa...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email ) Change subject: cosmetic: Improve documentation with spec references about several parameters ...................................................................... cosmetic: Improve documentation with spec references about several parameters Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 --- M src/osmo-bsc/bts_vty.c M src/osmo-bsc/system_information.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/39837/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index b25e211..a98e45e 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1315,6 +1315,7 @@ return CMD_SUCCESS; } +/* MS_TXPWR_MAX_CCH, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_ms_max_power, cfg_bts_ms_max_power_cmd, X(BSC_VTY_ATTR_NEW_LCHAN), @@ -1333,6 +1334,7 @@ #define CELL_STR "Cell Parameters\n" +/* CELL_RESELECT_HYSTERESIS, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_resel_hyst, cfg_bts_cell_resel_hyst_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1348,6 +1350,7 @@ return CMD_SUCCESS; } +/* RXLEV_ACCESS_MIN, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_rxlev_acc_min, cfg_bts_rxlev_acc_min_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1364,11 +1367,12 @@ return CMD_SUCCESS; } +/* CELL_BAR_QUALIFY, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_bar_qualify, cfg_bts_cell_bar_qualify_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), "cell bar qualify (0|1)", - CELL_STR "Cell Bar Qualify\n" "Cell Bar Qualify\n" + CELL_STR "Cell Bar Qualify (CELL_BAR_QUALIFY)\n" "Cell Bar Qualify (CELL_BAR_QUALIFY)\n" "Set CBQ to 0\n" "Set CBQ to 1\n") { struct gsm_bts *bts = vty->index; @@ -1379,6 +1383,7 @@ return CMD_SUCCESS; } +/* CELL_RESELECT_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_resel_ofs, cfg_bts_cell_resel_ofs_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1395,6 +1400,7 @@ return CMD_SUCCESS; } +/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_temp_ofs, cfg_bts_temp_ofs_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1411,6 +1417,7 @@ return CMD_SUCCESS; } +/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_temp_ofs_inf, cfg_bts_temp_ofs_inf_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1427,6 +1434,7 @@ return CMD_SUCCESS; } +/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_penalty_time, cfg_bts_penalty_time_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1443,6 +1451,7 @@ return CMD_SUCCESS; } +/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_penalty_time_rsvd, cfg_bts_penalty_time_rsvd_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index cc2e788..b438a49 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1041,7 +1041,7 @@ si_info.early_cm_restrict_3g = !bts->early_classmark_allowed_3g; /* SI3 Rest Octets (10.5.2.34), containing - CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME + CELL_BAR_QUALIFY/CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME Power Offset, 2ter Indicator, Early Classmark Sending, Scheduling if and WHERE, GPRS Indicator, SI13 position */ rc = osmo_gsm48_rest_octets_si3_encode(si3->rest_octets, &si_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 Gerrit-Change-Number: 39837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025