March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: cosmetic: Document missing CBQ3 optional field in SI4ro

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email ) Change subject: cosmetic: Document missing CBQ3 optional field in SI4ro ...................................................................... cosmetic: Document missing CBQ3 optional field in SI4ro Change-Id: I52705a6a3422911698547c101329f7d01176e634 --- M src/gsm/gsm48_rest_octets.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/39836/1 diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 02469a7..ddcd258 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -748,6 +748,11 @@ } else { bitvec_set_bit(&bv, L); } + + /* TODO: + * {L | H < CBQ3 : bit (2) > "Cell Bar Qualify 3" in TS 44.018 Table 10.5.2.11.1 + * {0 | 1 < SI13alt Position : bit >}} ; + */ } else { /* L and break indicator */ bitvec_set_bit(&bv, L); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I52705a6a3422911698547c101329f7d01176e634 Gerrit-Change-Number: 39836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve spec references of fields/structs related to SI3ro ...

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro ...................................................................... cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae --- M include/osmocom/gsm/gsm48_rest_octets.h M src/gsm/gsm48_rest_octets.c 2 files changed, 18 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/39835/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve spec references of fields/structs related to SI3ro ...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email ) Change subject: cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro ...................................................................... cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae --- M include/osmocom/gsm/gsm48_rest_octets.h 1 file changed, 15 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/39835/1 diff --git a/include/osmocom/gsm/gsm48_rest_octets.h b/include/osmocom/gsm/gsm48_rest_octets.h index cdb2e80..d8e52be 100644 --- a/include/osmocom/gsm/gsm48_rest_octets.h +++ b/include/osmocom/gsm/gsm48_rest_octets.h @@ -60,30 +60,34 @@ int osmo_gsm48_rest_octets_si6_encode(uint8_t *data, const struct osmo_gsm48_si6_ro_info *in); +/* 3GPP TS 44.018 Table 10.5.2.34.1 (Optional) "Selection Parameters" */ struct osmo_gsm48_si_selection_params { - uint16_t penalty_time:5, - temp_offs:3, - cell_resel_off:6, - cbq:1, + uint16_t penalty_time:5, /* PENALTY_TIME */ + temp_offs:3, /* TEMPORARY_OFFSET */ + cell_resel_off:6, /* CELL_RESELECT_OFFSET */ + cbq:1, /* CELL_BAR_QUALIFY (CBQ) */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.34.1 "Optional Power offset" */ struct osmo_gsm48_si_power_offset { - uint8_t power_offset:2, + uint8_t power_offset:2, /* POWER OFFSET */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.34.1 "GPRS Indicator" */ struct osmo_gsm48_si3_gprs_ind { - uint8_t si13_position:1, - ra_colour:3, + uint8_t si13_position:1, /* SI13 POSITION */ + ra_colour:3, /* RA COLOUR */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.35.1 "LSA Parameters" */ struct osmo_gsm48_lsa_params { - uint32_t prio_thr:3, - lsa_offset:3, - mcc:12, - mnc:12; + uint32_t prio_thr:3, /* PRIO_THR */ + lsa_offset:3, /* LSA_OFFSET */ + mcc:12, /* MCC */ + mnc:12; /* MNC */ unsigned int present; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae Gerrit-Change-Number: 39835 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/f556d457_78d598a4?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; > > Before, we were doing it in the branch TLVP_PRES_LEN() ... […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:49:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: vty: Improve cmd 'cell barred' description

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email ) Change subject: vty: Improve cmd 'cell barred' description ...................................................................... vty: Improve cmd 'cell barred' description With references and keywords from specs (TS 44.018 Table 10.5.2.29.1). Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d --- M src/osmo-bsc/bts_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/39834/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1babd4d..b25e211 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1211,10 +1211,10 @@ cfg_bts_cell_barred_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), "cell barred (0|1)", - "Should this cell be barred from access?\n" - "Should this cell be barred from access?\n" - "Cell should NOT be barred\n" - "Cell should be barred\n") + "Should this cell be barred from access? (CELL_BAR_ACCESS)\n" + "Should this cell be barred from access? (CELL_BAR_ACCESS)\n" + "The cell is not barred, see 3GPP TS 23.022\n" + "The cell is barred, see 3GPP TS 23.022\n") { struct gsm_bts *bts = vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/9b54eee8_3c65eb47?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; > Before, we were doing it in the branch TLVP_PRES_LEN() ... ``` /* Initialize MS Power Control defaults */ lchan->ms_power_ctrl = (struct lchan_power_ctrl_state) { .max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0), .current = lchan->ms_power_ctrl.max, }; ``` As explained in COMMIT_MSG, the intention was to set `current = max`. Before `75162427ad26b9834433757b790a29f4995b9b60`, it was done as follows: ``` /* Initialize MS Power Control defaults */ lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; lchan->ms_power_ctrl.fixed = true; ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:36:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve comment with spec ref in RACH Control Parameters

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email ) Change subject: cosmetic: Improve comment with spec ref in RACH Control Parameters ...................................................................... cosmetic: Improve comment with spec ref in RACH Control Parameters Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/39833/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 35b3427..a919aae 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -634,13 +634,13 @@ #endif } __attribute__((packed)); -/* Chapter 10.5.2.29 */ +/* 3GPP TS 44.018 Chapter 10.5.2.29 "RACH Control Parameters" */ struct gsm48_rach_control { #if OSMO_IS_LITTLE_ENDIAN - uint8_t re :1, - cell_bar :1, - tx_integer :4, - max_trans :2; + uint8_t re :1, /* RE, Call reestablishment allowed */ + cell_bar :1, /* CELL_BAR_ACCESS */ + tx_integer :4, /* Tx-integer */ + max_trans :2; /* Max_Retrans */ uint8_t t2; /* ACC 8-15 barred flags */ uint8_t t3; /* ACC 0-7 barred flags */ #elif OSMO_IS_BIG_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:25:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/b1b5ca6f_efcbed57?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; > I suggest you to check the old code (left side of diff). […] Before, we were doing it in the branch TLVP_PRES_LEN(), but now you are doing it always, that's the difference I'm mentioning. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: power_control: always feed input values to do_avg_algo()

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email ) Change subject: power_control: always feed input values to do_avg_algo() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2ccad1cb0ebbfcce64a93bc81b66db37b1399769 Gerrit-Change-Number: 39831 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:09:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025