March 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (2 comments) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/02cbe73a_6fcfca61?usp… : PS1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); > ok, more initialization here rather than re-set-to-sane-defaults during deactivation. […] Currently we're not really resetting anything during lchan deactivation (we only free() some msgbs, see `lchan_set_state()`). If we fail to initialize a field here, it will hold the value that was assigned during previous activation. This is not nice and I believe we should rework the code to clean things up on deactivation. But for now I just wanted to fix a specific problem. https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/a4334b92_41cac0f6?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; > so this means always the current level becomes max level. […] I suggest you to check the old code (left side of diff). This is exactly what we were doing, except that `lchan->ms_power_ctrl.current` was incorrectly initialized with the old value. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:08:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Improve comment with spec references in Cell Selection Para...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email ) Change subject: cosmetic: Improve comment with spec references in Cell Selection Parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 Gerrit-Change-Number: 39832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:06:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Improve comment with spec references in Cell Selection Para...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email ) Change subject: cosmetic: Improve comment with spec references in Cell Selection Parameters ...................................................................... cosmetic: Improve comment with spec references in Cell Selection Parameters The fields are named using a specific formatting in TS 44.018 10.5.2.4, but use another formatting in eg. TS 45.008. Let's provide both so that a quick grep can match related code. Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/39832/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index f919c2b..35b3427 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -973,12 +973,12 @@ #endif } __attribute__ ((packed)); -/* Section 10.5.2.4 Cell Selection Parameters */ +/* 3GPP TS 44.018 Section 10.5.2.4 Cell Selection Parameters */ struct gsm48_cell_sel_par { #if OSMO_IS_LITTLE_ENDIAN - uint8_t ms_txpwr_max_ccch:5, /* GSM 05.08 MS-TXPWR-MAX-CCCH */ - cell_resel_hyst:3; /* GSM 05.08 CELL-RESELECT-HYSTERESIS */ - uint8_t rxlev_acc_min:6, /* GSM 05.08 RXLEV-ACCESS-MIN */ + uint8_t ms_txpwr_max_ccch:5, /* MS-TXPWR-MAX-CCH, 3GPP TS 45.008 MS_TXPWR_MAX_CCH */ + cell_resel_hyst:3; /* CELL-RESELECT-HYSTERESIS, 3GPP TS 45.008 CELL_RESELECT_HYSTERESIS */ + uint8_t rxlev_acc_min:6, /* RXLEV-ACCESS-MIN, 3GPP TS 45.008 RXLEV_ACCESS_MIN */ neci:1, acs:1; #elif OSMO_IS_BIG_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 Gerrit-Change-Number: 39832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > not quite sure why the build would fail after such a trivial change ading 5 more defines... Looks like some make race condition? Using the default: a4! error: tag OUTPUT_DIRECTORY: Output directory 'doc/vty' does not exist and cannot be created Doxygen version used: 1.9.4 Exiting... touch "doc/libosmovty.tag.prep" make[2]: [Makefile:1357: doc/libosmovty.tag.prep] Error 1 (ignored) touch: cannot touch 'doc/libosmovty.tag.prep': No such file or directory make[2]: *** [Makefile:1358: doc/libosmovty.tag.prep] Error 1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:50:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): fix code formatting

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): fix code formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib22f9b90a5194370d2b5bb768d050cc0b167320e Gerrit-Change-Number: 39828 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: power_control: always feed input values to do_avg_algo()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email ) Change subject: power_control: always feed input values to do_avg_algo() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2ccad1cb0ebbfcce64a93bc81b66db37b1399769 Gerrit-Change-Number: 39831 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/77121fd1_b1553bf2?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; so this means always the current level becomes max level. Are you sure this is correct? You seem to be changing the logic here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39829/comment/55ddd6a4_dbbb1344?usp… : PS1, Line 2068: lchan->ta_ctrl.current = 0; > it's a bit of a question whether we expect all of those valuse to be zero or otherwise sanely defaul […] I also think it may make more sense to do it during lchan init/release, but I'm oen to this approach too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 14:41:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: obs: gerrit_binpkgs: set --allow-unknown-package

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email ) Change subject: obs: gerrit_binpkgs: set --allow-unknown-package ...................................................................... obs: gerrit_binpkgs: set --allow-unknown-package The gerrit_binpkgs.sh script can be used to quickly test building of debian packages in a container even for packages that we don't have in the OBS osmocom repositories. For example I'm currently using it to test-build kamailio packages. Use the --allow-unknown-package argument so build_srcpkg.py doesn't complain if this gets called with a package that isn't a known Osmocom package. Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index 443c33f..f199844 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -37,6 +37,7 @@ echo ":: Building the source package" "$SCRIPTS_OBS_DIR"/build_srcpkg.py \ + --allow-unknown-package \ --docker \ --feed master \ --git-skip-fetch \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 Gerrit-Change-Number: 39826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: obs: gerrit_binpkgs: set --allow-unknown-package

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email ) Change subject: obs: gerrit_binpkgs: set --allow-unknown-package ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I79e89c0d7a73f8b2262fd10a0f7a118aa8351635 Gerrit-Change-Number: 39826 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 08:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025