March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: adding @osmith for the build failure that looks like a race... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:13:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve comment with spec ref in RACH Control Parameters

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email ) Change subject: cosmetic: Improve comment with spec ref in RACH Control Parameters ...................................................................... cosmetic: Improve comment with spec ref in RACH Control Parameters Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index 35b3427..a919aae 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -634,13 +634,13 @@ #endif } __attribute__((packed)); -/* Chapter 10.5.2.29 */ +/* 3GPP TS 44.018 Chapter 10.5.2.29 "RACH Control Parameters" */ struct gsm48_rach_control { #if OSMO_IS_LITTLE_ENDIAN - uint8_t re :1, - cell_bar :1, - tx_integer :4, - max_trans :2; + uint8_t re :1, /* RE, Call reestablishment allowed */ + cell_bar :1, /* CELL_BAR_ACCESS */ + tx_integer :4, /* Tx-integer */ + max_trans :2; /* Max_Retrans */ uint8_t t2; /* ACC 8-15 barred flags */ uint8_t t3; /* ACC 0-7 barred flags */ #elif OSMO_IS_BIG_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve spec references of fields/structs related to SI3ro ...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email ) Change subject: cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro ...................................................................... cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae --- M include/osmocom/gsm/gsm48_rest_octets.h M src/gsm/gsm48_rest_octets.c 2 files changed, 18 insertions(+), 14 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/gsm48_rest_octets.h b/include/osmocom/gsm/gsm48_rest_octets.h index cdb2e80..d8e52be 100644 --- a/include/osmocom/gsm/gsm48_rest_octets.h +++ b/include/osmocom/gsm/gsm48_rest_octets.h @@ -60,30 +60,34 @@ int osmo_gsm48_rest_octets_si6_encode(uint8_t *data, const struct osmo_gsm48_si6_ro_info *in); +/* 3GPP TS 44.018 Table 10.5.2.34.1 (Optional) "Selection Parameters" */ struct osmo_gsm48_si_selection_params { - uint16_t penalty_time:5, - temp_offs:3, - cell_resel_off:6, - cbq:1, + uint16_t penalty_time:5, /* PENALTY_TIME */ + temp_offs:3, /* TEMPORARY_OFFSET */ + cell_resel_off:6, /* CELL_RESELECT_OFFSET */ + cbq:1, /* CELL_BAR_QUALIFY (CBQ) */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.34.1 "Optional Power offset" */ struct osmo_gsm48_si_power_offset { - uint8_t power_offset:2, + uint8_t power_offset:2, /* POWER OFFSET */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.34.1 "GPRS Indicator" */ struct osmo_gsm48_si3_gprs_ind { - uint8_t si13_position:1, - ra_colour:3, + uint8_t si13_position:1, /* SI13 POSITION */ + ra_colour:3, /* RA COLOUR */ present:1; }; +/* 3GPP TS 44.018 Table 10.5.2.35.1 "LSA Parameters" */ struct osmo_gsm48_lsa_params { - uint32_t prio_thr:3, - lsa_offset:3, - mcc:12, - mnc:12; + uint32_t prio_thr:3, /* PRIO_THR */ + lsa_offset:3, /* LSA_OFFSET */ + mcc:12, /* MCC */ + mnc:12; /* MNC */ unsigned int present; }; diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 57c2c99..02469a7 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -605,7 +605,7 @@ return bv.data_len; } -/* Append selection parameters to bitvec */ +/* 3GPP TS 44.018 Table 10.5.2.34.1 (Optional) "Selection Parameters", append to bitvec */ static void append_selection_params(struct bitvec *bv, const struct osmo_gsm48_si_selection_params *sp) { @@ -620,7 +620,7 @@ } } -/* Append power offset to bitvec */ +/* 3GPP TS 44.018 Table 10.5.2.34.1 "Optional Power offset", append to bitvec */ static void append_power_offset(struct bitvec *bv, const struct osmo_gsm48_si_power_offset *po) { @@ -632,7 +632,7 @@ } } -/* Append GPRS indicator to bitvec */ +/* 3GPP TS 44.018 Table 10.5.2.34.1 "GPRS Indicator", append bitvec */ static void append_gprs_ind(struct bitvec *bv, const struct osmo_gsm48_si3_gprs_ind *gi) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Improve comment with spec references in Cell Selection Para...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email ) Change subject: cosmetic: Improve comment with spec references in Cell Selection Parameters ...................................................................... cosmetic: Improve comment with spec references in Cell Selection Parameters The fields are named using a specific formatting in TS 44.018 10.5.2.4, but use another formatting in eg. TS 45.008. Let's provide both so that a quick grep can match related code. Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index f919c2b..35b3427 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -973,12 +973,12 @@ #endif } __attribute__ ((packed)); -/* Section 10.5.2.4 Cell Selection Parameters */ +/* 3GPP TS 44.018 Section 10.5.2.4 Cell Selection Parameters */ struct gsm48_cell_sel_par { #if OSMO_IS_LITTLE_ENDIAN - uint8_t ms_txpwr_max_ccch:5, /* GSM 05.08 MS-TXPWR-MAX-CCCH */ - cell_resel_hyst:3; /* GSM 05.08 CELL-RESELECT-HYSTERESIS */ - uint8_t rxlev_acc_min:6, /* GSM 05.08 RXLEV-ACCESS-MIN */ + uint8_t ms_txpwr_max_ccch:5, /* MS-TXPWR-MAX-CCH, 3GPP TS 45.008 MS_TXPWR_MAX_CCH */ + cell_resel_hyst:3; /* CELL-RESELECT-HYSTERESIS, 3GPP TS 45.008 CELL_RESELECT_HYSTERESIS */ + uint8_t rxlev_acc_min:6, /* RXLEV-ACCESS-MIN, 3GPP TS 45.008 RXLEV_ACCESS_MIN */ neci:1, acs:1; #elif OSMO_IS_BIG_ENDIAN -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 Gerrit-Change-Number: 39832 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Document missing CBQ3 optional field in SI4ro

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email ) Change subject: cosmetic: Document missing CBQ3 optional field in SI4ro ...................................................................... cosmetic: Document missing CBQ3 optional field in SI4ro Change-Id: I52705a6a3422911698547c101329f7d01176e634 --- M src/gsm/gsm48_rest_octets.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 02469a7..ddcd258 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -748,6 +748,11 @@ } else { bitvec_set_bit(&bv, L); } + + /* TODO: + * {L | H < CBQ3 : bit (2) > "Cell Bar Qualify 3" in TS 44.018 Table 10.5.2.11.1 + * {0 | 1 < SI13alt Position : bit >}} ; + */ } else { /* L and break indicator */ bitvec_set_bit(&bv, L); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I52705a6a3422911698547c101329f7d01176e634 Gerrit-Change-Number: 39836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: Document missing CBQ3 optional field in SI4ro

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email ) Change subject: cosmetic: Document missing CBQ3 optional field in SI4ro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I52705a6a3422911698547c101329f7d01176e634 Gerrit-Change-Number: 39836 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:12:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve spec references of fields/structs related to SI3ro ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email ) Change subject: cosmetic: Improve spec references of fields/structs related to SI3ro and SI4ro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I48ac83c5032f47fd9e39a00025b102fb83ced0ae Gerrit-Change-Number: 39835 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:12:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: Improve comment with spec ref in RACH Control Parameters

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email ) Change subject: cosmetic: Improve comment with spec ref in RACH Control Parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I14f0f155c17e97c2fd98755f86acaa81e1c5f9e6 Gerrit-Change-Number: 39833 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:12:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025