March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by fixeria

Attention is currently required from: fixeria, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Mar 2025 10:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Makefile: fix doc/vty race condition It is possible that doxygen is unable to create the "doc/vty" directory, as we have seen in jenkins. Create it before running doxygen as it is done for other doc dirs above, e.g.: rm -rf $(top_builddir)/doc/isdn; mkdir -p $(top_builddir)/doc/isdn Note that the doc/vty dir is expected to exist already inside the source tree, as it contains versioned failes. As I understand it, the error happens when building out-of-tree. Fix for: error: tag OUTPUT_DIRECTORY: Output directory 'doc/vty' does not exist and cannot be created Doxygen version used: 1.9.4 Exiting... touch "doc/libosmovty.tag.prep" make[2]: [Makefile:1357: doc/libosmovty.tag.prep] Error 1 (ignored) touch: cannot touch 'doc/libosmovty.tag.prep': No such file or directory Related: https://gerrit.osmocom.org/c/libosmocore/+/39827/1#message-02393b0dc4323a19… Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 --- M Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/39839/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Looks like some make race condition? […] fix: https://gerrit.osmocom.org/c/libosmocore/+/39839 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Mar 2025 10:22:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Makefile: fix doc/vty race condition It is possible that doxygen is unable to create the "doc/vty" directory, as we have seen in jenkins. Create it before running doxygen as it is done for other doc dirs above, e.g.: rm -rf $(top_builddir)/doc/isdn; mkdir -p $(top_builddir)/doc/isdn Fix for: error: tag OUTPUT_DIRECTORY: Output directory 'doc/vty' does not exist and cannot be created Doxygen version used: 1.9.4 Exiting... touch "doc/libosmovty.tag.prep" make[2]: [Makefile:1357: doc/libosmovty.tag.prep] Error 1 (ignored) touch: cannot touch 'doc/libosmovty.tag.prep': No such file or directory Related: https://gerrit.osmocom.org/c/libosmocore/+/39827/1#message-02393b0dc4323a19… Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 --- M Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/39/39839/1 diff --git a/Makefile.am b/Makefile.am index 8a8f963..7adb00b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -115,6 +115,7 @@ $(top_srcdir)/src/vty/*.c rm -rf $(top_builddir)/doc/vty/html $(top_builddir)/doc/vty/latex rm -rf $(top_builddir)/doc/libosmovty.map + mkdir -p $(top_builddir)/doc/vty -$(DOXYGEN) $(top_builddir)/Doxyfile.vty touch "$@" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: cosmetic: Improve documentation with spec references about several pa...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email ) Change subject: cosmetic: Improve documentation with spec references about several parameters ...................................................................... cosmetic: Improve documentation with spec references about several parameters Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 --- M src/osmo-bsc/bts_vty.c M src/osmo-bsc/system_information.c 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index f18b6c7..b2b1247 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1315,6 +1315,7 @@ return CMD_SUCCESS; } +/* MS_TXPWR_MAX_CCH, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_ms_max_power, cfg_bts_ms_max_power_cmd, X(BSC_VTY_ATTR_NEW_LCHAN), @@ -1333,6 +1334,7 @@ #define CELL_STR "Cell Parameters\n" +/* CELL_RESELECT_HYSTERESIS, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_resel_hyst, cfg_bts_cell_resel_hyst_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1348,6 +1350,7 @@ return CMD_SUCCESS; } +/* RXLEV_ACCESS_MIN, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_rxlev_acc_min, cfg_bts_rxlev_acc_min_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1364,11 +1367,12 @@ return CMD_SUCCESS; } +/* CELL_BAR_QUALIFY, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_bar_qualify, cfg_bts_cell_bar_qualify_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), "cell bar qualify (0|1)", - CELL_STR "Cell Bar Qualify\n" "Cell Bar Qualify\n" + CELL_STR "Cell Bar Qualify (CELL_BAR_QUALIFY)\n" "Cell Bar Qualify (CELL_BAR_QUALIFY)\n" "Set CBQ to 0\n" "Set CBQ to 1\n") { struct gsm_bts *bts = vty->index; @@ -1379,6 +1383,7 @@ return CMD_SUCCESS; } +/* CELL_RESELECT_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_cell_resel_ofs, cfg_bts_cell_resel_ofs_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1395,6 +1400,7 @@ return CMD_SUCCESS; } +/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_temp_ofs, cfg_bts_temp_ofs_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1411,6 +1417,7 @@ return CMD_SUCCESS; } +/* TEMPORARY_OFFSET, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_temp_ofs_inf, cfg_bts_temp_ofs_inf_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1427,6 +1434,7 @@ return CMD_SUCCESS; } +/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_penalty_time, cfg_bts_penalty_time_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), @@ -1443,6 +1451,7 @@ return CMD_SUCCESS; } +/* PENALTY_TIME, 3GPP TS 45.008 and 3GPP TS 44.018 */ DEFUN_USRATTR(cfg_bts_penalty_time_rsvd, cfg_bts_penalty_time_rsvd_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index cc2e788..b438a49 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1041,7 +1041,7 @@ si_info.early_cm_restrict_3g = !bts->early_classmark_allowed_3g; /* SI3 Rest Octets (10.5.2.34), containing - CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME + CELL_BAR_QUALIFY/CBQ, CELL_RESELECT_OFFSET, TEMPORARY_OFFSET, PENALTY_TIME Power Offset, 2ter Indicator, Early Classmark Sending, Scheduling if and WHERE, GPRS Indicator, SI13 position */ rc = osmo_gsm48_rest_octets_si3_encode(si3->rest_octets, &si_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 Gerrit-Change-Number: 39837 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: cosmetic: Improve documentation with spec references about several pa...

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email ) Change subject: cosmetic: Improve documentation with spec references about several parameters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 Gerrit-Change-Number: 39837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 23 Mar 2025 22:20:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: vty: Improve cmd 'cell barred' description

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email ) Change subject: vty: Improve cmd 'cell barred' description ...................................................................... vty: Improve cmd 'cell barred' description With references and keywords from specs (TS 44.018 Table 10.5.2.29.1). Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d --- M src/osmo-bsc/bts_vty.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 6abfbf2..f18b6c7 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1211,10 +1211,10 @@ cfg_bts_cell_barred_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_RSL_LINK), "cell barred (0|1)", - "Should this cell be barred from access?\n" - "Should this cell be barred from access?\n" - "Cell should NOT be barred\n" - "Cell should be barred\n") + "Should this cell be barred from access? (CELL_BAR_ACCESS)\n" + "Should this cell be barred from access? (CELL_BAR_ACCESS)\n" + "The cell is not barred, see 3GPP TS 23.022\n" + "The cell is barred, see 3GPP TS 23.022\n") { struct gsm_bts *bts = vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d Gerrit-Change-Number: 39834 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/3804d919_e8a68230?usp… : PS1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); > Currently we're not really resetting anything during lchan deactivation (we only free() some msgbs, […] TODO: create a ticket, so that we do not forget about this problem. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 23 Mar 2025 18:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: cosmetic: Improve documentation with spec references about several pa...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email ) Change subject: cosmetic: Improve documentation with spec references about several parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7892f79f5143f9b3e6fa3bcaddd11ee2c5302934 Gerrit-Change-Number: 39837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:16:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: vty: Improve cmd 'cell barred' description

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email ) Change subject: vty: Improve cmd 'cell barred' description ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I089974fbdb46ec776aa9f38b8037762fcc04687d Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Mar 2025 06:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025