March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email ) Change subject: protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ...................................................................... protocol/gsm_04_08.h: Add GSM 04.08 message types for SI21/22/23 ... as well as others present in TS 44.018 release 17 Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Related: OS#4473, OS#3831 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index a919aae..aad50d6 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -1617,6 +1617,11 @@ #define GSM48_MT_RR_SYSINFO_18 0x40 #define GSM48_MT_RR_SYSINFO_19 0x41 #define GSM48_MT_RR_SYSINFO_20 0x42 +#define GSM48_MT_RR_SYSINFO_13alt 0x44 +#define GSM48_MT_RR_SYSINFO_2n 0x45 +#define GSM48_MT_RR_SYSINFO_21 0x46 +#define GSM48_MT_RR_SYSINFO_22 0x47 +#define GSM48_MT_RR_SYSINFO_23 0x4f #define GSM48_MT_RR_CHAN_MODE_MODIF 0x10 #define GSM48_MT_RR_STATUS 0x12 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1bb96f3c09b0499c3a76519a49d63c2a30130612 Gerrit-Change-Number: 39827 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: mme: Take into account KSI update by Network

by laforge

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email ) Change subject: mme: Take into account KSI update by Network ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65 Gerrit-Change-Number: 39841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Mar 2025 14:39:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: libosmocore.spec.in: correct license for libosmogb

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email ) Change subject: libosmocore.spec.in: correct license for libosmogb ...................................................................... libosmocore.spec.in: correct license for libosmogb Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 --- M contrib/libosmocore.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index f16f799..98cf726 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -170,7 +170,7 @@ %package -n libosmogb14 Summary: Osmocom GPRS Gb Interface (NS/BSSGP) library -License: AGPL-3.0-or-later +License: GPL-2.0-or-later Group: System/Libraries %description -n libosmogb14 @@ -181,7 +181,7 @@ %package -n libosmogb-devel Summary: Development files for the Osmocom GPRS Gb interface library -License: AGPL-3.0-or-later +License: GPL-2.0-or-later Group: Development/Libraries/C and C++ Requires: libosmocore-devel = %version Requires: libosmogb14 = %version -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 Gerrit-Change-Number: 39840 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: libosmocore.spec.in: correct license for libosmogb

by laforge

Attention is currently required from: daniel, fixeria, lynxis lazus. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email ) Change subject: libosmocore.spec.in: correct license for libosmogb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 Gerrit-Change-Number: 39840 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Mar 2025 14:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: libosmocore.spec.in: correct license for libosmogb

by osmith

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email ) Change subject: libosmocore.spec.in: correct license for libosmogb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 Gerrit-Change-Number: 39840 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Mar 2025 14:30:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: mme: Take into account KSI update by Network

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email ) Change subject: mme: Take into account KSI update by Network ...................................................................... mme: Take into account KSI update by Network Since recently, open5gs updates the KSI received from the UE in order to comply better with 4G Core expectancies. Track assigned KSI in ttcn3 code and update it according to expectancies. Depends: open5gs.git 70310979c58fe186e9eaa06bec9d9a31f24ff7a1 Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65 --- M library/NAS_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 47 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/39841/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index a3e01f7..1ad9268 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -399,8 +399,13 @@ const BIT1 c_NAS_TSC_NATIVE_SEC_CTX := '0'B; const BIT1 c_NAS_TSC_MAPPED_SEC_CTX := '1'B; template (value) NAS_KeySetIdentifierV ts_NAS_KeySetIdentifierV(BIT3 identifier := c_NAS_KEY_SET_ID_NO_KEY, BIT1 tSC := c_NAS_TSC_NATIVE_SEC_CTX) := { - identifier := identifier, - tSC := tSC + identifier := identifier, + tSC := tSC +} +template (present) NAS_KeySetIdentifierV tr_NAS_KeySetIdentifierV(template (present) BIT3 identifier := ?, + template (present) BIT1 tSC := ?) := { + identifier := identifier, + tSC := tSC } /* 8.2.26 Tracking Area Update Accept */ @@ -480,6 +485,7 @@ /* 8.2.29 Tracking Area Update Request */ template (value) PDU_NAS_EPS ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(template (value) EPS_MobileIdentityLV old_guti, + template (value) NAS_KeySetIdentifierV kset_id := ts_NAS_KeySetIdentifierV, template (omit) P_TMSISignatureTV old_ptmsi_sig := omit, template (omit) GUTI_TypeTV old_guti_type := omit, template (omit) NonceTV nonce_ue := omit, @@ -492,7 +498,7 @@ securityHeaderType := c_EPS_SEC_NONE, messageType := '01001000'B, ePSupdateType := ts_EPS_UpdateTypeV, - nasKeySetId := ts_NAS_KeySetIdentifierV, + nasKeySetId := kset_id, oldGUTI := old_guti, nonCurrentNative_nasKeySetId := omit, gprsCipheringKeySequenceNumber := gprs_cksn, @@ -565,7 +571,7 @@ /* 8.2.4 Attach Request */ template (value) PDU_NAS_EPS ts_NAS_AttachRequest(template (value) BIT3 att_type, - template (value) BIT3 kset_id, + template (value) NAS_KeySetIdentifierV kset_id, template (value) EPS_MobileIdentityV mobile_id, template (value) UENetworkCapabilityV ue_net_cap, template (value) octetstring esm_enc) := { @@ -579,10 +585,7 @@ typeOfAttach := att_type, spare := '0'B }, - nasKeySetId := { - identifier := kset_id, - tSC := '1'B - }, + nasKeySetId := kset_id, ePSMobileId := { lengthIndicator := 0, ePS_MobileIdentity := mobile_id @@ -618,7 +621,7 @@ } template (present) PDU_NAS_EPS tr_NAS_AttachRequest(template (present) BIT3 att_type := ?, - template (present) BIT3 kset_id := ?, + template (present) NAS_KeySetIdentifierV kset_id := ?, template (present) EPS_MobileIdentityV mobile_id := ?, template (present) UENetworkCapabilityV ue_net_cap := ?, template (present) octetstring esm_enc := ?) := { @@ -632,10 +635,7 @@ typeOfAttach := att_type, spare := ? }, - nasKeySetId := { - identifier := kset_id, - tSC := ? - }, + nasKeySetId := kset_id, ePSMobileId := { lengthIndicator := ?, ePS_MobileIdentity := mobile_id diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 934a251..cc2e5e9 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -166,7 +166,9 @@ /* copied over from MTC_CT on start of component */ UeParams ue_pars, /* currently used MME (index into enb_pars, S1AP, ...) */ - integer mme_idx + integer mme_idx, + /* Currently set KSI */ + NAS_KeySetIdentifierV kset_id } modulepar { @@ -399,7 +401,8 @@ var ConnHdlrPars pars := { enb_pars := g_enb_pars, ue_pars := g_ue_pars[ue_idx], - mme_idx := 0 + mme_idx := 0, + kset_id := valueof(ts_NAS_KeySetIdentifierV('000'B, c_NAS_TSC_NATIVE_SEC_CTX)) }; return pars; } @@ -567,9 +570,21 @@ private const octetstring c_NAS_defaultAPN := '00'O; +private function f_tr_ConnHdlr_kset_id() runs on ConnHdlr return template (present) NAS_KeySetIdentifierV { + /* KSI not yet set, expect whatever assignment from network: */ + if (g_pars.kset_id.identifier == c_NAS_KEY_SET_ID_NO_KEY) { + return tr_NAS_KeySetIdentifierV(?, ?); + } else { + /* Expect specific kset_id. Upon transmitting it UE->Network, f_attach() + * has updated it to the expected value. */ + return g_pars.kset_id; + } +} private altstep as_s1ap_handle_auth() runs on ConnHdlr { var PDU_NAS_EPS rx_nas; - [] S1AP.receive(tr_NAS_AuthReq) -> value rx_nas { + var template (present) NAS_KeySetIdentifierV kset_id := f_tr_ConnHdlr_kset_id(); + [] S1AP.receive(tr_NAS_AuthReq(kset_id := kset_id)) -> value rx_nas { + g_pars.kset_id := rx_nas.ePS_messages.ePS_MobilityManagement.pDU_NAS_EPS_AuthenticationRequest.nasKeySetId; /* static XRES result as we fixed the HSS RAND value and always have the following RAND: 20080c3818183b522614162c07601d0d AUTN: f11b89a2a8be00001f9c526f3d75d44c @@ -610,11 +625,7 @@ typeOfCiphering := '000'B, spare2 := '0'B }; - var NAS_KeySetIdentifierV kset_id := { - identifier := '000'B, - tSC := '0'B - }; - [] S1AP.receive(tr_NAS_SecModeCmd(alg, kset_id, ?)) { + [] S1AP.receive(tr_NAS_SecModeCmd(alg, f_tr_ConnHdlr_kset_id(), ?)) { /* TODO: apply below integrity and ciphering based on * Security Mode Command field "NAS security algorithms - Selected NAS security algorithms"*/ @@ -1032,7 +1043,7 @@ nas_esm := ts_NAS_PdnConnReq(bearer_id := '0000'B, proc_tid := int2bit(1,8), pdn_type := NAS_PDN_T_IPv4, req_type := '001'B); - nas_emm := ts_NAS_AttachRequest(att_type := '000'B, kset_id := '000'B, mobile_id := mi, + nas_emm := ts_NAS_AttachRequest(att_type := '000'B, kset_id := g_pars.kset_id, mobile_id := mi, ue_net_cap := c_NAS_defaultUeNetCap, esm_enc := enc_PDU_NAS_EPS(valueof(nas_esm))); var template (value) S1AP_PDU tx; @@ -1042,6 +1053,16 @@ p_rrcCause := mo_Signalling); S1AP.send(tx); + /* Expect updated KSI from network following 5G Core standards + *(open5gs.git 70310979c58fe186e9eaa06bec9d9a31f24ff7a1): */ + if (g_pars.kset_id.identifier != c_NAS_KEY_SET_ID_NO_KEY) { + if (g_pars.kset_id.identifier == '110'B) { + g_pars.kset_id.identifier := '000'B; + } else { + g_pars.kset_id.identifier := int2bit(bit2int(g_pars.kset_id.identifier) + 1, 3); + } + } + as_DIA_AuthInfo(); as_s1ap_handle_auth(); alt { @@ -1407,7 +1428,7 @@ var hexstring mcc_mnc := f_convert_plmn(g_pars.enb_pars[g_pars.mme_idx].global_enb_id.pLMNidentity); var EPS_MobileIdentityLV old_guti := valueof(ts_EPS_MobileId_GUTI(mcc_mnc, '0001'O, '01'O, 'AABBCCDD'O)); - nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti); + nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti, g_pars.kset_id); tx := ts_S1AP_InitialUE(p_eNB_value := 0, p_nasPdu := enc_PDU_NAS_EPS(valueof(nas_tau)), p_tAI := ts_enb_S1AP_TAI(g_pars.enb_pars[g_pars.mme_idx]), @@ -1534,6 +1555,7 @@ old_guti := ts_EPS_MobileId_GUTI_(guti_val); nas_tau := ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(old_guti, + g_pars.kset_id, ts_PTMSI_SignatureTV(ptmsi_sig), ts_GUTI_TypeTV(GUTI_TYPE_MAPPED), ts_NonceTV('12345678'O), @@ -1588,6 +1610,8 @@ var ConnHdlrPars pars := f_init_pars(ue_idx := 0); var ConnHdlr vc_conn; + pars.kset_id := valueof(ts_NAS_KeySetIdentifierV(identifier := c_NAS_KEY_SET_ID_NO_KEY, + tSC := c_NAS_TSC_NATIVE_SEC_CTX)); vc_conn := f_start_handler_with_pars(refers(f_TC_ue_cell_reselect_geran_to_eutran), pars); vc_conn.done; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie97788c5d9996370cd3e24cc0ff7c003adff1a65 Gerrit-Change-Number: 39841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: libosmocore.spec.in: correct license for libosmogb

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email ) Change subject: libosmocore.spec.in: correct license for libosmogb ...................................................................... libosmocore.spec.in: correct license for libosmogb Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 --- M contrib/libosmocore.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/39840/1 diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in index f16f799..98cf726 100644 --- a/contrib/libosmocore.spec.in +++ b/contrib/libosmocore.spec.in @@ -170,7 +170,7 @@ %package -n libosmogb14 Summary: Osmocom GPRS Gb Interface (NS/BSSGP) library -License: AGPL-3.0-or-later +License: GPL-2.0-or-later Group: System/Libraries %description -n libosmogb14 @@ -181,7 +181,7 @@ %package -n libosmogb-devel Summary: Development files for the Osmocom GPRS Gb interface library -License: AGPL-3.0-or-later +License: GPL-2.0-or-later Group: Development/Libraries/C and C++ Requires: libosmocore-devel = %version Requires: libosmogb14 = %version -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e68f42188098d5a2d788b824e878ac5f2bb2ec2 Gerrit-Change-Number: 39840 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Makefile: fix doc/vty race condition It is possible that doxygen is unable to create the "doc/vty" directory, as we have seen in jenkins. Create it before running doxygen as it is done for other doc dirs above, e.g.: rm -rf $(top_builddir)/doc/isdn; mkdir -p $(top_builddir)/doc/isdn Note that the doc/vty dir is expected to exist already inside the source tree, as it contains versioned failes. As I understand it, the error happens when building out-of-tree. Fix for: error: tag OUTPUT_DIRECTORY: Output directory 'doc/vty' does not exist and cannot be created Doxygen version used: 1.9.4 Exiting... touch "doc/libosmovty.tag.prep" make[2]: [Makefile:1357: doc/libosmovty.tag.prep] Error 1 (ignored) touch: cannot touch 'doc/libosmovty.tag.prep': No such file or directory Related: https://gerrit.osmocom.org/c/libosmocore/+/39827/1#message-02393b0dc4323a19… Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 --- M Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index 8a8f963..7adb00b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -115,6 +115,7 @@ $(top_srcdir)/src/vty/*.c rm -rf $(top_builddir)/doc/vty/html $(top_builddir)/doc/vty/latex rm -rf $(top_builddir)/doc/libosmovty.map + mkdir -p $(top_builddir)/doc/vty -$(DOXYGEN) $(top_builddir)/Doxyfile.vty touch "$@" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Mar 2025 10:40:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Makefile: fix doc/vty race condition

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email ) Change subject: Makefile: fix doc/vty race condition ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9029059ac60060bdb14f5629f50836166e3afd7 Gerrit-Change-Number: 39839 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Mar 2025 10:39:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2025