Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39852?usp=email )
Change subject: s1gw: disable Nagle for eNB and MME connections
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39852?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id89941659fd2763aad9262b05aa007370424f2c1
Gerrit-Change-Number: 39852
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:19:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email )
Change subject: s1gw: derive altsteps from f_ConnHdlr_rx_s1ap_from_{enb,mme}()
......................................................................
Patch Set 1:
(2 comments)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849/comment/98b29898_95c2… :
PS1, Line 154: [] as_ConnHdlr_s1ap_from_enb(pdu, tr_pdu) {
> Not sure what do you win with this but OK....
The altstep name clearly indicates direction from where the PDU is coming from (from eNB).
With the old naming this was less obvious.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849/comment/f9ea8bb8_a47c… :
PS1, Line 187: as_ConnHdlr_s1ap_from_mme
Here we eliminate the need to use `S1AP_RecvFrom` and get `S1AP_PDU` directly.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8637a8abed0f0152abf2dce63ac28aa90f85bdc7
Gerrit-Change-Number: 39849
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email )
Change subject: s1gw: add UE multiplex component
......................................................................
Patch Set 2:
(1 comment)
File s1gw/S1GW_UEMux.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850/comment/013e617c_032d… :
PS2, Line 3: /* UE Multiplexer, runs on top of ConnHdlr component, dispatches S1AP PDUs
I'm a bit lost on why that's needed here... isn't a ConnHdlr already expected to be an UE? Why not simply having several ConnHdlr?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39850?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I60e6f5d2b9882c27cecd06a2450bda4909c0532a
Gerrit-Change-Number: 39850
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email )
Change subject: s1gw: derive altsteps from f_ConnHdlr_rx_s1ap_from_{enb,mme}()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849/comment/84e7a202_e207… :
PS1, Line 154: [] as_ConnHdlr_s1ap_from_enb(pdu, tr_pdu) {
Not sure what do you win with this but OK....
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8637a8abed0f0152abf2dce63ac28aa90f85bdc7
Gerrit-Change-Number: 39849
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email )
Change subject: library/s1ap: split PDU specific API to S1AP_Utils.ttcn
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File library/S1AP_Utils.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848/comment/c86ba75e_b1fe… :
PS1, Line 1: module S1AP_Utils {
Not willing to block here, but we usually call this "Functions": S1AP_Functions.ttcn
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39848?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id3ba089140093490abd0307addeb5d7287dc5894
Gerrit-Change-Number: 39848
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39847?usp=email )
Change subject: library/s1ap: cosmetic: fix a typo
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39847?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I50aceea2653c426d1f60542dbb6721b8c75ed3fb
Gerrit-Change-Number: 39847
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:12:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, fixeria, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email )
Change subject: mme: Replace TC_s1ap_setup_wrong_plmn with test with different expectancies
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
ping?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3aba3d642e3bc70f08b6e0713514fb8906da775d
Gerrit-Change-Number: 39842
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 26 Mar 2025 12:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No