This patch is for fixing encoding of padding bits according to the 3gpp spec 44.060 section 11, wherein it shall always start with 0 bit followed with spare padding bits.
During introduction of basic EGPRS feature new hex dump messages from a different working network log were used in Unit test. These exposed the issue of incorrect handling of padding bits encoding in osmo-pcu.
Corrections in the existing test vector of rlcmac is also updated. In testsuite tbf appropriate corrections for the Tbftest.err is also done. --- src/csn1.cpp | 7 ++++++- tests/rlcmac/RLCMACTest.cpp | 6 +++--- tests/rlcmac/RLCMACTest.ok | 18 +++++++++--------- tests/tbf/TbfTest.err | 18 +++++++++--------- 4 files changed, 27 insertions(+), 22 deletions(-)
Thank you for patch. Out of curiosity, have you tried to look in wireshark at gsmtap traces before/after patch? I wonder if it interprets things properly - do we need to patch it as well?
On 03/10/2016 09:45 AM, Saurabh Sharan wrote:
This patch is for fixing encoding of padding bits according to the 3gpp spec 44.060 section 11, wherein it shall always start with 0 bit followed with spare padding bits.
During introduction of basic EGPRS feature new hex dump messages from a different working network log were used in Unit test. These exposed the issue of incorrect handling of padding bits encoding in osmo-pcu.
Corrections in the existing test vector of rlcmac is also updated. In testsuite tbf appropriate corrections for the Tbftest.err is also done.
src/csn1.cpp | 7 ++++++- tests/rlcmac/RLCMACTest.cpp | 6 +++--- tests/rlcmac/RLCMACTest.ok | 18 +++++++++--------- tests/tbf/TbfTest.err | 18 +++++++++--------- 4 files changed, 27 insertions(+), 22 deletions(-)
On 10 Mar 2016, at 09:45, Saurabh Sharan Saurabh.Sharan@radisys.com wrote:
Good Morning Saurabh,
This patch is for fixing encoding of padding bits according to the 3gpp spec 44.060 section 11, wherein it shall always start with 0 bit followed with spare padding bits.
<0001-Fix-encoding-of-padding-bits-to-start-with-0-bit.patch>
I have applied this patch and pushed it to master. Could you please use git send-email. I had to manually copy/paste the commit message and I would like to avoid doing this in the future.
thank you
holger
osmocom-net-gprs@lists.osmocom.org
-
Holger Freyther -
Max -
Saurabh Sharan