hi laforge,
just curios about two lines at oml.c:
rlcc->parameter[T_DL_TBF_EXT] = *(uint16_t *)cur * 10; rlcc->parameter[T_UL_TBF_EXT] = *(uint16_t *)cur * 10;
1. isnt it * 2 instead of * 10? i just saw a comment at openbsc for 0, 250 which says: 500. 2. did you forget ntoh(*(uint16_t *)cur)?
regards,
andreas
Hi Andreas, sorry for the delayed response. That mail got somehow missed...
On Tue, Jul 03, 2012 at 08:55:50PM +0200, Andreas Eversberg wrote:
rlcc->parameter[T_DL_TBF_EXT] = *(uint16_t *)cur * 10; rlcc->parameter[T_UL_TBF_EXT] = *(uint16_t *)cur * 10;
- isnt it * 2 instead of * 10?
the parameter is coded in units of 10ms. So in order to get from the wire encoding to milliseconds, we need to multiply by 10.
- did you forget ntoh(*(uint16_t *)cur)?
yes, it seems. I've committed a fix now.
osmocom-net-gprs@lists.osmocom.org
-
Andreas Eversberg -
Harald Welte