Fixes a bug introduced in commit 402cdc. That commit sets direction to zero so setting it to 1 should be done after the call to csnStreamInit().
This issue was discovered by the rlcmac test. --- src/csn1.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/csn1.cpp b/src/csn1.cpp index 7f64823..258f7c9 100644 --- a/src/csn1.cpp +++ b/src/csn1.cpp @@ -544,11 +544,11 @@ csnStreamDecoder(csnStream_t* ar, const CSN_DESCR* pDescr, bitvec *vector, unsig guint8 length = bitvec_read_field(vector, readIndex, length_len);
LOGPC(DCSN1, LOGL_NOTICE, "%s length = %d | ", pDescr->sz , (int)length); - arT.direction = 1; bit_offset += length_len; remaining_bits_len -= length_len;
csnStreamInit(&arT, bit_offset, length); + arT.direction = 1; Status = serialize(&arT, vector, readIndex, pvDATA(data, pDescr->offset));
if (Status >= 0)
On Wed, Jan 15, 2014 at 10:05:26AM +0100, Daniel Willmann wrote:
Hi Ivan,
Fixes a bug introduced in commit 402cdc. That commit sets direction to zero so setting it to 1 should be done after the call to csnStreamInit().
FYI there was a communication issue between Daniel and me. I had asked him to push the patch to "*master". So this fix is already in your master.
holger
Hi Holger,
ok, I understood.
2014/1/15 Holger Hans Peter Freyther hfreyther@sysmocom.de:
On Wed, Jan 15, 2014 at 10:05:26AM +0100, Daniel Willmann wrote:
Hi Ivan,
Fixes a bug introduced in commit 402cdc. That commit sets direction to zero so setting it to 1 should be done after the call to csnStreamInit().
FYI there was a communication issue between Daniel and me. I had asked him to push the patch to "*master". So this fix is already in your master.
holger
--
- Holger Freyther hfreyther@sysmocom.de http://www.sysmocom.de/
=======================================================================
- sysmocom - systems for mobile communications GmbH
- Schivelbeiner Str. 5
- 10439 Berlin, Germany
- Sitz / Registered office: Berlin, HRB 134158 B
- Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte
osmocom-net-gprs@lists.osmocom.org