sgsnemu ignoring Request accepted

List overview All Threads
Download

newer

older

icmp encapsulation

sgsnemu: why --listen and --remote...

Viktor Tsymbalyuk

24 Jan 2018 24 Jan '18

2:37 p.m.

Hello, I continue to play with sgsnemu, and found that it stopped for some reason after "Request accepted". Does sgsnemu working? At my mind problem inside `create_pdp_conf` function . After small changes, I start to see icmp inside gtp tunnel in trace. Please check attachments with console output, patch and pcap. May be I has wrong understanding.

-- Viktor

Attachments:

sgsnemu_orig.pcap (application/octet-stream — 816 bytes)
console_output.md (text/plain — 3.9 KB)
patch_create_pdp_conf.patch (text/plain — 447 bytes)
sgsnemu_patch.pcap (application/octet-stream — 1.7 KB)

Show replies by date

Pau Espin Pedrol

24 Jan 24 Jan

4:18 p.m.

Hi Viktor,

indeed, you found a bug I introduced in osmo-ggsn 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6, sorry for that, I didn't notice it since I was testing it with osmo-sgsn instead of using sgsnemu.

You patch is fine, but I'd argue it would be more correct to use "< 1" for the condition since it now returns the amount of addresses parsed (or -1 in case of error). And better add whitespace in the comparison.

Can you please submit the patch to gerrit? Add a reference to its description: Fixes: 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 ("Add support for IPv4v6 End User Addresses")

You can add me as reviewer.

Also please note that sgsnemu doesn't yet support IPv4v6 EUAs as opposed to osmo-ggsn. I only added support for it (in the commit introducing the bug) because modems in osmo-gsm-tester were using that one and I needed to support it in osmo-ggsn to have the tests working. As I never used sgsnemu before, I only patched it to account for the changes in libgtp but without adding the support for the new feature there.

Regards,

-- - Pau Espin Pedrol pespin@sysmocom.de http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte

Viktor Tsymbalyuk

25 Jan 25 Jan

3:52 p.m.

Hello Pau,

Thank you for detailed answer.

...

Can you please submit the patch to gerrit?

yes, I'll do it. But please give me some time. gerrit - is a new challenge for me))))

Thank you.

-- Viktor On 2018-01-24 17:18, Pau Espin Pedrol wrote: > Hi Viktor, > > indeed, you found a bug I introduced in osmo-ggsn > 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6, sorry for that, I didn't > notice it since I was testing it with osmo-sgsn instead of using sgsnemu. > > You patch is fine, but I'd argue it would be more correct to use "< 1" > for the condition since it now returns the amount of addresses parsed > (or -1 in case of error). And better add whitespace in the comparison. > > Can you please submit the patch to gerrit? Add a reference to its > description: > Fixes: 2d6a69e69a4b4cb2b8cc63c4810dae44e5a4d8f6 ("Add support for > IPv4v6 End User Addresses") > > You can add me as reviewer. > > Also please note that sgsnemu doesn't yet support IPv4v6 EUAs as > opposed to osmo-ggsn. I only added support for it (in the commit > introducing the bug) because modems in osmo-gsm-tester were using that > one and I needed to support it in osmo-ggsn to have the tests working. > As I never used sgsnemu before, I only patched it to account for the > changes in libgtp but without adding the support for the new feature > there. > > Regards, >

Pau Espin Pedrol

3:56 p.m.

Hi Viktor,

You can find all the related gerrit information in https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit

Feel free to improve if you see something wrong/missing. If you lack wiki edit permissions, ask for them in IRC.

Viktor Tsymbalyuk

26 Jan 26 Jan

12:05 p.m.

Hello Pau,

Thank you for the link. I've done it.

Thank you. -- Viktor

On 2018-01-25 16:56, Pau Espin Pedrol wrote:

...

Hi Viktor,

You can find all the related gerrit information in https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit

Feel free to improve if you see something wrong/missing. If you lack wiki edit permissions, ask for them in IRC.

2842

Age (days ago)

2844

Last active (days ago)

osmocom-net-gprs@lists.osmocom.org

4 comments

2 participants

tags (0)

participants (2)

Pau Espin Pedrol
Viktor Tsymbalyuk