On Sat, Jun 16, 2012 at 11:33:54AM +0400, Alexander Chemeris wrote:
Hi Harald,
Hi,
Could we setup a commit mailing list to know when someone commits?
And is an ability to make commit reviews, like in Google Code or github?
so far the amount of external patches were always so low that reviewing them on the mailinglist were okay. I would propose we do the same for the PCU. In case this doesn't scale we can introduce a Gerrit.
does it make sense?
holger
Hi Holger,
That's fine for external patches, but we usually review internal commits as well. I think the easiest way is to create a github mirror and use its facilities fit sending emails and reviewing. I just have to learn how to setup this mirroring.
Sent from my Android device.
-- Regards, Alexander Chemeris CEO, Fairwaves LLC http://fairwaves.ru 16.06.2012 12:25 пользователь "Holger Hans Peter Freyther" < hfreyther@sysmocom.de> написал:
On Sat, Jun 16, 2012 at 11:33:54AM +0400, Alexander Chemeris wrote:
Hi Harald,
Hi,
Could we setup a commit mailing list to know when someone commits?
And is an ability to make commit reviews, like in Google Code or github?
so far the amount of external patches were always so low that reviewing them on the mailinglist were okay. I would propose we do the same for the PCU. In case this doesn't scale we can introduce a Gerrit.
does it make sense?
holger
--
- Holger Freyther hfreyther@sysmocom.de http://www.sysmocom.de/
=======================================================================
- sysmocom - systems for mobile communications GmbH
- Schivelbeiner Str. 5
- 10439 Berlin, Germany
- Sitz / Registered office: Berlin, HRB 134158 B
- Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte
On Sat, Jun 16, 2012 at 10:25:41AM +0200, Holger Hans Peter Freyther wrote:
On Sat, Jun 16, 2012 at 11:33:54AM +0400, Alexander Chemeris wrote:
Hi Harald,
Hi,
Could we setup a commit mailing list to know when someone commits?
And is an ability to make commit reviews, like in Google Code or github?
so far the amount of external patches were always so low that reviewing them on the mailinglist were okay. I would propose we do the same for the PCU. In case this doesn't scale we can introduce a Gerrit.
does it make sense?
Don't know if this is exactly what you need, I've been using "patchwork" for some time:
http://ozlabs.org/~jk/projects/patchwork/
It's relatively easy to deploy and it provides a list of pending patches.
It's being used by several FOSS projects regarding Linux:
In general, I think it's a good practise to send patches first to the mailing list for review before committing them in projects. If nobody complains, apply it. It also forces you to produce good patchsets, ie. contributions splitted into logical pieces with good changelog descriptions that people can track.
This can probably be too much overhead if the amount of people contributing to this is relatively small and the amount of contributed changes is relatively.
On Sat, Jun 16, 2012 at 11:51 PM, Pablo Neira Ayuso pablo@gnumonks.org wrote:
On Sat, Jun 16, 2012 at 10:25:41AM +0200, Holger Hans Peter Freyther wrote:
On Sat, Jun 16, 2012 at 11:33:54AM +0400, Alexander Chemeris wrote:
Hi Harald,
Hi,
Could we setup a commit mailing list to know when someone commits?
And is an ability to make commit reviews, like in Google Code or github?
so far the amount of external patches were always so low that reviewing them on the mailinglist were okay. I would propose we do the same for the PCU. In case this doesn't scale we can introduce a Gerrit.
does it make sense?
Don't know if this is exactly what you need, I've been using "patchwork" for some time:
http://ozlabs.org/~jk/projects/patchwork/
It's relatively easy to deploy and it provides a list of pending patches.
It's being used by several FOSS projects regarding Linux:
In general, I think it's a good practise to send patches first to the mailing list for review before committing them in projects. If nobody complains, apply it. It also forces you to produce good patchsets, ie. contributions splitted into logical pieces with good changelog descriptions that people can track.
This can probably be too much overhead if the amount of people contributing to this is relatively small and the amount of contributed changes is relatively.
Yes, I think it's too much overhead in our case. But thank you for the link anyway - the tool looks interesting.
osmocom-net-gprs@lists.osmocom.org
-
Alexander Chemeris -
Holger Hans Peter Freyther -
Pablo Neira Ayuso