On Mon, Apr 27, 2020 at 08:08:14PM +0900, Yoshiyuki Kurauchi wrote:

In drivers/net/gtp.c, gtp_genl_dump_pdp() should set NLM_F_MULTI flag since it returns multipart message. This patch adds a new arg "flags" in gtp_genl_fill_info() so that flags can be set by the callers.

Looks good, would you repost this and Cc: netdev@vger.kernel.org

You will have to specify what tree you're targetting this to (either net or net-next).

Thanks.

Signed-off-by: Yoshiyuki Kurauchi ahochauwaaaaa@gmail.com

drivers/net/gtp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 672cd2caf2fb..21640a035d7d 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -1169,11 +1169,11 @@ static int gtp_genl_del_pdp(struct sk_buff *skb, struct genl_info *info) static struct genl_family gtp_genl_family;

static int gtp_genl_fill_info(struct sk_buff *skb, u32 snd_portid, u32 snd_seq,

• 	      u32 type, struct pdp_ctx *pctx)
  

• 	      int flags, u32 type, struct pdp_ctx *pctx)
  

{ void *genlh;

• genlh = genlmsg_put(skb, snd_portid, snd_seq, &gtp_genl_family, 0,

• genlh = genlmsg_put(skb, snd_portid, snd_seq, &gtp_genl_family, flags, type); if (genlh == NULL) goto nlmsg_failure;

@@ -1227,8 +1227,8 @@ static int gtp_genl_get_pdp(struct sk_buff *skb, struct genl_info *info) goto err_unlock; }

• err = gtp_genl_fill_info(skb2, NETLINK_CB(skb).portid,

• 		 info->snd_seq, info->nlhdr->nlmsg_type, pctx);
  

• err = gtp_genl_fill_info(skb2, NETLINK_CB(skb).portid, info->snd_seq,

• 		 0, info->nlhdr->nlmsg_type, pctx);
  

  if (err < 0) goto err_unlock_free;

@@ -1271,6 +1271,7 @@ static int gtp_genl_dump_pdp(struct sk_buff *skb, gtp_genl_fill_info(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,

• 			    NLM_F_MULTI,
  		    cb->nlh->nlmsg_type, pctx)) {
  		cb->args[0] = i;
  		cb->args[1] = j;
  

-- 2.17.1